[meta-networking][PATCH 1/2] spice: append -Wno-error=address-of-packed-member only for target

[meta-networking][PATCH 1/2] spice: append -Wno-error=address-of-packed-member only for target

[Martin Jansa]

* with older native gcc on host this will break spice-native with:
  cc1: error: -Werror=address-of-packed-member: no option -Waddress-of-packed-member

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta-networking/recipes-support/spice/spice_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-networking/recipes-support/spice/spice_git.bb b/meta-networking/recipes-support/spice/spice_git.bb
index 30e939ac07..2829a59d15 100644
--- a/meta-networking/recipes-support/spice/spice_git.bb
+++ b/meta-networking/recipes-support/spice/spice_git.bb
@@ -37,7 +37,7 @@ DEPENDS_append_class-nativesdk = "nativesdk-openssl"
 export PYTHON="${STAGING_BINDIR_NATIVE}/python-native/python"
 export PYTHONPATH="${PKG_CONFIG_SYSROOT_DIR}${libdir}/python2.7/site-packages"
 
-CFLAGS_append = " -Wno-error=address-of-packed-member"
+CFLAGS_append_class-target = " -Wno-error=address-of-packed-member"
 
 PACKAGECONFIG_class-nativesdk = ""
 PACKAGECONFIG ?= "sasl"
-- 
2.17.1

[meta-networking][PATCH 2/2] Revert "spice: Drop broken native"

[Martin Jansa]

This reverts commit 5f32fd6b08d79b9a4d1bffb9b2bcbc535a5b27d2.

* fixed by restricting -Wno-error=address-of-packed-member only for
  target, spice-native is still useful for qemu-native when spice
  PACKAGECONFIG is enabled

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta-networking/recipes-support/spice/spice_git.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-networking/recipes-support/spice/spice_git.bb b/meta-networking/recipes-support/spice/spice_git.bb
index 2829a59d15..39bee99a4a 100644
--- a/meta-networking/recipes-support/spice/spice_git.bb
+++ b/meta-networking/recipes-support/spice/spice_git.bb
@@ -39,6 +39,7 @@ export PYTHONPATH="${PKG_CONFIG_SYSROOT_DIR}${libdir}/python2.7/site-packages"
 
 CFLAGS_append_class-target = " -Wno-error=address-of-packed-member"
 
+PACKAGECONFIG_class-native = ""
 PACKAGECONFIG_class-nativesdk = ""
 PACKAGECONFIG ?= "sasl"
 
@@ -53,6 +54,6 @@ PACKAGECONFIG[xinerama] = "--enable-xinerama,--disable-xinerama,libxinerama,"
 
 COMPATIBLE_HOST = '(x86_64|i.86).*-linux'
 
-BBCLASSEXTEND = "nativesdk"
+BBCLASSEXTEND = "native nativesdk"
 
 EXTRA_OECONF_append_toolchain-clang = " --disable-werror"
-- 
2.17.1

Re: [meta-networking][PATCH 1/2] spice: append -Wno-error=address-of-packed-member only for target

[Martin Jansa]

It looks like it's also needed for nativesdk. Will send v2 soon.

On Thu, Sep 26, 2019 at 6:26 PM Martin Jansa <martin.jansa@gmail.com> wrote:

> * with older native gcc on host this will break spice-native with:
>   cc1: error: -Werror=address-of-packed-member: no option
> -Waddress-of-packed-member
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta-networking/recipes-support/spice/spice_git.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-networking/recipes-support/spice/spice_git.bb
> b/meta-networking/recipes-support/spice/spice_git.bb
> index 30e939ac07..2829a59d15 100644
> --- a/meta-networking/recipes-support/spice/spice_git.bb
> +++ b/meta-networking/recipes-support/spice/spice_git.bb
> @@ -37,7 +37,7 @@ DEPENDS_append_class-nativesdk = "nativesdk-openssl"
>  export PYTHON="${STAGING_BINDIR_NATIVE}/python-native/python"
>  export
> PYTHONPATH="${PKG_CONFIG_SYSROOT_DIR}${libdir}/python2.7/site-packages"
>
> -CFLAGS_append = " -Wno-error=address-of-packed-member"
> +CFLAGS_append_class-target = " -Wno-error=address-of-packed-member"
>
>  PACKAGECONFIG_class-nativesdk = ""
>  PACKAGECONFIG ?= "sasl"
> --
> 2.17.1
>
>

Re: [meta-networking][PATCH 1/2] spice: append -Wno-error=address-of-packed-member only for target

[Khem Raj]

On 9/26/19 9:26 AM, Martin Jansa wrote:
> * with older native gcc on host this will break spice-native with:
>    cc1: error: -Werror=address-of-packed-member: no option -Waddress-of-packed-member
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>   meta-networking/recipes-support/spice/spice_git.bb | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-networking/recipes-support/spice/spice_git.bb b/meta-networking/recipes-support/spice/spice_git.bb
> index 30e939ac07..2829a59d15 100644
> --- a/meta-networking/recipes-support/spice/spice_git.bb
> +++ b/meta-networking/recipes-support/spice/spice_git.bb
> @@ -37,7 +37,7 @@ DEPENDS_append_class-nativesdk = "nativesdk-openssl"
>   export PYTHON="${STAGING_BINDIR_NATIVE}/python-native/python"
>   export PYTHONPATH="${PKG_CONFIG_SYSROOT_DIR}${libdir}/python2.7/site-packages"
>   
> -CFLAGS_append = " -Wno-error=address-of-packed-member"
> +CFLAGS_append_class-target = " -Wno-error=address-of-packed-member"
>   

There are hosts with newer version of gcc and I think they will start to 
fail. So I guess we could try to use ${@oe.utils.host_gcc_version(d, 
taskcontextonly=True)} to deduce host gcc version, another option is to
add something like --disable-werror and move on.

>   PACKAGECONFIG_class-nativesdk = ""
>   PACKAGECONFIG ?= "sasl"
> 

Re: [meta-networking][PATCH 1/2] spice: append -Wno-error=address-of-packed-member only for target

[Adrian Bunk]

On Thu, Sep 26, 2019 at 04:26:54PM +0000, Martin Jansa wrote:
> * with older native gcc on host this will break spice-native with:
>   cc1: error: -Werror=address-of-packed-member: no option -Waddress-of-packed-member
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta-networking/recipes-support/spice/spice_git.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-networking/recipes-support/spice/spice_git.bb b/meta-networking/recipes-support/spice/spice_git.bb
> index 30e939ac07..2829a59d15 100644
> --- a/meta-networking/recipes-support/spice/spice_git.bb
> +++ b/meta-networking/recipes-support/spice/spice_git.bb
> @@ -37,7 +37,7 @@ DEPENDS_append_class-nativesdk = "nativesdk-openssl"
>  export PYTHON="${STAGING_BINDIR_NATIVE}/python-native/python"
>  export PYTHONPATH="${PKG_CONFIG_SYSROOT_DIR}${libdir}/python2.7/site-packages"
>  
> -CFLAGS_append = " -Wno-error=address-of-packed-member"
> +CFLAGS_append_class-target = " -Wno-error=address-of-packed-member"
>...

Least hassle would be
  CFLAGS_append = " -Wno-error"

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [meta-networking][PATCH 1/2] spice: append -Wno-error=address-of-packed-member only for target

[Robert Yang]

On 9/27/19 3:48 AM, Adrian Bunk wrote:
> On Thu, Sep 26, 2019 at 04:26:54PM +0000, Martin Jansa wrote:
>> * with older native gcc on host this will break spice-native with:
>>    cc1: error: -Werror=address-of-packed-member: no option -Waddress-of-packed-member
>>
>> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
>> ---
>>   meta-networking/recipes-support/spice/spice_git.bb | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-networking/recipes-support/spice/spice_git.bb b/meta-networking/recipes-support/spice/spice_git.bb
>> index 30e939ac07..2829a59d15 100644
>> --- a/meta-networking/recipes-support/spice/spice_git.bb
>> +++ b/meta-networking/recipes-support/spice/spice_git.bb
>> @@ -37,7 +37,7 @@ DEPENDS_append_class-nativesdk = "nativesdk-openssl"
>>   export PYTHON="${STAGING_BINDIR_NATIVE}/python-native/python"
>>   export PYTHONPATH="${PKG_CONFIG_SYSROOT_DIR}${libdir}/python2.7/site-packages"
>>   
>> -CFLAGS_append = " -Wno-error=address-of-packed-member"
>> +CFLAGS_append_class-target = " -Wno-error=address-of-packed-member"

Yes, the error was the same as you mentioned in the commit message, and
"bitbake spice-native" works with this change.

>> ...
> 
> Least hassle would be
>    CFLAGS_append = " -Wno-error"

"bitbake nativesdk-spice" works with this change, otherwise, it doesn't work.

This patch works for me.

// Robert

> 
> cu
> Adrian
> 

Re: [meta-networking][PATCH 1/2] spice: append -Wno-error=address-of-packed-member only for target

[Robert Yang]

Hi Martin,

We found another problem on spice_git.bb:

PACKAGECONFIG[smartcard] = "--enable-smartcard,--disable-smartcard,libcacard,"

I can't find libcacard:

http://layers.openembedded.org/layerindex/branch/master/recipes/?q=libcacard


So it seems that this PACKAGECONFIG is invalid, should we remove it?

// Robert

On 9/27/19 11:56 AM, Robert Yang wrote:
> 
> 
> On 9/27/19 3:48 AM, Adrian Bunk wrote:
>> On Thu, Sep 26, 2019 at 04:26:54PM +0000, Martin Jansa wrote:
>>> * with older native gcc on host this will break spice-native with:
>>>    cc1: error: -Werror=address-of-packed-member: no option 
>>> -Waddress-of-packed-member
>>>
>>> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
>>> ---
>>>   meta-networking/recipes-support/spice/spice_git.bb | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta-networking/recipes-support/spice/spice_git.bb 
>>> b/meta-networking/recipes-support/spice/spice_git.bb
>>> index 30e939ac07..2829a59d15 100644
>>> --- a/meta-networking/recipes-support/spice/spice_git.bb
>>> +++ b/meta-networking/recipes-support/spice/spice_git.bb
>>> @@ -37,7 +37,7 @@ DEPENDS_append_class-nativesdk = "nativesdk-openssl"
>>>   export PYTHON="${STAGING_BINDIR_NATIVE}/python-native/python"
>>>   export PYTHONPATH="${PKG_CONFIG_SYSROOT_DIR}${libdir}/python2.7/site-packages"
>>> -CFLAGS_append = " -Wno-error=address-of-packed-member"
>>> +CFLAGS_append_class-target = " -Wno-error=address-of-packed-member"
> 
> Yes, the error was the same as you mentioned in the commit message, and
> "bitbake spice-native" works with this change.
> 
>>> ...
>>
>> Least hassle would be
>>    CFLAGS_append = " -Wno-error"
> 
> "bitbake nativesdk-spice" works with this change, otherwise, it doesn't work.
> 
> This patch works for me.
> 
> // Robert
> 
>>
>> cu
>> Adrian
>>

Re: [meta-networking][PATCH 1/2] spice: append -Wno-error=address-of-packed-member only for target

[Martin Jansa]

Why? there are many PACKAGECONFIGs for optional dependencies which aren't
in the same layer as the recipe with that PACKAGECONFIG.

As long as it's not enabled by default it is correct to have the
PACKAGECONFIG to control the dependency explicitly.

Cheers,

On Fri, Sep 27, 2019 at 9:20 AM Robert Yang <liezhi.yang@windriver.com>
wrote:

> Hi Martin,
>
> We found another problem on spice_git.bb:
>
> PACKAGECONFIG[smartcard] =
> "--enable-smartcard,--disable-smartcard,libcacard,"
>
> I can't find libcacard:
>
>
> http://layers.openembedded.org/layerindex/branch/master/recipes/?q=libcacard
>
>
> So it seems that this PACKAGECONFIG is invalid, should we remove it?
>
> // Robert
>
> On 9/27/19 11:56 AM, Robert Yang wrote:
> >
> >
> > On 9/27/19 3:48 AM, Adrian Bunk wrote:
> >> On Thu, Sep 26, 2019 at 04:26:54PM +0000, Martin Jansa wrote:
> >>> * with older native gcc on host this will break spice-native with:
> >>>    cc1: error: -Werror=address-of-packed-member: no option
> >>> -Waddress-of-packed-member
> >>>
> >>> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> >>> ---
> >>>   meta-networking/recipes-support/spice/spice_git.bb | 2 +-
> >>>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/meta-networking/recipes-support/spice/spice_git.bb
> >>> b/meta-networking/recipes-support/spice/spice_git.bb
> >>> index 30e939ac07..2829a59d15 100644
> >>> --- a/meta-networking/recipes-support/spice/spice_git.bb
> >>> +++ b/meta-networking/recipes-support/spice/spice_git.bb
> >>> @@ -37,7 +37,7 @@ DEPENDS_append_class-nativesdk = "nativesdk-openssl"
> >>>   export PYTHON="${STAGING_BINDIR_NATIVE}/python-native/python"
> >>>   export
> PYTHONPATH="${PKG_CONFIG_SYSROOT_DIR}${libdir}/python2.7/site-packages"
> >>> -CFLAGS_append = " -Wno-error=address-of-packed-member"
> >>> +CFLAGS_append_class-target = " -Wno-error=address-of-packed-member"
> >
> > Yes, the error was the same as you mentioned in the commit message, and
> > "bitbake spice-native" works with this change.
> >
> >>> ...
> >>
> >> Least hassle would be
> >>    CFLAGS_append = " -Wno-error"
> >
> > "bitbake nativesdk-spice" works with this change, otherwise, it doesn't
> work.
> >
> > This patch works for me.
> >
> > // Robert
> >
> >>
> >> cu
> >> Adrian
> >>
>

Re: [meta-networking][PATCH 1/2] spice: append -Wno-error=address-of-packed-member only for target

[Khem Raj]

On Fri, Sep 27, 2019 at 12:42 AM Martin Jansa <martin.jansa@gmail.com> wrote:
>
> Why? there are many PACKAGECONFIGs for optional dependencies which aren't
> in the same layer as the recipe with that PACKAGECONFIG.
>
> As long as it's not enabled by default it is correct to have the
> PACKAGECONFIG to control the dependency explicitly.
>

right

> Cheers,
>
> On Fri, Sep 27, 2019 at 9:20 AM Robert Yang <liezhi.yang@windriver.com>
> wrote:
>
> > Hi Martin,
> >
> > We found another problem on spice_git.bb:
> >
> > PACKAGECONFIG[smartcard] =
> > "--enable-smartcard,--disable-smartcard,libcacard,"
> >
> > I can't find libcacard:
> >
> >
> > http://layers.openembedded.org/layerindex/branch/master/recipes/?q=libcacard
> >
> >
> > So it seems that this PACKAGECONFIG is invalid, should we remove it?
> >
> > // Robert
> >
> > On 9/27/19 11:56 AM, Robert Yang wrote:
> > >
> > >
> > > On 9/27/19 3:48 AM, Adrian Bunk wrote:
> > >> On Thu, Sep 26, 2019 at 04:26:54PM +0000, Martin Jansa wrote:
> > >>> * with older native gcc on host this will break spice-native with:
> > >>>    cc1: error: -Werror=address-of-packed-member: no option
> > >>> -Waddress-of-packed-member
> > >>>
> > >>> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > >>> ---
> > >>>   meta-networking/recipes-support/spice/spice_git.bb | 2 +-
> > >>>   1 file changed, 1 insertion(+), 1 deletion(-)
> > >>>
> > >>> diff --git a/meta-networking/recipes-support/spice/spice_git.bb
> > >>> b/meta-networking/recipes-support/spice/spice_git.bb
> > >>> index 30e939ac07..2829a59d15 100644
> > >>> --- a/meta-networking/recipes-support/spice/spice_git.bb
> > >>> +++ b/meta-networking/recipes-support/spice/spice_git.bb
> > >>> @@ -37,7 +37,7 @@ DEPENDS_append_class-nativesdk = "nativesdk-openssl"
> > >>>   export PYTHON="${STAGING_BINDIR_NATIVE}/python-native/python"
> > >>>   export
> > PYTHONPATH="${PKG_CONFIG_SYSROOT_DIR}${libdir}/python2.7/site-packages"
> > >>> -CFLAGS_append = " -Wno-error=address-of-packed-member"
> > >>> +CFLAGS_append_class-target = " -Wno-error=address-of-packed-member"
> > >
> > > Yes, the error was the same as you mentioned in the commit message, and
> > > "bitbake spice-native" works with this change.
> > >
> > >>> ...
> > >>
> > >> Least hassle would be
> > >>    CFLAGS_append = " -Wno-error"
> > >
> > > "bitbake nativesdk-spice" works with this change, otherwise, it doesn't
> > work.
> > >
> > > This patch works for me.
> > >
> > > // Robert
> > >
> > >>
> > >> cu
> > >> Adrian
> > >>
> >
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-networking][PATCH 1/2] spice: append -Wno-error=address-of-packed-member only for target

[Robert Yang]

On 9/27/19 3:43 PM, Khem Raj wrote:
> On Fri, Sep 27, 2019 at 12:42 AM Martin Jansa <martin.jansa@gmail.com> wrote:
>>
>> Why? there are many PACKAGECONFIGs for optional dependencies which aren't
>> in the same layer as the recipe with that PACKAGECONFIG.
>>
>> As long as it's not enabled by default it is correct to have the
>> PACKAGECONFIG to control the dependency explicitly.
>>
> 
> right

Got it, thanks.

// Robert

> 
>> Cheers,
>>
>> On Fri, Sep 27, 2019 at 9:20 AM Robert Yang <liezhi.yang@windriver.com>
>> wrote:
>>
>>> Hi Martin,
>>>
>>> We found another problem on spice_git.bb:
>>>
>>> PACKAGECONFIG[smartcard] =
>>> "--enable-smartcard,--disable-smartcard,libcacard,"
>>>
>>> I can't find libcacard:
>>>
>>>
>>> http://layers.openembedded.org/layerindex/branch/master/recipes/?q=libcacard
>>>
>>>
>>> So it seems that this PACKAGECONFIG is invalid, should we remove it?
>>>
>>> // Robert
>>>
>>> On 9/27/19 11:56 AM, Robert Yang wrote:
>>>>
>>>>
>>>> On 9/27/19 3:48 AM, Adrian Bunk wrote:
>>>>> On Thu, Sep 26, 2019 at 04:26:54PM +0000, Martin Jansa wrote:
>>>>>> * with older native gcc on host this will break spice-native with:
>>>>>>     cc1: error: -Werror=address-of-packed-member: no option
>>>>>> -Waddress-of-packed-member
>>>>>>
>>>>>> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
>>>>>> ---
>>>>>>    meta-networking/recipes-support/spice/spice_git.bb | 2 +-
>>>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/meta-networking/recipes-support/spice/spice_git.bb
>>>>>> b/meta-networking/recipes-support/spice/spice_git.bb
>>>>>> index 30e939ac07..2829a59d15 100644
>>>>>> --- a/meta-networking/recipes-support/spice/spice_git.bb
>>>>>> +++ b/meta-networking/recipes-support/spice/spice_git.bb
>>>>>> @@ -37,7 +37,7 @@ DEPENDS_append_class-nativesdk = "nativesdk-openssl"
>>>>>>    export PYTHON="${STAGING_BINDIR_NATIVE}/python-native/python"
>>>>>>    export
>>> PYTHONPATH="${PKG_CONFIG_SYSROOT_DIR}${libdir}/python2.7/site-packages"
>>>>>> -CFLAGS_append = " -Wno-error=address-of-packed-member"
>>>>>> +CFLAGS_append_class-target = " -Wno-error=address-of-packed-member"
>>>>
>>>> Yes, the error was the same as you mentioned in the commit message, and
>>>> "bitbake spice-native" works with this change.
>>>>
>>>>>> ...
>>>>>
>>>>> Least hassle would be
>>>>>     CFLAGS_append = " -Wno-error"
>>>>
>>>> "bitbake nativesdk-spice" works with this change, otherwise, it doesn't
>>> work.
>>>>
>>>> This patch works for me.
>>>>
>>>> // Robert
>>>>
>>>>>
>>>>> cu
>>>>> Adrian
>>>>>
>>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>