From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>
Cc: alsa-devel@alsa-project.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jie Yang <yang.jie@linux.intel.com>,
Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
kjlu@umn.edu,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
emamd001@umn.edu, smccaman@umn.edu,
Thomas Gleixner <tglx@linutronix.de>,
Enrico Weigelt <info@metux.net>,
linux-kernel@vger.kernel.org,
Navid Emamdoost <navid.emamdoost@gmail.com>
Subject: Re: [alsa-devel] [PATCH v2] ASoC: Intel: Skylake: prevent memory leak in snd_skl_parse_uuids
Date: Fri, 27 Sep 2019 18:33:04 +0300 [thread overview]
Message-ID: <20190927153304.GS32742@smile.fi.intel.com> (raw)
In-Reply-To: <6966df25-e82c-1abe-6a0f-ff497dcda23b@intel.com>
On Fri, Sep 27, 2019 at 05:10:18PM +0200, Cezary Rojewski wrote:
> I'm fine with solution #1 as I guess asking to wait for refactor is not an
> option. Code deployment is delayed due to range of administrative decisions,
> some of which should be uncovered on alsa-devel soon enough.
The problem with solution #1 is freeing orphaned pointer. It will work,
but it's simple is not okay from object life time prospective.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Navid Emamdoost <navid.emamdoost@gmail.com>,
emamd001@umn.edu, smccaman@umn.edu, kjlu@umn.edu,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Enrico Weigelt <info@metux.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: Intel: Skylake: prevent memory leak in snd_skl_parse_uuids
Date: Fri, 27 Sep 2019 18:33:04 +0300 [thread overview]
Message-ID: <20190927153304.GS32742@smile.fi.intel.com> (raw)
In-Reply-To: <6966df25-e82c-1abe-6a0f-ff497dcda23b@intel.com>
On Fri, Sep 27, 2019 at 05:10:18PM +0200, Cezary Rojewski wrote:
> I'm fine with solution #1 as I guess asking to wait for refactor is not an
> option. Code deployment is delayed due to range of administrative decisions,
> some of which should be uncovered on alsa-devel soon enough.
The problem with solution #1 is freeing orphaned pointer. It will work,
but it's simple is not okay from object life time prospective.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-09-27 15:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 16:19 [PATCH v2] ASoC: Intel: Skylake: prevent memory leak in snd_skl_parse_uuids Navid Emamdoost
2019-09-25 17:05 ` [alsa-devel] " Pierre-Louis Bossart
2019-09-25 17:05 ` Pierre-Louis Bossart
2019-09-27 2:55 ` Navid Emamdoost
2019-09-27 13:14 ` [alsa-devel] " Pierre-Louis Bossart
2019-09-27 13:14 ` Pierre-Louis Bossart
2019-09-27 15:10 ` [alsa-devel] " Cezary Rojewski
2019-09-27 15:10 ` Cezary Rojewski
2019-09-27 15:33 ` Andy Shevchenko [this message]
2019-09-27 15:33 ` Andy Shevchenko
2019-09-27 16:37 ` [alsa-devel] " Pierre-Louis Bossart
2019-09-27 16:37 ` Pierre-Louis Bossart
2019-09-27 20:39 ` Andy Shevchenko
2019-09-27 20:39 ` Andy Shevchenko
2019-09-27 22:25 ` Pierre-Louis Bossart
2019-09-27 22:25 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190927153304.GS32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=emamd001@umn.edu \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=kjlu@umn.edu \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=smccaman@umn.edu \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.