* [thud/master PATCH v2] recipes-bsp: ivshmem-uio: Add new recipe for ivshmem-uio driver
@ 2019-09-27 9:16 Nikhil Devshatwar
2019-09-27 15:46 ` Denys Dmytriyenko
2019-10-01 6:41 ` Khem Raj
0 siblings, 2 replies; 7+ messages in thread
From: Nikhil Devshatwar @ 2019-09-27 9:16 UTC (permalink / raw)
To: meta-ti
This is external kernel module which enables userspace io over the
Jailhouse ivhsmem (inter VM shared memory)
This driver is useful to test the inter VM communication.
Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
---
Changes from v1:
* Split the ivshmem recipe separately
* Add summary and remove PACKAGE_ARCH define
recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb | 27 +++++++++++++++++++++++
1 file changed, 27 insertions(+)
create mode 100644 recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb
diff --git a/recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb b/recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb
new file mode 100644
index 0000000..33fb946
--- /dev/null
+++ b/recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb
@@ -0,0 +1,27 @@
+DESCRIPTION = "Kernel driver for IVSHMEM based UIO driver"
+SUMMARY = "Kernel module which registers a UIO (userspace io) device for inter VM shared memory"
+HOMEPAGE = "https://github.com/henning-schild-work/ivshmem-guest-code"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=0546a27aad86c83b75ad4ee6133e9d5e"
+
+inherit module
+
+RDEPENDS_${PN} = "jailhouse"
+
+PROTOCOL = "git"
+BRANCH = "jailhouse"
+SRCREV = "f3ad79881bebb6c6068966ee3d265d8034c20492"
+SRC_URI = "git://github.com/henning-schild-work/ivshmem-guest-code.git;protocol=${PROTOCOL};branch=${BRANCH}"
+
+S = "${WORKDIR}/git"
+
+EXTRA_OEMAKE += 'KDIR="${STAGING_KERNEL_DIR}"'
+
+do_compile_prepend() {
+ cd ${S}/kernel_module/uio
+}
+
+do_install() {
+ install -d ${D}/${base_libdir}/modules/${KERNEL_VERSION}/extra
+ install -m 644 ${S}/kernel_module/uio/uio_ivshmem.ko ${D}/${base_libdir}/modules/${KERNEL_VERSION}/extra
+}
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [thud/master PATCH v2] recipes-bsp: ivshmem-uio: Add new recipe for ivshmem-uio driver
2019-09-27 9:16 [thud/master PATCH v2] recipes-bsp: ivshmem-uio: Add new recipe for ivshmem-uio driver Nikhil Devshatwar
@ 2019-09-27 15:46 ` Denys Dmytriyenko
2019-10-01 6:41 ` Khem Raj
1 sibling, 0 replies; 7+ messages in thread
From: Denys Dmytriyenko @ 2019-09-27 15:46 UTC (permalink / raw)
To: Nikhil Devshatwar; +Cc: meta-ti
On Fri, Sep 27, 2019 at 02:46:44PM +0530, Nikhil Devshatwar wrote:
> This is external kernel module which enables userspace io over the
> Jailhouse ivhsmem (inter VM shared memory)
> This driver is useful to test the inter VM communication.
>
> Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
> ---
> Changes from v1:
> * Split the ivshmem recipe separately
> * Add summary and remove PACKAGE_ARCH define
>
> recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb | 27 +++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
> create mode 100644 recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb
>
> diff --git a/recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb b/recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb
> new file mode 100644
> index 0000000..33fb946
> --- /dev/null
> +++ b/recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb
> @@ -0,0 +1,27 @@
> +DESCRIPTION = "Kernel driver for IVSHMEM based UIO driver"
> +SUMMARY = "Kernel module which registers a UIO (userspace io) device for inter VM shared memory"
The other way around - SUMMARY is short and DESCRIPTION is long.
> +HOMEPAGE = "https://github.com/henning-schild-work/ivshmem-guest-code"
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=0546a27aad86c83b75ad4ee6133e9d5e"
> +
> +inherit module
> +
> +RDEPENDS_${PN} = "jailhouse"
> +
> +PROTOCOL = "git"
> +BRANCH = "jailhouse"
> +SRCREV = "f3ad79881bebb6c6068966ee3d265d8034c20492"
> +SRC_URI = "git://github.com/henning-schild-work/ivshmem-guest-code.git;protocol=${PROTOCOL};branch=${BRANCH}"
> +
> +S = "${WORKDIR}/git"
> +
> +EXTRA_OEMAKE += 'KDIR="${STAGING_KERNEL_DIR}"'
> +
> +do_compile_prepend() {
> + cd ${S}/kernel_module/uio
> +}
> +
> +do_install() {
> + install -d ${D}/${base_libdir}/modules/${KERNEL_VERSION}/extra
> + install -m 644 ${S}/kernel_module/uio/uio_ivshmem.ko ${D}/${base_libdir}/modules/${KERNEL_VERSION}/extra
> +}
> --
> 1.9.1
>
> --
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [thud/master PATCH v2] recipes-bsp: ivshmem-uio: Add new recipe for ivshmem-uio driver
2019-09-27 9:16 [thud/master PATCH v2] recipes-bsp: ivshmem-uio: Add new recipe for ivshmem-uio driver Nikhil Devshatwar
2019-09-27 15:46 ` Denys Dmytriyenko
@ 2019-10-01 6:41 ` Khem Raj
2019-10-01 20:07 ` Denys Dmytriyenko
1 sibling, 1 reply; 7+ messages in thread
From: Khem Raj @ 2019-10-01 6:41 UTC (permalink / raw)
To: Nikhil Devshatwar; +Cc: meta-ti
On Fri, Sep 27, 2019 at 2:17 AM Nikhil Devshatwar <nikhil.nd@ti.com> wrote:
>
> This is external kernel module which enables userspace io over the
> Jailhouse ivhsmem (inter VM shared memory)
> This driver is useful to test the inter VM communication.
>
> Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
> ---
> Changes from v1:
> * Split the ivshmem recipe separately
> * Add summary and remove PACKAGE_ARCH define
>
> recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb | 27 +++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
> create mode 100644 recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb
>
> diff --git a/recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb b/recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb
> new file mode 100644
> index 0000000..33fb946
> --- /dev/null
> +++ b/recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb
> @@ -0,0 +1,27 @@
> +DESCRIPTION = "Kernel driver for IVSHMEM based UIO driver"
> +SUMMARY = "Kernel module which registers a UIO (userspace io) device for inter VM shared memory"
> +HOMEPAGE = "https://github.com/henning-schild-work/ivshmem-guest-code"
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=0546a27aad86c83b75ad4ee6133e9d5e"
> +
> +inherit module
> +
> +RDEPENDS_${PN} = "jailhouse"
> +
jailhouse is marked as ti-soc specific, so please mark this recipe
ti-soc specific as well. It will help meta-ti to live in a multi-BSP
distros
http://jenkins.nas-admin.org/view/OE/job/oe_world_qemux86-64/1164/consoleFull
if you could test meta-ti patches with one non-ti machine like qemux86
or some such it will help catch this kind of errors
> +PROTOCOL = "git"
> +BRANCH = "jailhouse"
> +SRCREV = "f3ad79881bebb6c6068966ee3d265d8034c20492"
> +SRC_URI = "git://github.com/henning-schild-work/ivshmem-guest-code.git;protocol=${PROTOCOL};branch=${BRANCH}"
> +
> +S = "${WORKDIR}/git"
> +
> +EXTRA_OEMAKE += 'KDIR="${STAGING_KERNEL_DIR}"'
> +
> +do_compile_prepend() {
> + cd ${S}/kernel_module/uio
> +}
> +
> +do_install() {
> + install -d ${D}/${base_libdir}/modules/${KERNEL_VERSION}/extra
> + install -m 644 ${S}/kernel_module/uio/uio_ivshmem.ko ${D}/${base_libdir}/modules/${KERNEL_VERSION}/extra
> +}
> --
> 1.9.1
>
> --
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [thud/master PATCH v2] recipes-bsp: ivshmem-uio: Add new recipe for ivshmem-uio driver
2019-10-01 6:41 ` Khem Raj
@ 2019-10-01 20:07 ` Denys Dmytriyenko
2019-10-01 21:57 ` Khem Raj
0 siblings, 1 reply; 7+ messages in thread
From: Denys Dmytriyenko @ 2019-10-01 20:07 UTC (permalink / raw)
To: Khem Raj; +Cc: meta-ti
On Mon, Sep 30, 2019 at 11:41:43PM -0700, Khem Raj wrote:
> On Fri, Sep 27, 2019 at 2:17 AM Nikhil Devshatwar <nikhil.nd@ti.com> wrote:
> >
> > This is external kernel module which enables userspace io over the
> > Jailhouse ivhsmem (inter VM shared memory)
> > This driver is useful to test the inter VM communication.
> >
> > Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
> > ---
> > Changes from v1:
> > * Split the ivshmem recipe separately
> > * Add summary and remove PACKAGE_ARCH define
> >
> > recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb | 27 +++++++++++++++++++++++
> > 1 file changed, 27 insertions(+)
> > create mode 100644 recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb
> >
> > diff --git a/recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb b/recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb
> > new file mode 100644
> > index 0000000..33fb946
> > --- /dev/null
> > +++ b/recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb
> > @@ -0,0 +1,27 @@
> > +DESCRIPTION = "Kernel driver for IVSHMEM based UIO driver"
> > +SUMMARY = "Kernel module which registers a UIO (userspace io) device for inter VM shared memory"
> > +HOMEPAGE = "https://github.com/henning-schild-work/ivshmem-guest-code"
> > +LICENSE = "GPLv2"
> > +LIC_FILES_CHKSUM = "file://COPYING;md5=0546a27aad86c83b75ad4ee6133e9d5e"
> > +
> > +inherit module
> > +
> > +RDEPENDS_${PN} = "jailhouse"
> > +
>
> jailhouse is marked as ti-soc specific, so please mark this recipe
> ti-soc specific as well. It will help meta-ti to live in a multi-BSP
> distros
>
> http://jenkins.nas-admin.org/view/OE/job/oe_world_qemux86-64/1164/consoleFull
>
> if you could test meta-ti patches with one non-ti machine like qemux86
> or some such it will help catch this kind of errors
That would only fail when building "world", but thanks for the report.
> > +PROTOCOL = "git"
> > +BRANCH = "jailhouse"
> > +SRCREV = "f3ad79881bebb6c6068966ee3d265d8034c20492"
> > +SRC_URI = "git://github.com/henning-schild-work/ivshmem-guest-code.git;protocol=${PROTOCOL};branch=${BRANCH}"
> > +
> > +S = "${WORKDIR}/git"
> > +
> > +EXTRA_OEMAKE += 'KDIR="${STAGING_KERNEL_DIR}"'
> > +
> > +do_compile_prepend() {
> > + cd ${S}/kernel_module/uio
> > +}
> > +
> > +do_install() {
> > + install -d ${D}/${base_libdir}/modules/${KERNEL_VERSION}/extra
> > + install -m 644 ${S}/kernel_module/uio/uio_ivshmem.ko ${D}/${base_libdir}/modules/${KERNEL_VERSION}/extra
> > +}
> > --
> > 1.9.1
> >
> > --
> > _______________________________________________
> > meta-ti mailing list
> > meta-ti@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-ti
> --
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [thud/master PATCH v2] recipes-bsp: ivshmem-uio: Add new recipe for ivshmem-uio driver
2019-10-01 20:07 ` Denys Dmytriyenko
@ 2019-10-01 21:57 ` Khem Raj
2019-10-01 22:16 ` Denys Dmytriyenko
0 siblings, 1 reply; 7+ messages in thread
From: Khem Raj @ 2019-10-01 21:57 UTC (permalink / raw)
To: Denys Dmytriyenko; +Cc: meta-ti
[-- Attachment #1: Type: text/plain, Size: 3311 bytes --]
On Tue, Oct 1, 2019 at 1:07 PM Denys Dmytriyenko <denys@ti.com> wrote:
> On Mon, Sep 30, 2019 at 11:41:43PM -0700, Khem Raj wrote:
> > On Fri, Sep 27, 2019 at 2:17 AM Nikhil Devshatwar <nikhil.nd@ti.com>
> wrote:
> > >
> > > This is external kernel module which enables userspace io over the
> > > Jailhouse ivhsmem (inter VM shared memory)
> > > This driver is useful to test the inter VM communication.
> > >
> > > Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
> > > ---
> > > Changes from v1:
> > > * Split the ivshmem recipe separately
> > > * Add summary and remove PACKAGE_ARCH define
> > >
> > > recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb | 27
> +++++++++++++++++++++++
> > > 1 file changed, 27 insertions(+)
> > > create mode 100644 recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb
> > >
> > > diff --git a/recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb
> b/recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb
> > > new file mode 100644
> > > index 0000000..33fb946
> > > --- /dev/null
> > > +++ b/recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb
> > > @@ -0,0 +1,27 @@
> > > +DESCRIPTION = "Kernel driver for IVSHMEM based UIO driver"
> > > +SUMMARY = "Kernel module which registers a UIO (userspace io) device
> for inter VM shared memory"
> > > +HOMEPAGE = "https://github.com/henning-schild-work/ivshmem-guest-code
> "
> > > +LICENSE = "GPLv2"
> > > +LIC_FILES_CHKSUM =
> "file://COPYING;md5=0546a27aad86c83b75ad4ee6133e9d5e"
> > > +
> > > +inherit module
> > > +
> > > +RDEPENDS_${PN} = "jailhouse"
> > > +
> >
> > jailhouse is marked as ti-soc specific, so please mark this recipe
> > ti-soc specific as well. It will help meta-ti to live in a multi-BSP
> > distros
> >
> >
> http://jenkins.nas-admin.org/view/OE/job/oe_world_qemux86-64/1164/consoleFull
> >
> > if you could test meta-ti patches with one non-ti machine like qemux86
> > or some such it will help catch this kind of errors
>
> That would only fail when building "world", but thanks for the report.
MACHINE=qemux86 bitbake <recipe> would do it
This would really help the distros
>
>
>
> > > +PROTOCOL = "git"
> > > +BRANCH = "jailhouse"
> > > +SRCREV = "f3ad79881bebb6c6068966ee3d265d8034c20492"
> > > +SRC_URI = "git://
> github.com/henning-schild-work/ivshmem-guest-code.git;protocol=${PROTOCOL};branch=${BRANCH}
> <http://github.com/henning-schild-work/ivshmem-guest-code.git;protocol=$%7BPROTOCOL%7D;branch=$%7BBRANCH%7D>
> "
> > > +
> > > +S = "${WORKDIR}/git"
> > > +
> > > +EXTRA_OEMAKE += 'KDIR="${STAGING_KERNEL_DIR}"'
> > > +
> > > +do_compile_prepend() {
> > > + cd ${S}/kernel_module/uio
> > > +}
> > > +
> > > +do_install() {
> > > + install -d ${D}/${base_libdir}/modules/${KERNEL_VERSION}/extra
> > > + install -m 644 ${S}/kernel_module/uio/uio_ivshmem.ko
> ${D}/${base_libdir}/modules/${KERNEL_VERSION}/extra
> > > +}
> > > --
> > > 1.9.1
> > >
> > > --
> > > _______________________________________________
> > > meta-ti mailing list
> > > meta-ti@yoctoproject.org
> > > https://lists.yoctoproject.org/listinfo/meta-ti
> > --
> > _______________________________________________
> > meta-ti mailing list
> > meta-ti@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-ti
>
[-- Attachment #2: Type: text/html, Size: 5507 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [thud/master PATCH v2] recipes-bsp: ivshmem-uio: Add new recipe for ivshmem-uio driver
2019-10-01 21:57 ` Khem Raj
@ 2019-10-01 22:16 ` Denys Dmytriyenko
2019-10-01 22:42 ` Khem Raj
0 siblings, 1 reply; 7+ messages in thread
From: Denys Dmytriyenko @ 2019-10-01 22:16 UTC (permalink / raw)
To: Khem Raj; +Cc: meta-ti
On Tue, Oct 01, 2019 at 02:57:41PM -0700, Khem Raj wrote:
> On Tue, Oct 1, 2019 at 1:07 PM Denys Dmytriyenko <denys@ti.com> wrote:
>
> > On Mon, Sep 30, 2019 at 11:41:43PM -0700, Khem Raj wrote:
> > > On Fri, Sep 27, 2019 at 2:17 AM Nikhil Devshatwar <nikhil.nd@ti.com>
> > wrote:
> > > >
> > > > This is external kernel module which enables userspace io over the
> > > > Jailhouse ivhsmem (inter VM shared memory)
> > > > This driver is useful to test the inter VM communication.
> > > >
> > > > Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
> > > > ---
> > > > Changes from v1:
> > > > * Split the ivshmem recipe separately
> > > > * Add summary and remove PACKAGE_ARCH define
> > > >
> > > > recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb | 27
> > +++++++++++++++++++++++
> > > > 1 file changed, 27 insertions(+)
> > > > create mode 100644 recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb
> > > >
> > > > diff --git a/recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb
> > b/recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb
> > > > new file mode 100644
> > > > index 0000000..33fb946
> > > > --- /dev/null
> > > > +++ b/recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb
> > > > @@ -0,0 +1,27 @@
> > > > +DESCRIPTION = "Kernel driver for IVSHMEM based UIO driver"
> > > > +SUMMARY = "Kernel module which registers a UIO (userspace io) device
> > for inter VM shared memory"
> > > > +HOMEPAGE = "https://github.com/henning-schild-work/ivshmem-guest-code
> > "
> > > > +LICENSE = "GPLv2"
> > > > +LIC_FILES_CHKSUM =
> > "file://COPYING;md5=0546a27aad86c83b75ad4ee6133e9d5e"
> > > > +
> > > > +inherit module
> > > > +
> > > > +RDEPENDS_${PN} = "jailhouse"
> > > > +
> > >
> > > jailhouse is marked as ti-soc specific, so please mark this recipe
> > > ti-soc specific as well. It will help meta-ti to live in a multi-BSP
> > > distros
> > >
> > >
> > http://jenkins.nas-admin.org/view/OE/job/oe_world_qemux86-64/1164/consoleFull
> > >
> > > if you could test meta-ti patches with one non-ti machine like qemux86
> > > or some such it will help catch this kind of errors
> >
> > That would only fail when building "world", but thanks for the report.
>
> MACHINE=qemux86 bitbake <recipe> would do it
> This would really help the distros
Well, I do know how to break it specifically... :) BTW, building it directly
like that with COMPATIBLE_MACHINE set would also fail with "Nothing PROVIDES"
error.
My point was that people add recipes and expect them to only be included in an
image for their machine. In their view they cannot understand how it would get
into an x86 build on its own, unless someone consciously adds it to their
image. Hence my comment about building "world". And in that case it would be
safely skipped by COMPATIBLE_MACHINE and won't result in an error.
> > > > +PROTOCOL = "git"
> > > > +BRANCH = "jailhouse"
> > > > +SRCREV = "f3ad79881bebb6c6068966ee3d265d8034c20492"
> > > > +SRC_URI = "git://
> > github.com/henning-schild-work/ivshmem-guest-code.git;protocol=${PROTOCOL};branch=${BRANCH}
> > <http://github.com/henning-schild-work/ivshmem-guest-code.git;protocol=$%7BPROTOCOL%7D;branch=$%7BBRANCH%7D>
> > "
> > > > +
> > > > +S = "${WORKDIR}/git"
> > > > +
> > > > +EXTRA_OEMAKE += 'KDIR="${STAGING_KERNEL_DIR}"'
> > > > +
> > > > +do_compile_prepend() {
> > > > + cd ${S}/kernel_module/uio
> > > > +}
> > > > +
> > > > +do_install() {
> > > > + install -d ${D}/${base_libdir}/modules/${KERNEL_VERSION}/extra
> > > > + install -m 644 ${S}/kernel_module/uio/uio_ivshmem.ko
> > ${D}/${base_libdir}/modules/${KERNEL_VERSION}/extra
> > > > +}
> > > > --
> > > > 1.9.1
> > > >
> > > > --
> > > > _______________________________________________
> > > > meta-ti mailing list
> > > > meta-ti@yoctoproject.org
> > > > https://lists.yoctoproject.org/listinfo/meta-ti
> > > --
> > > _______________________________________________
> > > meta-ti mailing list
> > > meta-ti@yoctoproject.org
> > > https://lists.yoctoproject.org/listinfo/meta-ti
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [thud/master PATCH v2] recipes-bsp: ivshmem-uio: Add new recipe for ivshmem-uio driver
2019-10-01 22:16 ` Denys Dmytriyenko
@ 2019-10-01 22:42 ` Khem Raj
0 siblings, 0 replies; 7+ messages in thread
From: Khem Raj @ 2019-10-01 22:42 UTC (permalink / raw)
To: Denys Dmytriyenko; +Cc: meta-ti
On 10/1/19 3:16 PM, Denys Dmytriyenko wrote:
> On Tue, Oct 01, 2019 at 02:57:41PM -0700, Khem Raj wrote:
>> On Tue, Oct 1, 2019 at 1:07 PM Denys Dmytriyenko <denys@ti.com> wrote:
>>
>>> On Mon, Sep 30, 2019 at 11:41:43PM -0700, Khem Raj wrote:
>>>> On Fri, Sep 27, 2019 at 2:17 AM Nikhil Devshatwar <nikhil.nd@ti.com>
>>> wrote:
>>>>>
>>>>> This is external kernel module which enables userspace io over the
>>>>> Jailhouse ivhsmem (inter VM shared memory)
>>>>> This driver is useful to test the inter VM communication.
>>>>>
>>>>> Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
>>>>> ---
>>>>> Changes from v1:
>>>>> * Split the ivshmem recipe separately
>>>>> * Add summary and remove PACKAGE_ARCH define
>>>>>
>>>>> recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb | 27
>>> +++++++++++++++++++++++
>>>>> 1 file changed, 27 insertions(+)
>>>>> create mode 100644 recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb
>>>>>
>>>>> diff --git a/recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb
>>> b/recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb
>>>>> new file mode 100644
>>>>> index 0000000..33fb946
>>>>> --- /dev/null
>>>>> +++ b/recipes-bsp/ivshmem-uio/ivshmem-uio-driver_git.bb
>>>>> @@ -0,0 +1,27 @@
>>>>> +DESCRIPTION = "Kernel driver for IVSHMEM based UIO driver"
>>>>> +SUMMARY = "Kernel module which registers a UIO (userspace io) device
>>> for inter VM shared memory"
>>>>> +HOMEPAGE = "https://github.com/henning-schild-work/ivshmem-guest-code
>>> "
>>>>> +LICENSE = "GPLv2"
>>>>> +LIC_FILES_CHKSUM =
>>> "file://COPYING;md5=0546a27aad86c83b75ad4ee6133e9d5e"
>>>>> +
>>>>> +inherit module
>>>>> +
>>>>> +RDEPENDS_${PN} = "jailhouse"
>>>>> +
>>>>
>>>> jailhouse is marked as ti-soc specific, so please mark this recipe
>>>> ti-soc specific as well. It will help meta-ti to live in a multi-BSP
>>>> distros
>>>>
>>>>
>>> http://jenkins.nas-admin.org/view/OE/job/oe_world_qemux86-64/1164/consoleFull
>>>>
>>>> if you could test meta-ti patches with one non-ti machine like qemux86
>>>> or some such it will help catch this kind of errors
>>>
>>> That would only fail when building "world", but thanks for the report.
>>
>> MACHINE=qemux86 bitbake <recipe> would do it
>> This would really help the distros
>
> Well, I do know how to break it specifically... :) BTW, building it directly
> like that with COMPATIBLE_MACHINE set would also fail with "Nothing PROVIDES"
> error.
>
> My point was that people add recipes and expect them to only be included in an
> image for their machine. In their view they cannot understand how it would get
> into an x86 build on its own, unless someone consciously adds it to their
> image. Hence my comment about building "world". And in that case it would be
> safely skipped by COMPATIBLE_MACHINE and won't result in an error.
>
I think this is fine from submitter point of view, Probably, on the
reviewer side, this should be considered as a test to accept a
contribution. I am happy to test your master-next or any other staging
branch that you use for testing meta-ti contribution, provided you will
hold commits and wait for build results from Yoe Distro world builds.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-10-01 22:42 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-27 9:16 [thud/master PATCH v2] recipes-bsp: ivshmem-uio: Add new recipe for ivshmem-uio driver Nikhil Devshatwar
2019-09-27 15:46 ` Denys Dmytriyenko
2019-10-01 6:41 ` Khem Raj
2019-10-01 20:07 ` Denys Dmytriyenko
2019-10-01 21:57 ` Khem Raj
2019-10-01 22:16 ` Denys Dmytriyenko
2019-10-01 22:42 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.