From: Wolfram Sang <wsa@the-dreams.de>
To: Fabien Parent <fparent@baylibre.com>
Cc: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
matthias.bgg@gmail.com, qii.wang@mediatek.com,
drinkcat@chromium.org, hsinyi@chromium.org, tglx@linutronix.de
Subject: Re: [PATCH] i2c: i2c-mt65xx: fix NULL ptr dereference
Date: Sat, 28 Sep 2019 20:33:11 +0200 [thread overview]
Message-ID: <20190928183305.GD12219@kunai> (raw)
In-Reply-To: <20190925203113.6972-1-fparent@baylibre.com>
[-- Attachment #1: Type: text/plain, Size: 315 bytes --]
> - if (adap->quirks->flags & I2C_AQ_NO_ZERO_LEN)
> + if (adap->quirks && adap->quirks->flags & I2C_AQ_NO_ZERO_LEN)
Right. Please use i2c_check_quirks(). Otherwise thanks for the catch!
@Mediatek-people: can we have a dedicated maintainer for this driver to
better prevent stuff like this from happening again?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Fabien Parent <fparent@baylibre.com>
Cc: linux-arm-kernel@lists.infradead.org, drinkcat@chromium.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-i2c@vger.kernel.org, hsinyi@chromium.org,
matthias.bgg@gmail.com, tglx@linutronix.de,
qii.wang@mediatek.com
Subject: Re: [PATCH] i2c: i2c-mt65xx: fix NULL ptr dereference
Date: Sat, 28 Sep 2019 20:33:11 +0200 [thread overview]
Message-ID: <20190928183305.GD12219@kunai> (raw)
In-Reply-To: <20190925203113.6972-1-fparent@baylibre.com>
[-- Attachment #1.1: Type: text/plain, Size: 315 bytes --]
> - if (adap->quirks->flags & I2C_AQ_NO_ZERO_LEN)
> + if (adap->quirks && adap->quirks->flags & I2C_AQ_NO_ZERO_LEN)
Right. Please use i2c_check_quirks(). Otherwise thanks for the catch!
@Mediatek-people: can we have a dedicated maintainer for this driver to
better prevent stuff like this from happening again?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-28 18:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 20:31 [PATCH] i2c: i2c-mt65xx: fix NULL ptr dereference Fabien Parent
2019-09-25 20:31 ` Fabien Parent
2019-09-28 18:33 ` Wolfram Sang [this message]
2019-09-28 18:33 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190928183305.GD12219@kunai \
--to=wsa@the-dreams.de \
--cc=drinkcat@chromium.org \
--cc=fparent@baylibre.com \
--cc=hsinyi@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=qii.wang@mediatek.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.