* [PATCH] ath11k: fix multicast rate parameter size
@ 2019-08-12 9:13 Sven Eckelmann
2019-09-29 14:57 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Sven Eckelmann @ 2019-08-12 9:13 UTC (permalink / raw)
To: ath11k; +Cc: Sven Eckelmann
From: Sven Eckelmann <seckelmann@datto.com>
The ATH11K_HW_RATE_CODE() macro uses at least 28 bit to encode the
parameters. An u8 cannot store all these bits.
Fixes: c885aaf227ec ("ath11k: support for multicast rate control")
Signed-off-by: Sven Eckelmann <seckelmann@datto.com>
---
drivers/net/wireless/ath/ath11k/mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index 6a3b1a110738..5a65caa019ed 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -1586,7 +1586,7 @@ static void ath11k_mac_op_bss_info_changed(struct ieee80211_hw *hw,
u16 bitrate;
int ret = 0;
u8 rateidx;
- u8 rate;
+ u32 rate;
mutex_lock(&ar->conf_mutex);
--
2.20.1
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ath11k: fix multicast rate parameter size
2019-08-12 9:13 [PATCH] ath11k: fix multicast rate parameter size Sven Eckelmann
@ 2019-09-29 14:57 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2019-09-29 14:57 UTC (permalink / raw)
To: Sven Eckelmann; +Cc: ath11k, Sven Eckelmann
Sven Eckelmann <sven@narfation.org> wrote:
> The ATH11K_HW_RATE_CODE() macro uses at least 28 bit to encode the
> parameters. An u8 cannot store all these bits.
>
> Fixes: c885aaf227ec ("ath11k: support for multicast rate control")
> Signed-off-by: Sven Eckelmann <seckelmann@datto.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath11k-bringup branch of ath.git, thanks.
bcd3f5043856 ath11k: fix multicast rate parameter size
--
https://patchwork.kernel.org/patch/11089507/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-29 14:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-12 9:13 [PATCH] ath11k: fix multicast rate parameter size Sven Eckelmann
2019-09-29 14:57 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.