All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: mark.rutland@arm.com, marex@denx.de, devicetree@vger.kernel.org,
	andrew.smirnov@gmail.com, shawnguo@kernel.org,
	s.hauer@pengutronix.de, angus@akkea.ca,
	linux-kernel@vger.kernel.org, j.neuschaefer@gmx.net,
	robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de,
	manivannan.sadhasivam@linaro.org,
	Discussions about the Letux Kernel <letux-kernel@openphoenux.org>,
	festevam@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] ARM: dts: add Netronix E60K02 board common file
Date: Mon, 30 Sep 2019 13:02:22 +0200	[thread overview]
Message-ID: <20190930130222.4e1cdf64@aktux> (raw)
In-Reply-To: <20190930082715.mplf5ra35ikqmbyr@pengutronix.de>

On Mon, 30 Sep 2019 10:27:15 +0200
Marco Felsch <m.felsch@pengutronix.de> wrote:

[..]
> > so you disagree with this pattern:
> > in .dtsi
> >  some_device {
> >    pinctrl-0 = <&pinctrl_some_device>;
> >  };
> > 
> > and in .dts (one I sent with this patch series and the tolino/mx6sl one
> > is not ready-cooked yet, will be part of a later series)
> > &iomuxc {
> >    pinctrl_some_device: some_devicegrp {
> >    	fsl,pins = <...>;
> >    };
> > };
> > 
> > ?  
> 
> Yes, because IMHO a dtsi is self contained as well as a dts. If it is
> common for all boards you can move the muxing into the dtsi else it
> should be done within the dts.
> 
well, since imx6sll-pinfunc.h is different than imx6sl-pinfunc.h,
we agree that this belongs to the dts.

> > > > +&snvs_rtc {
> > > > +	status = "disabled";    
> > > 
> > > Same applies here.
> > >   
> > 
> > No, seems to be an exception, it does not have a status = "disabled" in
> > imx6sll.dtsi.  
> 
> Did you mean 6sll or 6ull?
> 
> Okay, is this baseboard only used with a 6ull?
> 

MCIMX6V7DVN10AB and MCIMX6L8DVN10AB
So it is 6sll and 6sl (6sl support will be added in a follow-up patch
series). 

I will send a v2 this evening, so we can all look at better-sorted
things.

Regards,
Andreas

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Andreas Kemnade <andreas@kemnade.info>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org,
	s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, linux-imx@nxp.com,
	manivannan.sadhasivam@linaro.org, andrew.smirnov@gmail.com,
	marex@denx.de, angus@akkea.ca, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, j.neuschaefer@gmx.net,
	Discussions about the Letux Kernel <letux-kernel@openphoenux.org>
Subject: Re: [PATCH 1/3] ARM: dts: add Netronix E60K02 board common file
Date: Mon, 30 Sep 2019 13:02:22 +0200	[thread overview]
Message-ID: <20190930130222.4e1cdf64@aktux> (raw)
In-Reply-To: <20190930082715.mplf5ra35ikqmbyr@pengutronix.de>

On Mon, 30 Sep 2019 10:27:15 +0200
Marco Felsch <m.felsch@pengutronix.de> wrote:

[..]
> > so you disagree with this pattern:
> > in .dtsi
> >  some_device {
> >    pinctrl-0 = <&pinctrl_some_device>;
> >  };
> > 
> > and in .dts (one I sent with this patch series and the tolino/mx6sl one
> > is not ready-cooked yet, will be part of a later series)
> > &iomuxc {
> >    pinctrl_some_device: some_devicegrp {
> >    	fsl,pins = <...>;
> >    };
> > };
> > 
> > ?  
> 
> Yes, because IMHO a dtsi is self contained as well as a dts. If it is
> common for all boards you can move the muxing into the dtsi else it
> should be done within the dts.
> 
well, since imx6sll-pinfunc.h is different than imx6sl-pinfunc.h,
we agree that this belongs to the dts.

> > > > +&snvs_rtc {
> > > > +	status = "disabled";    
> > > 
> > > Same applies here.
> > >   
> > 
> > No, seems to be an exception, it does not have a status = "disabled" in
> > imx6sll.dtsi.  
> 
> Did you mean 6sll or 6ull?
> 
> Okay, is this baseboard only used with a 6ull?
> 

MCIMX6V7DVN10AB and MCIMX6L8DVN10AB
So it is 6sll and 6sl (6sl support will be added in a follow-up patch
series). 

I will send a v2 this evening, so we can all look at better-sorted
things.

Regards,
Andreas

  reply	other threads:[~2019-09-30 11:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-27  6:14 [PATCH 0/3] dts: ARM: add Kobo Clara HD eBook reader Andreas Kemnade
2019-09-27  6:14 ` Andreas Kemnade
2019-09-27  6:14 ` [PATCH 1/3] ARM: dts: add Netronix E60K02 board common file Andreas Kemnade
2019-09-27  6:14   ` Andreas Kemnade
2019-09-27  9:47   ` Marco Felsch
2019-09-27  9:47     ` Marco Felsch
2019-09-27 19:08     ` Andreas Kemnade
2019-09-27 19:08       ` Andreas Kemnade
2019-09-30  8:27       ` Marco Felsch
2019-09-30  8:27         ` Marco Felsch
2019-09-30 11:02         ` Andreas Kemnade [this message]
2019-09-30 11:02           ` Andreas Kemnade
2019-09-27  6:14 ` [PATCH 2/3] dt-bindings: arm: fsl: add compatible string for Kobo Clara HD Andreas Kemnade
2019-09-27  6:14   ` Andreas Kemnade
2019-09-27  9:19   ` Marco Felsch
2019-09-27  9:19     ` Marco Felsch
2019-09-27  6:14 ` [PATCH 3/3] ARM: dts: imx: add devicetree " Andreas Kemnade
2019-09-27  6:14   ` Andreas Kemnade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190930130222.4e1cdf64@aktux \
    --to=andreas@kemnade.info \
    --cc=andrew.smirnov@gmail.com \
    --cc=angus@akkea.ca \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=j.neuschaefer@gmx.net \
    --cc=kernel@pengutronix.de \
    --cc=letux-kernel@openphoenux.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=marex@denx.de \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.