From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Joerg Roedel <joro@8bytes.org>,
iommu@lists.linux-foundation.org,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH v2 3/6] ACPI / utils: Introduce acpi_dev_hid_uid_match() helper
Date: Tue, 1 Oct 2019 12:59:05 +0300 [thread overview]
Message-ID: <20191001095905.GG32742@smile.fi.intel.com> (raw)
In-Reply-To: <20191001093854.GH2714@lahna.fi.intel.com>
On Tue, Oct 01, 2019 at 12:38:54PM +0300, Mika Westerberg wrote:
> On Tue, Sep 24, 2019 at 10:37:36PM +0300, Andy Shevchenko wrote:
> > There are users outside of ACPI realm which reimplementing the comparator
> > function to check if the given device matches to given HID and UID.
> >
> > For better utilization, introduce a helper for everyone to use.
> > +EXPORT_SYMBOL(acpi_dev_hid_uid_match);
>
> Should this be _GPL?
No, the rest of the acpi_dev_*() are marked without it.
> In any case looks good,
>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Thanks!
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org
Subject: Re: [PATCH v2 3/6] ACPI / utils: Introduce acpi_dev_hid_uid_match() helper
Date: Tue, 1 Oct 2019 12:59:05 +0300 [thread overview]
Message-ID: <20191001095905.GG32742@smile.fi.intel.com> (raw)
In-Reply-To: <20191001093854.GH2714@lahna.fi.intel.com>
On Tue, Oct 01, 2019 at 12:38:54PM +0300, Mika Westerberg wrote:
> On Tue, Sep 24, 2019 at 10:37:36PM +0300, Andy Shevchenko wrote:
> > There are users outside of ACPI realm which reimplementing the comparator
> > function to check if the given device matches to given HID and UID.
> >
> > For better utilization, introduce a helper for everyone to use.
> > +EXPORT_SYMBOL(acpi_dev_hid_uid_match);
>
> Should this be _GPL?
No, the rest of the acpi_dev_*() are marked without it.
> In any case looks good,
>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Thanks!
--
With Best Regards,
Andy Shevchenko
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Mika Westerberg
<mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Rafael J. Wysocki" <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>,
Adrian Hunter
<adrian.hunter-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH v2 3/6] ACPI / utils: Introduce acpi_dev_hid_uid_match() helper
Date: Tue, 1 Oct 2019 12:59:05 +0300 [thread overview]
Message-ID: <20191001095905.GG32742@smile.fi.intel.com> (raw)
In-Reply-To: <20191001093854.GH2714-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
On Tue, Oct 01, 2019 at 12:38:54PM +0300, Mika Westerberg wrote:
> On Tue, Sep 24, 2019 at 10:37:36PM +0300, Andy Shevchenko wrote:
> > There are users outside of ACPI realm which reimplementing the comparator
> > function to check if the given device matches to given HID and UID.
> >
> > For better utilization, introduce a helper for everyone to use.
> > +EXPORT_SYMBOL(acpi_dev_hid_uid_match);
>
> Should this be _GPL?
No, the rest of the acpi_dev_*() are marked without it.
> In any case looks good,
>
> Reviewed-by: Mika Westerberg <mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-10-01 9:59 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 19:37 [PATCH v2 0/6] ACPI / utils: add new helper for HID/UID match Andy Shevchenko
2019-09-24 19:37 ` Andy Shevchenko
2019-09-24 19:37 ` Andy Shevchenko
2019-09-24 19:37 ` [PATCH v2 1/6] ACPI / utils: Describe function parameters in kernel-doc Andy Shevchenko
2019-09-24 19:37 ` Andy Shevchenko
2019-09-24 19:37 ` Andy Shevchenko
2019-10-01 9:32 ` Mika Westerberg
2019-10-01 9:32 ` Mika Westerberg
2019-10-01 9:32 ` Mika Westerberg
2019-09-24 19:37 ` [PATCH v2 2/6] ACPI / utils: Move acpi_dev_get_first_match_dev() under CONFIG_ACPI Andy Shevchenko
2019-09-24 19:37 ` Andy Shevchenko
2019-09-24 19:37 ` Andy Shevchenko
2019-10-01 9:32 ` Mika Westerberg
2019-10-01 9:32 ` Mika Westerberg
2019-10-01 9:32 ` Mika Westerberg
2019-09-24 19:37 ` [PATCH v2 3/6] ACPI / utils: Introduce acpi_dev_hid_uid_match() helper Andy Shevchenko
2019-09-24 19:37 ` Andy Shevchenko
2019-09-24 19:37 ` Andy Shevchenko
2019-10-01 9:38 ` Mika Westerberg
2019-10-01 9:38 ` Mika Westerberg
2019-10-01 9:38 ` Mika Westerberg
2019-10-01 9:59 ` Andy Shevchenko [this message]
2019-10-01 9:59 ` Andy Shevchenko
2019-10-01 9:59 ` Andy Shevchenko
2019-09-24 19:37 ` [PATCH v2 4/6] ACPI / LPSS: Switch to use acpi_dev_hid_uid_match() Andy Shevchenko
2019-09-24 19:37 ` Andy Shevchenko
2019-09-24 19:37 ` Andy Shevchenko
2019-10-01 9:40 ` Mika Westerberg
2019-10-01 9:40 ` Mika Westerberg
2019-10-01 9:40 ` Mika Westerberg
2019-09-24 19:37 ` [PATCH v2 5/6] mmc: sdhci-acpi: " Andy Shevchenko
2019-09-24 19:37 ` Andy Shevchenko
2019-09-24 19:37 ` Andy Shevchenko
2019-10-01 9:40 ` Mika Westerberg
2019-10-01 9:40 ` Mika Westerberg
2019-10-01 9:40 ` Mika Westerberg
2019-10-01 12:37 ` Adrian Hunter
2019-10-01 12:37 ` Adrian Hunter
2019-10-01 12:37 ` Adrian Hunter
2019-10-01 13:04 ` Andy Shevchenko
2019-10-01 13:04 ` Andy Shevchenko
2019-10-01 13:04 ` Andy Shevchenko
2019-09-24 19:37 ` [PATCH v2 6/6] iommu/amd: " Andy Shevchenko
2019-09-24 19:37 ` Andy Shevchenko
2019-09-24 19:37 ` Andy Shevchenko
2019-10-01 9:41 ` Mika Westerberg
2019-10-01 9:41 ` Mika Westerberg
2019-10-01 9:41 ` Mika Westerberg
2019-10-07 15:28 ` Joerg Roedel
2019-10-07 15:28 ` Joerg Roedel
2019-10-07 15:28 ` Joerg Roedel
2019-10-08 13:54 ` Andy Shevchenko
2019-10-08 13:54 ` Andy Shevchenko
2019-10-08 13:54 ` Andy Shevchenko
2019-10-07 18:24 ` Jerry Snitselaar
2019-10-07 18:24 ` Jerry Snitselaar
2019-10-07 18:24 ` Jerry Snitselaar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001095905.GG32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=adrian.hunter@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.