From: Ayan Halder <Ayan.Halder@arm.com>
To: "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
Cc: nd <nd@arm.com>, Mihail Atanassov <Mihail.Atanassov@arm.com>,
David Airlie <airlied@linux.ie>,
Liviu Dudau <Liviu.Dudau@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Lowry Li (Arm Technology China)" <Lowry.Li@arm.com>
Subject: Re: [PATCH] drm/komeda: Use IRQ_RETVAL shorthand in d71_irq_handler
Date: Tue, 1 Oct 2019 11:06:25 +0000 [thread overview]
Message-ID: <20191001110624.GA5422@arm.com> (raw)
In-Reply-To: <20190923024136.GB24909@jamwan02-TSP300>
On Mon, Sep 23, 2019 at 02:41:44AM +0000, james qian wang (Arm Technology China) wrote:
> On Fri, Sep 20, 2019 at 03:13:08PM +0000, Mihail Atanassov wrote:
> > No change in behaviour; IRQ_RETVAL is about twice as popular as
> > manually writing out the ternary.
> >
> > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> > ---
> > drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
> > index d567ab7ed314..1b42095969e7 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
> > @@ -195,7 +195,7 @@ d71_irq_handler(struct komeda_dev *mdev, struct komeda_events *evts)
> > if (gcu_status & GLB_IRQ_STATUS_PIPE1)
> > evts->pipes[1] |= get_pipeline_event(d71->pipes[1], gcu_status);
> >
> > - return gcu_status ? IRQ_HANDLED : IRQ_NONE;
> > + return IRQ_RETVAL(gcu_status);
>
> Hi Mihail:
>
> Thank you for the patch.
>
> Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
Pushed to drm-misc-next - 4b39582a8fb3c749f0fa96ec920d138f61bf00d6
>
> > }
> >
> > #define ENABLED_GCU_IRQS (GCU_IRQ_CVAL0 | GCU_IRQ_CVAL1 | \
> > --
> > 2.23.0
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Ayan Halder <Ayan.Halder@arm.com>
To: "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
Cc: Mihail Atanassov <Mihail.Atanassov@arm.com>,
"Lowry Li (Arm Technology China)" <Lowry.Li@arm.com>,
David Airlie <airlied@linux.ie>,
Liviu Dudau <Liviu.Dudau@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>, nd <nd@arm.com>
Subject: Re: [PATCH] drm/komeda: Use IRQ_RETVAL shorthand in d71_irq_handler
Date: Tue, 1 Oct 2019 11:06:25 +0000 [thread overview]
Message-ID: <20191001110624.GA5422@arm.com> (raw)
In-Reply-To: <20190923024136.GB24909@jamwan02-TSP300>
On Mon, Sep 23, 2019 at 02:41:44AM +0000, james qian wang (Arm Technology China) wrote:
> On Fri, Sep 20, 2019 at 03:13:08PM +0000, Mihail Atanassov wrote:
> > No change in behaviour; IRQ_RETVAL is about twice as popular as
> > manually writing out the ternary.
> >
> > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> > ---
> > drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
> > index d567ab7ed314..1b42095969e7 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
> > @@ -195,7 +195,7 @@ d71_irq_handler(struct komeda_dev *mdev, struct komeda_events *evts)
> > if (gcu_status & GLB_IRQ_STATUS_PIPE1)
> > evts->pipes[1] |= get_pipeline_event(d71->pipes[1], gcu_status);
> >
> > - return gcu_status ? IRQ_HANDLED : IRQ_NONE;
> > + return IRQ_RETVAL(gcu_status);
>
> Hi Mihail:
>
> Thank you for the patch.
>
> Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
Pushed to drm-misc-next - 4b39582a8fb3c749f0fa96ec920d138f61bf00d6
>
> > }
> >
> > #define ENABLED_GCU_IRQS (GCU_IRQ_CVAL0 | GCU_IRQ_CVAL1 | \
> > --
> > 2.23.0
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-10-01 11:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 15:13 [PATCH] drm/komeda: Use IRQ_RETVAL shorthand in d71_irq_handler Mihail Atanassov
2019-09-23 2:41 ` james qian wang (Arm Technology China)
2019-09-23 2:41 ` james qian wang (Arm Technology China)
2019-10-01 11:06 ` Ayan Halder [this message]
2019-10-01 11:06 ` Ayan Halder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001110624.GA5422@arm.com \
--to=ayan.halder@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=Lowry.Li@arm.com \
--cc=Mihail.Atanassov@arm.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=james.qian.wang@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.