From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>, Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
Jacopo Mondi <jacopo@jmondi.org>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v4 1/7] backlight: gpio: remove unneeded include
Date: Tue, 01 Oct 2019 13:06:27 +0000 [thread overview]
Message-ID: <20191001130627.GO32742@smile.fi.intel.com> (raw)
In-Reply-To: <20191001125837.4472-2-brgl@bgdev.pl>
On Tue, Oct 01, 2019 at 02:58:31PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> We no longer use any symbols from of_gpio.h. Remove this include.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> drivers/video/backlight/gpio_backlight.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
> index 18e053e4716c..7e1990199fae 100644
> --- a/drivers/video/backlight/gpio_backlight.c
> +++ b/drivers/video/backlight/gpio_backlight.c
> @@ -12,7 +12,6 @@
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_gpio.h>
> #include <linux/platform_data/gpio_backlight.h>
> #include <linux/platform_device.h>
> #include <linux/property.h>
> --
> 2.23.0
>
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>, Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
Jacopo Mondi <jacopo@jmondi.org>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v4 1/7] backlight: gpio: remove unneeded include
Date: Tue, 1 Oct 2019 16:06:27 +0300 [thread overview]
Message-ID: <20191001130627.GO32742@smile.fi.intel.com> (raw)
In-Reply-To: <20191001125837.4472-2-brgl@bgdev.pl>
On Tue, Oct 01, 2019 at 02:58:31PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> We no longer use any symbols from of_gpio.h. Remove this include.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> drivers/video/backlight/gpio_backlight.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
> index 18e053e4716c..7e1990199fae 100644
> --- a/drivers/video/backlight/gpio_backlight.c
> +++ b/drivers/video/backlight/gpio_backlight.c
> @@ -12,7 +12,6 @@
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_gpio.h>
> #include <linux/platform_data/gpio_backlight.h>
> #include <linux/platform_device.h>
> #include <linux/property.h>
> --
> 2.23.0
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-10-01 13:06 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 12:58 [PATCH v4 0/7] backlight: gpio: simplify the driver Bartosz Golaszewski
2019-10-01 12:58 ` Bartosz Golaszewski
2019-10-01 12:58 ` [PATCH v4 1/7] backlight: gpio: remove unneeded include Bartosz Golaszewski
2019-10-01 12:58 ` Bartosz Golaszewski
2019-10-01 13:06 ` Andy Shevchenko [this message]
2019-10-01 13:06 ` Andy Shevchenko
2019-10-01 14:29 ` Daniel Thompson
2019-10-01 14:29 ` Daniel Thompson
2019-10-01 14:29 ` Daniel Thompson
2019-10-04 21:47 ` Linus Walleij
2019-10-04 21:47 ` Linus Walleij
2019-10-01 12:58 ` [PATCH v4 2/7] sh: ecovec24: add additional properties to the backlight device Bartosz Golaszewski
2019-10-01 12:58 ` Bartosz Golaszewski
2019-10-01 12:58 ` [PATCH v4 3/7] backlight: gpio: simplify the platform data handling Bartosz Golaszewski
2019-10-01 12:58 ` Bartosz Golaszewski
2019-10-01 12:58 ` [PATCH v4 4/7] sh: ecovec24: don't set unused fields in platform data Bartosz Golaszewski
2019-10-01 12:58 ` Bartosz Golaszewski
2019-10-01 12:58 ` [PATCH v4 5/7] backlight: gpio: remove unused fields from " Bartosz Golaszewski
2019-10-01 12:58 ` Bartosz Golaszewski
2019-10-01 12:58 ` [PATCH v4 6/7] backlight: gpio: use a helper variable for &pdev->dev Bartosz Golaszewski
2019-10-01 12:58 ` Bartosz Golaszewski
2019-10-01 12:58 ` [PATCH v4 7/7] backlight: gpio: pull gpio_backlight_initial_power_state() into probe Bartosz Golaszewski
2019-10-01 12:58 ` Bartosz Golaszewski
2019-10-02 10:33 ` Daniel Thompson
2019-10-02 10:33 ` Daniel Thompson
2019-10-02 10:33 ` Daniel Thompson
2019-10-02 11:46 ` Bartosz Golaszewski
2019-10-02 11:46 ` Bartosz Golaszewski
2019-10-02 14:40 ` Daniel Thompson
2019-10-02 14:40 ` Daniel Thompson
2019-10-02 14:40 ` Daniel Thompson
2019-10-03 8:42 ` Bartosz Golaszewski
2019-10-03 8:42 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001130627.GO32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=b.zolnierkie@samsung.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=dalias@libc.org \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacopo@jmondi.org \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.