From: Dan Carpenter <dan.carpenter@oracle.com>
To: Navid Emamdoost <navid.emamdoost@gmail.com>
Cc: "Jan Sebastian Götte" <linux@jaseg.net>,
devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
"Nishad Kamdar" <nishadkamdar@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
smccaman@umn.edu, kjlu@umn.edu, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, emamd001@umn.edu,
"Bhanusree Pola" <bhanusreemahesh@gmail.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Phil Reid" <preid@electromag.com.au>,
"Sam Ravnborg" <sam@ravnborg.org>
Subject: Re: [PATCH] Staging: fbtft: fix memory leak in fbtft_framebuffer_alloc
Date: Tue, 01 Oct 2019 13:34:43 +0000 [thread overview]
Message-ID: <20191001133408.GG22609@kadam> (raw)
In-Reply-To: <20190930030949.28615-1-navid.emamdoost@gmail.com>
On Sun, Sep 29, 2019 at 10:09:45PM -0500, Navid Emamdoost wrote:
> In fbtft_framebuffer_alloc the error handling path should take care of
> releasing frame buffer after it is allocated via framebuffer_alloc, too.
> Therefore, in two failure cases the goto destination is changed to
> address this issue.
>
> Fixes: c296d5f9957c ("staging: fbtft: core support")
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Looks good.
Reviewed-by: Dan Carpenter <dan.carpenter@gmail.com>
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Navid Emamdoost <navid.emamdoost@gmail.com>
Cc: "Jan Sebastian Götte" <linux@jaseg.net>,
devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
"Nishad Kamdar" <nishadkamdar@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
smccaman@umn.edu, kjlu@umn.edu, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, emamd001@umn.edu,
"Bhanusree Pola" <bhanusreemahesh@gmail.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Phil Reid" <preid@electromag.com.au>,
"Sam Ravnborg" <sam@ravnborg.org>
Subject: Re: [PATCH] Staging: fbtft: fix memory leak in fbtft_framebuffer_alloc
Date: Tue, 1 Oct 2019 16:34:43 +0300 [thread overview]
Message-ID: <20191001133408.GG22609@kadam> (raw)
In-Reply-To: <20190930030949.28615-1-navid.emamdoost@gmail.com>
On Sun, Sep 29, 2019 at 10:09:45PM -0500, Navid Emamdoost wrote:
> In fbtft_framebuffer_alloc the error handling path should take care of
> releasing frame buffer after it is allocated via framebuffer_alloc, too.
> Therefore, in two failure cases the goto destination is changed to
> address this issue.
>
> Fixes: c296d5f9957c ("staging: fbtft: core support")
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Looks good.
Reviewed-by: Dan Carpenter <dan.carpenter@gmail.com>
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Navid Emamdoost <navid.emamdoost@gmail.com>
Cc: "Jan Sebastian Götte" <linux@jaseg.net>,
devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
"Nishad Kamdar" <nishadkamdar@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
kjlu@umn.edu, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
emamd001@umn.edu, "Bhanusree Pola" <bhanusreemahesh@gmail.com>,
smccaman@umn.edu, "Phil Reid" <preid@electromag.com.au>,
"Sam Ravnborg" <sam@ravnborg.org>
Subject: Re: [PATCH] Staging: fbtft: fix memory leak in fbtft_framebuffer_alloc
Date: Tue, 1 Oct 2019 16:34:43 +0300 [thread overview]
Message-ID: <20191001133408.GG22609@kadam> (raw)
In-Reply-To: <20190930030949.28615-1-navid.emamdoost@gmail.com>
On Sun, Sep 29, 2019 at 10:09:45PM -0500, Navid Emamdoost wrote:
> In fbtft_framebuffer_alloc the error handling path should take care of
> releasing frame buffer after it is allocated via framebuffer_alloc, too.
> Therefore, in two failure cases the goto destination is changed to
> address this issue.
>
> Fixes: c296d5f9957c ("staging: fbtft: core support")
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Looks good.
Reviewed-by: Dan Carpenter <dan.carpenter@gmail.com>
regards,
dan carpenter
next prev parent reply other threads:[~2019-10-01 13:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 3:09 [PATCH] Staging: fbtft: fix memory leak in fbtft_framebuffer_alloc Navid Emamdoost
2019-09-30 3:09 ` Navid Emamdoost
2019-09-30 3:09 ` Navid Emamdoost
2019-10-01 13:34 ` Dan Carpenter [this message]
2019-10-01 13:34 ` Dan Carpenter
2019-10-01 13:34 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001133408.GG22609@kadam \
--to=dan.carpenter@oracle.com \
--cc=bhanusreemahesh@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emamd001@umn.edu \
--cc=gregkh@linuxfoundation.org \
--cc=kjlu@umn.edu \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@jaseg.net \
--cc=navid.emamdoost@gmail.com \
--cc=nishadkamdar@gmail.com \
--cc=preid@electromag.com.au \
--cc=sam@ravnborg.org \
--cc=smccaman@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.