All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nishka Dasgupta <nishkadg.linux@gmail.com>
Cc: linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org,
	linux-gpio@vger.kernel.org, tomasz.figa@gmail.com,
	s.nawrocki@samsung.com, kgene@kernel.org,
	linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] pinctrl: samsung: exynos: Add of_node_put() before return
Date: Tue, 1 Oct 2019 21:32:37 +0200	[thread overview]
Message-ID: <20191001193237.GB1815@kozik-lap> (raw)
In-Reply-To: <20190805162154.GA24769@kozik-lap>

On Mon, Aug 05, 2019 at 06:21:54PM +0200, Krzysztof Kozlowski wrote:
> On Sun, Aug 04, 2019 at 09:32:00PM +0530, Nishka Dasgupta wrote:
> > Each iteration of for_each_child_of_node puts the previous node, but in
> > the case of a return from the middle of the loop, there is no put, thus
> > causing a memory leak. Hence add an of_node_put before the return.
> > Issue found with Coccinelle.
> > 
> > Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> > ---
> >  drivers/pinctrl/samsung/pinctrl-exynos.c | 4 +++-
> 
> Thanks, applied.
>

Hi Nishka,

I am sorry but I missed the v5.4 merge window and did not push this to
Linus. It's my fault. I'll push it this time, for v5.5 (no need for
action from your side).

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nishka Dasgupta <nishkadg.linux@gmail.com>
Cc: linux-samsung-soc@vger.kernel.org, linus.walleij@linaro.org,
	tomasz.figa@gmail.com, linux-gpio@vger.kernel.org,
	kgene@kernel.org, s.nawrocki@samsung.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl: samsung: exynos: Add of_node_put() before return
Date: Tue, 1 Oct 2019 21:32:37 +0200	[thread overview]
Message-ID: <20191001193237.GB1815@kozik-lap> (raw)
In-Reply-To: <20190805162154.GA24769@kozik-lap>

On Mon, Aug 05, 2019 at 06:21:54PM +0200, Krzysztof Kozlowski wrote:
> On Sun, Aug 04, 2019 at 09:32:00PM +0530, Nishka Dasgupta wrote:
> > Each iteration of for_each_child_of_node puts the previous node, but in
> > the case of a return from the middle of the loop, there is no put, thus
> > causing a memory leak. Hence add an of_node_put before the return.
> > Issue found with Coccinelle.
> > 
> > Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> > ---
> >  drivers/pinctrl/samsung/pinctrl-exynos.c | 4 +++-
> 
> Thanks, applied.
>

Hi Nishka,

I am sorry but I missed the v5.4 merge window and did not push this to
Linus. It's my fault. I'll push it this time, for v5.5 (no need for
action from your side).

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nishka Dasgupta <nishkadg.linux@gmail.com>
Cc: linux-samsung-soc@vger.kernel.org, linus.walleij@linaro.org,
	tomasz.figa@gmail.com, linux-gpio@vger.kernel.org,
	kgene@kernel.org, s.nawrocki@samsung.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl: samsung: exynos: Add of_node_put() before return
Date: Tue, 1 Oct 2019 21:32:37 +0200	[thread overview]
Message-ID: <20191001193237.GB1815@kozik-lap> (raw)
In-Reply-To: <20190805162154.GA24769@kozik-lap>

On Mon, Aug 05, 2019 at 06:21:54PM +0200, Krzysztof Kozlowski wrote:
> On Sun, Aug 04, 2019 at 09:32:00PM +0530, Nishka Dasgupta wrote:
> > Each iteration of for_each_child_of_node puts the previous node, but in
> > the case of a return from the middle of the loop, there is no put, thus
> > causing a memory leak. Hence add an of_node_put before the return.
> > Issue found with Coccinelle.
> > 
> > Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> > ---
> >  drivers/pinctrl/samsung/pinctrl-exynos.c | 4 +++-
> 
> Thanks, applied.
>

Hi Nishka,

I am sorry but I missed the v5.4 merge window and did not push this to
Linus. It's my fault. I'll push it this time, for v5.5 (no need for
action from your side).

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-10-01 19:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-04 16:02 [PATCH] pinctrl: samsung: exynos: Add of_node_put() before return Nishka Dasgupta
2019-08-04 16:02 ` Nishka Dasgupta
2019-08-05 16:21 ` Krzysztof Kozlowski
2019-08-05 16:21   ` Krzysztof Kozlowski
2019-08-05 16:21   ` Krzysztof Kozlowski
2019-10-01 19:32   ` Krzysztof Kozlowski [this message]
2019-10-01 19:32     ` Krzysztof Kozlowski
2019-10-01 19:32     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191001193237.GB1815@kozik-lap \
    --to=krzk@kernel.org \
    --cc=kgene@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=nishkadg.linux@gmail.com \
    --cc=s.nawrocki@samsung.com \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.