From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Solomon Peachy <pizza@shaftnet.org>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] cw1200: Fix a signedness bug in cw1200_load_firmware()
Date: Wed, 02 Oct 2019 04:35:08 +0000 [thread overview]
Message-ID: <20191002043508.7A7B0602F2@smtp.codeaurora.org> (raw)
In-Reply-To: <20191001114501.GA6550@mwanda>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The "priv->hw_type" is an enum and in this context GCC will treat it
> as an unsigned int so the error handling will never trigger.
>
> Fixes: a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Patch applied to wireless-drivers-next.git, thanks.
4a50d454502f cw1200: Fix a signedness bug in cw1200_load_firmware()
--
https://patchwork.kernel.org/patch/11168561/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Solomon Peachy <pizza@shaftnet.org>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] cw1200: Fix a signedness bug in cw1200_load_firmware()
Date: Wed, 2 Oct 2019 04:35:08 +0000 (UTC) [thread overview]
Message-ID: <20191002043508.7A7B0602F2@smtp.codeaurora.org> (raw)
In-Reply-To: <20191001114501.GA6550@mwanda>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The "priv->hw_type" is an enum and in this context GCC will treat it
> as an unsigned int so the error handling will never trigger.
>
> Fixes: a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Patch applied to wireless-drivers-next.git, thanks.
4a50d454502f cw1200: Fix a signedness bug in cw1200_load_firmware()
--
https://patchwork.kernel.org/patch/11168561/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-10-02 4:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 10:59 [PATCH] cw1200: Fix a signedness bug in cw1200_load_firmware() Dan Carpenter
2019-09-25 10:59 ` Dan Carpenter
2019-09-25 11:06 ` Kalle Valo
2019-09-25 11:06 ` Kalle Valo
2019-10-01 11:45 ` [PATCH v2] " Dan Carpenter
2019-10-01 11:45 ` Dan Carpenter
2019-10-01 12:02 ` Kalle Valo
2019-10-01 12:02 ` Kalle Valo
2019-10-02 4:35 ` Kalle Valo [this message]
2019-10-02 4:35 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191002043508.7A7B0602F2@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pizza@shaftnet.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.