From: Lee Jones <lee.jones@linaro.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: daniel.thompson@linaro.org, jingoohan1@gmail.com,
jacek.anaszewski@gmail.com, pavel@ucw.cz, dmurphy@ti.com,
robh+dt@kernel.org, mark.rutland@arm.com,
b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v4 2/2] backlight: lm3630a: Add an enable gpio for the HWEN pin
Date: Thu, 03 Oct 2019 11:42:42 +0000 [thread overview]
Message-ID: <20191003114242.GE21172@dell> (raw)
In-Reply-To: <20190912213257.24147-3-andreas@kemnade.info>
On Thu, 12 Sep 2019, Andreas Kemnade wrote:
> For now just enable it in the probe function to allow I2C
> access. Disabling also means resetting the register values
> to default and according to the datasheet does not give
> power savings.
>
> Tested on Kobo Clara HD.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> Reviewed-by: Dan Murphy <dmurphy@ti.com>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> changes in v2:
> - simplification
> - correct gpio direction initialisation
>
> changes in v3:
> - removed legacy include
>
> drivers/video/backlight/lm3630a_bl.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: daniel.thompson@linaro.org, jingoohan1@gmail.com,
jacek.anaszewski@gmail.com, pavel@ucw.cz, dmurphy@ti.com,
robh+dt@kernel.org, mark.rutland@arm.com,
b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v4 2/2] backlight: lm3630a: Add an enable gpio for the HWEN pin
Date: Thu, 3 Oct 2019 12:42:42 +0100 [thread overview]
Message-ID: <20191003114242.GE21172@dell> (raw)
In-Reply-To: <20190912213257.24147-3-andreas@kemnade.info>
On Thu, 12 Sep 2019, Andreas Kemnade wrote:
> For now just enable it in the probe function to allow I2C
> access. Disabling also means resetting the register values
> to default and according to the datasheet does not give
> power savings.
>
> Tested on Kobo Clara HD.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> Reviewed-by: Dan Murphy <dmurphy@ti.com>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> changes in v2:
> - simplification
> - correct gpio direction initialisation
>
> changes in v3:
> - removed legacy include
>
> drivers/video/backlight/lm3630a_bl.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-10-03 11:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 21:32 [PATCH v4 0/2] backlight_lm3630a: add enable_gpios property Andreas Kemnade
2019-09-12 21:32 ` Andreas Kemnade
2019-09-12 21:32 ` [PATCH v4 1/2] dt-bindings: backlight: lm3630a: add enable_gpios Andreas Kemnade
2019-09-12 21:32 ` Andreas Kemnade
2019-09-13 14:06 ` Dan Murphy
2019-09-13 14:06 ` Dan Murphy
2019-09-13 14:06 ` Dan Murphy
2019-09-17 18:14 ` Rob Herring
2019-09-17 18:14 ` Rob Herring
2019-09-17 18:14 ` Rob Herring
2019-10-03 11:42 ` [PATCH v4 1/2] dt-bindings: backlight: lm3630a: Add enable-gpios to describe HWEN pin Lee Jones
2019-10-03 11:42 ` Lee Jones
2019-10-03 11:42 ` Lee Jones
2019-10-28 23:25 ` [PATCH v4 1/2] dt-bindings: backlight: lm3630a: add enable_gpios Rob Herring
2019-10-28 23:25 ` Rob Herring
2019-10-28 23:25 ` Rob Herring
2019-10-29 12:16 ` Andreas Kemnade
2019-10-29 12:16 ` Andreas Kemnade
2019-10-29 12:16 ` Andreas Kemnade
2019-09-12 21:32 ` [PATCH v4 2/2] backlight: lm3630a: add an enable gpio for the HWEN pin Andreas Kemnade
2019-09-12 21:32 ` Andreas Kemnade
2019-10-03 11:42 ` Lee Jones [this message]
2019-10-03 11:42 ` [PATCH v4 2/2] backlight: lm3630a: Add " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191003114242.GE21172@dell \
--to=lee.jones@linaro.org \
--cc=andreas@kemnade.info \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.