[MPTCP] Re: RFCv2 for netdev: what's missing?

[Florian Westphal <fw at strlen.de>]

[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]

Paolo Abeni <pabeni(a)redhat.com> wrote:
> I think that:
> 
>        tcp: clean ext on tx recycle
> 
> does have some minimal mptcp dependencies that can't be removed without
> making such patch a no-op, so perhaps we should also include some very
> minimal MPTCP stub definitions:

Why?  It doesn't have any MPTCP dep.  Just zap all the extension space
and netfilter conntrack entry.

AFAICS things might already go wrong in case we get recycle skb that
has an ipsec secpath assigned, or am I missing something?

And unless there is something in place that removes skb->nfct before
the skb is placed on the socket cache, rmmod nf_conntrack can block
forever as such queued skb holds a reference on conntrack struct.

> I *think* we can also do a bolder step and send this next iteration as
> _NOT_ RFC, aiming at inclusion. My [mis]understanding is that we
> should post later chunks after the first one is merged, easily.

Hmm, we can try but I am not sure upstream would accept exposure of
some tcp core functions without a in-tree user.