All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw at strlen.de>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: RFCv2 for netdev: what's missing?
Date: Thu, 03 Oct 2019 09:46:27 +0200	[thread overview]
Message-ID: <20191003074627.GD13866@breakpoint.cc> (raw)
In-Reply-To: alpine.OSX.2.21.1910021737190.33041@syitbare-mobl.amr.corp.intel.com

[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]

Mat Martineau <mathew.j.martineau(a)linux.intel.com> wrote:
> > Regenerating those and resending. Sorry!
> > 
> 
> Based on Dave's feedback, it looked like a bad idea to repost the correct 43
> patches today.

Yes, I agree it was good to not send it.

> Sorry again about the error on my part, we can discuss how to
> partition the patch series (and possibly squash some more patches) at the
> meeting tomorrow.

Unfortunately I won't make the meeting today.

I would suggest to make another RFC submission on Friday or Monday,
consisting only of the non-mptcp patches, i.e.:

      net: Make sock protocol value checks more specific
      sock: Make sk_protocol a 16-bit value
      tcp: Define IPPROTO_MPTCP
      tcp, ulp: Add clone operation to tcp_ulp_ops
      tcp: Prevent coalesce/collapse when skb has MPTCP extensions
      tcp: Export low-level TCP functions
      tcp: Check for filled TCP option space before SACK
      tcp: clean ext on tx recycle
      tcp: Expose tcp struct and routine for MPTCP


Wrt to 
      tcp: clean ext on tx recycle

I think this is in fact a bug fix, I think this should
call both skb_ext_reset+nf_reset_ct.

(I am not 100% sure the nf_ct pointer is always cleared already
 on skbs that we put back on per sk cache).

Same for secpath.

Cheers,
Florian

             reply	other threads:[~2019-10-03  7:46 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-03  7:46 Florian Westphal [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-10-04 11:25 [MPTCP] Re: RFCv2 for netdev: what's missing? Matthieu Baerts
2019-10-03 19:21 Florian Westphal
2019-10-03  8:12 Paolo Abeni
2019-10-03  0:39 Mat Martineau
2019-10-02 23:55 Mat Martineau
2019-10-02 23:41 Mat Martineau
2019-10-02 21:11 Matthieu Baerts
2019-10-01 23:07 Mat Martineau
2019-10-01 20:26 Paolo Abeni
2019-10-01 19:40 Matthieu Baerts
2019-10-01 19:28 Matthieu Baerts
2019-10-01 17:21 Mat Martineau
2019-10-01 16:23 Mat Martineau
2019-10-01 16:14 Peter Krystad
2019-10-01 16:07 Paolo Abeni
2019-10-01 15:34 Florian Westphal
2019-10-01 15:14 Matthieu Baerts
2019-10-01 15:07 Matthieu Baerts
2019-10-01 15:00 Florian Westphal
2019-10-01 14:58 Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191003074627.GD13866@breakpoint.cc \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.