* Re: [PATCH v1] usb: dwc3: enable otg mode for dwc3 usb ip on layerscape
@ 2019-10-06 2:54 ` Shawn Guo
0 siblings, 0 replies; 8+ messages in thread
From: Shawn Guo @ 2019-10-06 2:54 UTC (permalink / raw)
To: Yinbo Zhu, Li Yang
Cc: Rob Herring, Mark Rutland, xiaobo.xie, jiafei.pan,
linux-arm-kernel, devicetree, linux-kernel, Ran Wang
On Mon, Sep 09, 2019 at 05:02:44PM +0800, Yinbo Zhu wrote:
> layerscape otg function should be supported HNP SRP and ADP protocol
> accroing to rm doc, but dwc3 code not realize it and use id pin to
> detect who is host or device(0 is host 1 is device) this patch is to
> enable OTG mode on ls1028ardb ls1088ardb and ls1046ardb in dts
>
> Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
The patch prefix should be something like: 'arm64: dts: ...'
@Leo, do you agree with the changes?
Shawn
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 7975519b4f56..5810d0400dbc 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -320,7 +320,7 @@
> compatible = "fsl,ls1028a-dwc3", "snps,dwc3";
> reg = <0x0 0x3110000 0x0 0x10000>;
> interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
> - dr_mode = "host";
> + dr_mode = "otg";
> snps,dis_rxdet_inp3_quirk;
> snps,quirk-frame-length-adjustment = <0x20>;
> snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index b0ef08b090dd..ecce6151b9b0 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -582,7 +582,7 @@
> compatible = "snps,dwc3";
> reg = <0x0 0x3000000 0x0 0x10000>;
> interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
> - dr_mode = "host";
> + dr_mode = "otg";
> snps,quirk-frame-length-adjustment = <0x20>;
> snps,dis_rxdet_inp3_quirk;
> snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index dacd8cf03a7f..4b5413f7c90c 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -385,7 +385,7 @@
> compatible = "snps,dwc3";
> reg = <0x0 0x3110000 0x0 0x10000>;
> interrupts = <0 81 IRQ_TYPE_LEVEL_HIGH>;
> - dr_mode = "host";
> + dr_mode = "otg";
> snps,quirk-frame-length-adjustment = <0x20>;
> snps,dis_rxdet_inp3_quirk;
> status = "disabled";
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1] usb: dwc3: enable otg mode for dwc3 usb ip on layerscape
@ 2019-10-06 2:54 ` Shawn Guo
0 siblings, 0 replies; 8+ messages in thread
From: Shawn Guo @ 2019-10-06 2:54 UTC (permalink / raw)
To: Yinbo Zhu, Li Yang
Cc: Mark Rutland, devicetree, xiaobo.xie, linux-kernel, Rob Herring,
jiafei.pan, Ran Wang, linux-arm-kernel
On Mon, Sep 09, 2019 at 05:02:44PM +0800, Yinbo Zhu wrote:
> layerscape otg function should be supported HNP SRP and ADP protocol
> accroing to rm doc, but dwc3 code not realize it and use id pin to
> detect who is host or device(0 is host 1 is device) this patch is to
> enable OTG mode on ls1028ardb ls1088ardb and ls1046ardb in dts
>
> Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
The patch prefix should be something like: 'arm64: dts: ...'
@Leo, do you agree with the changes?
Shawn
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 7975519b4f56..5810d0400dbc 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -320,7 +320,7 @@
> compatible = "fsl,ls1028a-dwc3", "snps,dwc3";
> reg = <0x0 0x3110000 0x0 0x10000>;
> interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
> - dr_mode = "host";
> + dr_mode = "otg";
> snps,dis_rxdet_inp3_quirk;
> snps,quirk-frame-length-adjustment = <0x20>;
> snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index b0ef08b090dd..ecce6151b9b0 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -582,7 +582,7 @@
> compatible = "snps,dwc3";
> reg = <0x0 0x3000000 0x0 0x10000>;
> interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
> - dr_mode = "host";
> + dr_mode = "otg";
> snps,quirk-frame-length-adjustment = <0x20>;
> snps,dis_rxdet_inp3_quirk;
> snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index dacd8cf03a7f..4b5413f7c90c 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -385,7 +385,7 @@
> compatible = "snps,dwc3";
> reg = <0x0 0x3110000 0x0 0x10000>;
> interrupts = <0 81 IRQ_TYPE_LEVEL_HIGH>;
> - dr_mode = "host";
> + dr_mode = "otg";
> snps,quirk-frame-length-adjustment = <0x20>;
> snps,dis_rxdet_inp3_quirk;
> status = "disabled";
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1] usb: dwc3: enable otg mode for dwc3 usb ip on layerscape
2019-10-06 2:54 ` Shawn Guo
(?)
@ 2019-10-06 2:58 ` Li Yang
-1 siblings, 0 replies; 8+ messages in thread
From: Li Yang @ 2019-10-06 2:58 UTC (permalink / raw)
To: Shawn Guo
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Xiaobo Xie, lkml, Rob Herring, Jiafei Pan, Ran Wang, Yinbo Zhu,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Sat, Oct 5, 2019 at 9:56 PM Shawn Guo <shawnguo@kernel.org> wrote:
>
> On Mon, Sep 09, 2019 at 05:02:44PM +0800, Yinbo Zhu wrote:
> > layerscape otg function should be supported HNP SRP and ADP protocol
> > accroing to rm doc, but dwc3 code not realize it and use id pin to
> > detect who is host or device(0 is host 1 is device) this patch is to
> > enable OTG mode on ls1028ardb ls1088ardb and ls1046ardb in dts
> >
> > Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
>
> The patch prefix should be something like: 'arm64: dts: ...'
>
> @Leo, do you agree with the changes?
No. The USB mode of operation should be defined at board level.
>
> Shawn
>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
> > arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 2 +-
> > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 2 +-
> > 3 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > index 7975519b4f56..5810d0400dbc 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > @@ -320,7 +320,7 @@
> > compatible = "fsl,ls1028a-dwc3", "snps,dwc3";
> > reg = <0x0 0x3110000 0x0 0x10000>;
> > interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
> > - dr_mode = "host";
> > + dr_mode = "otg";
> > snps,dis_rxdet_inp3_quirk;
> > snps,quirk-frame-length-adjustment = <0x20>;
> > snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > index b0ef08b090dd..ecce6151b9b0 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > @@ -582,7 +582,7 @@
> > compatible = "snps,dwc3";
> > reg = <0x0 0x3000000 0x0 0x10000>;
> > interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
> > - dr_mode = "host";
> > + dr_mode = "otg";
> > snps,quirk-frame-length-adjustment = <0x20>;
> > snps,dis_rxdet_inp3_quirk;
> > snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > index dacd8cf03a7f..4b5413f7c90c 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > @@ -385,7 +385,7 @@
> > compatible = "snps,dwc3";
> > reg = <0x0 0x3110000 0x0 0x10000>;
> > interrupts = <0 81 IRQ_TYPE_LEVEL_HIGH>;
> > - dr_mode = "host";
> > + dr_mode = "otg";
> > snps,quirk-frame-length-adjustment = <0x20>;
> > snps,dis_rxdet_inp3_quirk;
> > status = "disabled";
> > --
> > 2.17.1
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1] usb: dwc3: enable otg mode for dwc3 usb ip on layerscape
@ 2019-10-06 2:58 ` Li Yang
0 siblings, 0 replies; 8+ messages in thread
From: Li Yang @ 2019-10-06 2:58 UTC (permalink / raw)
To: Shawn Guo
Cc: Yinbo Zhu, Rob Herring, Mark Rutland, Xiaobo Xie, Jiafei Pan,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, lkml,
Ran Wang
On Sat, Oct 5, 2019 at 9:56 PM Shawn Guo <shawnguo@kernel.org> wrote:
>
> On Mon, Sep 09, 2019 at 05:02:44PM +0800, Yinbo Zhu wrote:
> > layerscape otg function should be supported HNP SRP and ADP protocol
> > accroing to rm doc, but dwc3 code not realize it and use id pin to
> > detect who is host or device(0 is host 1 is device) this patch is to
> > enable OTG mode on ls1028ardb ls1088ardb and ls1046ardb in dts
> >
> > Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
>
> The patch prefix should be something like: 'arm64: dts: ...'
>
> @Leo, do you agree with the changes?
No. The USB mode of operation should be defined at board level.
>
> Shawn
>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
> > arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 2 +-
> > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 2 +-
> > 3 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > index 7975519b4f56..5810d0400dbc 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > @@ -320,7 +320,7 @@
> > compatible = "fsl,ls1028a-dwc3", "snps,dwc3";
> > reg = <0x0 0x3110000 0x0 0x10000>;
> > interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
> > - dr_mode = "host";
> > + dr_mode = "otg";
> > snps,dis_rxdet_inp3_quirk;
> > snps,quirk-frame-length-adjustment = <0x20>;
> > snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > index b0ef08b090dd..ecce6151b9b0 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > @@ -582,7 +582,7 @@
> > compatible = "snps,dwc3";
> > reg = <0x0 0x3000000 0x0 0x10000>;
> > interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
> > - dr_mode = "host";
> > + dr_mode = "otg";
> > snps,quirk-frame-length-adjustment = <0x20>;
> > snps,dis_rxdet_inp3_quirk;
> > snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > index dacd8cf03a7f..4b5413f7c90c 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > @@ -385,7 +385,7 @@
> > compatible = "snps,dwc3";
> > reg = <0x0 0x3110000 0x0 0x10000>;
> > interrupts = <0 81 IRQ_TYPE_LEVEL_HIGH>;
> > - dr_mode = "host";
> > + dr_mode = "otg";
> > snps,quirk-frame-length-adjustment = <0x20>;
> > snps,dis_rxdet_inp3_quirk;
> > status = "disabled";
> > --
> > 2.17.1
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1] usb: dwc3: enable otg mode for dwc3 usb ip on layerscape
@ 2019-10-06 2:58 ` Li Yang
0 siblings, 0 replies; 8+ messages in thread
From: Li Yang @ 2019-10-06 2:58 UTC (permalink / raw)
To: Shawn Guo
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Xiaobo Xie, lkml, Rob Herring, Jiafei Pan, Ran Wang, Yinbo Zhu,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Sat, Oct 5, 2019 at 9:56 PM Shawn Guo <shawnguo@kernel.org> wrote:
>
> On Mon, Sep 09, 2019 at 05:02:44PM +0800, Yinbo Zhu wrote:
> > layerscape otg function should be supported HNP SRP and ADP protocol
> > accroing to rm doc, but dwc3 code not realize it and use id pin to
> > detect who is host or device(0 is host 1 is device) this patch is to
> > enable OTG mode on ls1028ardb ls1088ardb and ls1046ardb in dts
> >
> > Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
>
> The patch prefix should be something like: 'arm64: dts: ...'
>
> @Leo, do you agree with the changes?
No. The USB mode of operation should be defined at board level.
>
> Shawn
>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
> > arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 2 +-
> > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 2 +-
> > 3 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > index 7975519b4f56..5810d0400dbc 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > @@ -320,7 +320,7 @@
> > compatible = "fsl,ls1028a-dwc3", "snps,dwc3";
> > reg = <0x0 0x3110000 0x0 0x10000>;
> > interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
> > - dr_mode = "host";
> > + dr_mode = "otg";
> > snps,dis_rxdet_inp3_quirk;
> > snps,quirk-frame-length-adjustment = <0x20>;
> > snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > index b0ef08b090dd..ecce6151b9b0 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > @@ -582,7 +582,7 @@
> > compatible = "snps,dwc3";
> > reg = <0x0 0x3000000 0x0 0x10000>;
> > interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
> > - dr_mode = "host";
> > + dr_mode = "otg";
> > snps,quirk-frame-length-adjustment = <0x20>;
> > snps,dis_rxdet_inp3_quirk;
> > snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > index dacd8cf03a7f..4b5413f7c90c 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > @@ -385,7 +385,7 @@
> > compatible = "snps,dwc3";
> > reg = <0x0 0x3110000 0x0 0x10000>;
> > interrupts = <0 81 IRQ_TYPE_LEVEL_HIGH>;
> > - dr_mode = "host";
> > + dr_mode = "otg";
> > snps,quirk-frame-length-adjustment = <0x20>;
> > snps,dis_rxdet_inp3_quirk;
> > status = "disabled";
> > --
> > 2.17.1
> >
^ permalink raw reply [flat|nested] 8+ messages in thread