From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Kukjin Kim <kgene@kernel.org>, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Sebastian Reichel <sre@kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, linux-pm@vger.kernel.org,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: samsung: Indent examples with four spaces
Date: Sun, 6 Oct 2019 11:01:26 +0100 [thread overview]
Message-ID: <20191006110126.131b0ca4@archlinux> (raw)
In-Reply-To: <20191002160744.11307-1-krzk@kernel.org>
On Wed, 2 Oct 2019 18:07:41 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> Change the indentation of examples used in json-schema bindings from two
> to four spaces as this makes the code easier to read and seems to be
> preferred in other files.
>
I'm assuming Rob will pick these up given they span multiple subsystems.
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> # for iio
> ---
> .../bindings/arm/samsung/exynos-chipid.yaml | 4 +-
> .../bindings/iio/adc/samsung,exynos-adc.yaml | 64 +++++++++----------
> .../bindings/power/reset/syscon-poweroff.yaml | 8 +--
> .../bindings/power/reset/syscon-reboot.yaml | 8 +--
> .../devicetree/bindings/rtc/s3c-rtc.yaml | 12 ++--
> 5 files changed, 48 insertions(+), 48 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> index 9c573ad7dc7d..ce40adabb4e8 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> @@ -20,6 +20,6 @@ properties:
> examples:
> - |
> chipid@10000000 {
> - compatible = "samsung,exynos4210-chipid";
> - reg = <0x10000000 0x100>;
> + compatible = "samsung,exynos4210-chipid";
> + reg = <0x10000000 0x100>;
> };
> diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> index b4c6c26681d9..a0a9b909ac40 100644
> --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> @@ -112,40 +112,40 @@ allOf:
> examples:
> - |
> adc: adc@12d10000 {
> - compatible = "samsung,exynos-adc-v1";
> - reg = <0x12d10000 0x100>;
> - interrupts = <0 106 0>;
> - #io-channel-cells = <1>;
> - io-channel-ranges;
> -
> - clocks = <&clock 303>;
> - clock-names = "adc";
> -
> - vdd-supply = <&buck5_reg>;
> - samsung,syscon-phandle = <&pmu_system_controller>;
> -
> - /* NTC thermistor is a hwmon device */
> - ncp15wb473@0 {
> - compatible = "murata,ncp15wb473";
> - pullup-uv = <1800000>;
> - pullup-ohm = <47000>;
> - pulldown-ohm = <0>;
> - io-channels = <&adc 4>;
> - };
> + compatible = "samsung,exynos-adc-v1";
> + reg = <0x12d10000 0x100>;
> + interrupts = <0 106 0>;
> + #io-channel-cells = <1>;
> + io-channel-ranges;
> +
> + clocks = <&clock 303>;
> + clock-names = "adc";
> +
> + vdd-supply = <&buck5_reg>;
> + samsung,syscon-phandle = <&pmu_system_controller>;
> +
> + /* NTC thermistor is a hwmon device */
> + ncp15wb473@0 {
> + compatible = "murata,ncp15wb473";
> + pullup-uv = <1800000>;
> + pullup-ohm = <47000>;
> + pulldown-ohm = <0>;
> + io-channels = <&adc 4>;
> + };
> };
>
> - |
> adc@126c0000 {
> - compatible = "samsung,exynos3250-adc";
> - reg = <0x126C0000 0x100>;
> - interrupts = <0 137 0>;
> - #io-channel-cells = <1>;
> - io-channel-ranges;
> -
> - clocks = <&cmu 0>, // CLK_TSADC
> - <&cmu 1>; // CLK_SCLK_TSADC
> - clock-names = "adc", "sclk";
> -
> - vdd-supply = <&buck5_reg>;
> - samsung,syscon-phandle = <&pmu_system_controller>;
> + compatible = "samsung,exynos3250-adc";
> + reg = <0x126C0000 0x100>;
> + interrupts = <0 137 0>;
> + #io-channel-cells = <1>;
> + io-channel-ranges;
> +
> + clocks = <&cmu 0>, // CLK_TSADC
> + <&cmu 1>; // CLK_SCLK_TSADC
> + clock-names = "adc", "sclk";
> +
> + vdd-supply = <&buck5_reg>;
> + samsung,syscon-phandle = <&pmu_system_controller>;
> };
> diff --git a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> index fb812937b534..520e07e6f21b 100644
> --- a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> @@ -53,8 +53,8 @@ allOf:
> examples:
> - |
> poweroff {
> - compatible = "syscon-poweroff";
> - regmap = <®mapnode>;
> - offset = <0x0>;
> - mask = <0x7a>;
> + compatible = "syscon-poweroff";
> + regmap = <®mapnode>;
> + offset = <0x0>;
> + mask = <0x7a>;
> };
> diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> index a7920f5eef79..d38006b1f1f4 100644
> --- a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> @@ -53,8 +53,8 @@ allOf:
> examples:
> - |
> reboot {
> - compatible = "syscon-reboot";
> - regmap = <®mapnode>;
> - offset = <0x0>;
> - mask = <0x1>;
> + compatible = "syscon-reboot";
> + regmap = <®mapnode>;
> + offset = <0x0>;
> + mask = <0x1>;
> };
> diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> index 951a6a485709..95570d7e19eb 100644
> --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> @@ -76,10 +76,10 @@ allOf:
> examples:
> - |
> rtc@10070000 {
> - compatible = "samsung,s3c6410-rtc";
> - reg = <0x10070000 0x100>;
> - interrupts = <0 44 4>, <0 45 4>;
> - clocks = <&clock 0>, // CLK_RTC
> - <&s2mps11_osc 0>; // S2MPS11_CLK_AP
> - clock-names = "rtc", "rtc_src";
> + compatible = "samsung,s3c6410-rtc";
> + reg = <0x10070000 0x100>;
> + interrupts = <0 44 4>, <0 45 4>;
> + clocks = <&clock 0>, // CLK_RTC
> + <&s2mps11_osc 0>; // S2MPS11_CLK_AP
> + clock-names = "rtc", "rtc_src";
> };
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Lars-Peter Clausen <lars@metafoo.de>,
devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
linux-pm@vger.kernel.org, Sebastian Reichel <sre@kernel.org>,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Hartmut Knaack <knaack.h@gmx.de>,
linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: samsung: Indent examples with four spaces
Date: Sun, 6 Oct 2019 11:01:26 +0100 [thread overview]
Message-ID: <20191006110126.131b0ca4@archlinux> (raw)
In-Reply-To: <20191002160744.11307-1-krzk@kernel.org>
On Wed, 2 Oct 2019 18:07:41 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> Change the indentation of examples used in json-schema bindings from two
> to four spaces as this makes the code easier to read and seems to be
> preferred in other files.
>
I'm assuming Rob will pick these up given they span multiple subsystems.
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> # for iio
> ---
> .../bindings/arm/samsung/exynos-chipid.yaml | 4 +-
> .../bindings/iio/adc/samsung,exynos-adc.yaml | 64 +++++++++----------
> .../bindings/power/reset/syscon-poweroff.yaml | 8 +--
> .../bindings/power/reset/syscon-reboot.yaml | 8 +--
> .../devicetree/bindings/rtc/s3c-rtc.yaml | 12 ++--
> 5 files changed, 48 insertions(+), 48 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> index 9c573ad7dc7d..ce40adabb4e8 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> @@ -20,6 +20,6 @@ properties:
> examples:
> - |
> chipid@10000000 {
> - compatible = "samsung,exynos4210-chipid";
> - reg = <0x10000000 0x100>;
> + compatible = "samsung,exynos4210-chipid";
> + reg = <0x10000000 0x100>;
> };
> diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> index b4c6c26681d9..a0a9b909ac40 100644
> --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> @@ -112,40 +112,40 @@ allOf:
> examples:
> - |
> adc: adc@12d10000 {
> - compatible = "samsung,exynos-adc-v1";
> - reg = <0x12d10000 0x100>;
> - interrupts = <0 106 0>;
> - #io-channel-cells = <1>;
> - io-channel-ranges;
> -
> - clocks = <&clock 303>;
> - clock-names = "adc";
> -
> - vdd-supply = <&buck5_reg>;
> - samsung,syscon-phandle = <&pmu_system_controller>;
> -
> - /* NTC thermistor is a hwmon device */
> - ncp15wb473@0 {
> - compatible = "murata,ncp15wb473";
> - pullup-uv = <1800000>;
> - pullup-ohm = <47000>;
> - pulldown-ohm = <0>;
> - io-channels = <&adc 4>;
> - };
> + compatible = "samsung,exynos-adc-v1";
> + reg = <0x12d10000 0x100>;
> + interrupts = <0 106 0>;
> + #io-channel-cells = <1>;
> + io-channel-ranges;
> +
> + clocks = <&clock 303>;
> + clock-names = "adc";
> +
> + vdd-supply = <&buck5_reg>;
> + samsung,syscon-phandle = <&pmu_system_controller>;
> +
> + /* NTC thermistor is a hwmon device */
> + ncp15wb473@0 {
> + compatible = "murata,ncp15wb473";
> + pullup-uv = <1800000>;
> + pullup-ohm = <47000>;
> + pulldown-ohm = <0>;
> + io-channels = <&adc 4>;
> + };
> };
>
> - |
> adc@126c0000 {
> - compatible = "samsung,exynos3250-adc";
> - reg = <0x126C0000 0x100>;
> - interrupts = <0 137 0>;
> - #io-channel-cells = <1>;
> - io-channel-ranges;
> -
> - clocks = <&cmu 0>, // CLK_TSADC
> - <&cmu 1>; // CLK_SCLK_TSADC
> - clock-names = "adc", "sclk";
> -
> - vdd-supply = <&buck5_reg>;
> - samsung,syscon-phandle = <&pmu_system_controller>;
> + compatible = "samsung,exynos3250-adc";
> + reg = <0x126C0000 0x100>;
> + interrupts = <0 137 0>;
> + #io-channel-cells = <1>;
> + io-channel-ranges;
> +
> + clocks = <&cmu 0>, // CLK_TSADC
> + <&cmu 1>; // CLK_SCLK_TSADC
> + clock-names = "adc", "sclk";
> +
> + vdd-supply = <&buck5_reg>;
> + samsung,syscon-phandle = <&pmu_system_controller>;
> };
> diff --git a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> index fb812937b534..520e07e6f21b 100644
> --- a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> @@ -53,8 +53,8 @@ allOf:
> examples:
> - |
> poweroff {
> - compatible = "syscon-poweroff";
> - regmap = <®mapnode>;
> - offset = <0x0>;
> - mask = <0x7a>;
> + compatible = "syscon-poweroff";
> + regmap = <®mapnode>;
> + offset = <0x0>;
> + mask = <0x7a>;
> };
> diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> index a7920f5eef79..d38006b1f1f4 100644
> --- a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
> @@ -53,8 +53,8 @@ allOf:
> examples:
> - |
> reboot {
> - compatible = "syscon-reboot";
> - regmap = <®mapnode>;
> - offset = <0x0>;
> - mask = <0x1>;
> + compatible = "syscon-reboot";
> + regmap = <®mapnode>;
> + offset = <0x0>;
> + mask = <0x1>;
> };
> diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> index 951a6a485709..95570d7e19eb 100644
> --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> @@ -76,10 +76,10 @@ allOf:
> examples:
> - |
> rtc@10070000 {
> - compatible = "samsung,s3c6410-rtc";
> - reg = <0x10070000 0x100>;
> - interrupts = <0 44 4>, <0 45 4>;
> - clocks = <&clock 0>, // CLK_RTC
> - <&s2mps11_osc 0>; // S2MPS11_CLK_AP
> - clock-names = "rtc", "rtc_src";
> + compatible = "samsung,s3c6410-rtc";
> + reg = <0x10070000 0x100>;
> + interrupts = <0 44 4>, <0 45 4>;
> + clocks = <&clock 0>, // CLK_RTC
> + <&s2mps11_osc 0>; // S2MPS11_CLK_AP
> + clock-names = "rtc", "rtc_src";
> };
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-06 10:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 16:07 [PATCH 1/4] dt-bindings: samsung: Indent examples with four spaces Krzysztof Kozlowski
2019-10-02 16:07 ` Krzysztof Kozlowski
2019-10-02 16:07 ` [PATCH 2/4] dt-bindings: rtc: s3c: Use defines instead of clock numbers Krzysztof Kozlowski
2019-10-02 16:07 ` Krzysztof Kozlowski
2019-10-07 13:17 ` Alexandre Belloni
2019-10-07 13:17 ` Alexandre Belloni
2019-10-15 17:10 ` Rob Herring
2019-10-15 17:10 ` Rob Herring
2019-10-02 16:07 ` [PATCH 3/4] dt-bindings: rtc: s3c: Include generic dt-schema bindings Krzysztof Kozlowski
2019-10-02 16:07 ` Krzysztof Kozlowski
2019-10-07 13:17 ` Alexandre Belloni
2019-10-07 13:17 ` Alexandre Belloni
2019-10-15 17:11 ` Rob Herring
2019-10-15 17:11 ` Rob Herring
2019-10-02 16:07 ` [PATCH 4/4] dt-bindings: iio: adc: exynos: Use defines instead of clock numbers Krzysztof Kozlowski
2019-10-02 16:07 ` Krzysztof Kozlowski
2019-10-06 10:02 ` Jonathan Cameron
2019-10-06 10:02 ` Jonathan Cameron
2019-10-15 17:11 ` Rob Herring
2019-10-15 17:11 ` Rob Herring
2019-10-06 10:01 ` Jonathan Cameron [this message]
2019-10-06 10:01 ` [PATCH 1/4] dt-bindings: samsung: Indent examples with four spaces Jonathan Cameron
2019-10-07 13:17 ` Alexandre Belloni
2019-10-07 13:17 ` Alexandre Belloni
2019-10-10 16:48 ` Sebastian Reichel
2019-10-10 16:48 ` Sebastian Reichel
2019-10-15 17:10 ` Rob Herring
2019-10-15 17:10 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191006110126.131b0ca4@archlinux \
--to=jic23@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=knaack.h@gmx.de \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.