From: Pavel Machek <pavel@denx.de>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
Jonathan Corbet <corbet@lwn.net>, Mat King <mathewk@google.com>,
rafael@kernel.org, gregkh@linuxfoundation.org,
Ross Zwisler <zwisler@google.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Jingoo Han <jingoohan1@gmail.com>,
Rajat Jain <rajatja@google.com>, Lee Jones <lee.jones@linaro.org>,
Alexander Schremmer <alex@alexanderweb.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: New sysfs interface for privacy screens
Date: Sun, 6 Oct 2019 13:04:56 +0200 [thread overview]
Message-ID: <20191006110455.GC24605@amd> (raw)
In-Reply-To: <20191003102254.dmwl6qimdca3dbrv@holly.lan>
[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]
Hi!
> > >> I have been looking into adding Linux support for electronic privacy
> > >> screens which is a feature on some new laptops which is built into the
> > >> display and allows users to turn it on instead of needing to use a
> > >> physical privacy filter. In discussions with my colleagues the idea of
> > >> using either /sys/class/backlight or /sys/class/leds but this new
> > >> feature does not seem to quite fit into either of those classes.
> > >
> > > FWIW, it seems that you're not alone in this; 5.4 got some support for
> > > such screens if I understand things correctly:
> > >
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=110ea1d833ad
> >
> > Oh, I didn't realize it got merged already, I thought this was
> > related...
> >
> > So we've already replicated the backlight sysfs interface problem for
> > privacy screens. :(
>
> I guess... although the Thinkpad code hasn't added any standard
> interfaces (no other laptop should be placing controls for a privacy
> screen in /proc/acpi/ibm/... ). Maybe its not too late.
There's new interface for controlling privacyguard... but perhaps we
need better solution than what went in 5.4. Perhaps it should be
reconsidered?
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@denx.de>
To: Daniel Thompson <daniel.thompson@linaro.org>,
alex@alexanderweb.de, andriy.shevchenko@linux.intel.com
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
Jonathan Corbet <corbet@lwn.net>, Mat King <mathewk@google.com>,
rafael@kernel.org, gregkh@linuxfoundation.org,
Ross Zwisler <zwisler@google.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Jingoo Han <jingoohan1@gmail.com>,
Rajat Jain <rajatja@google.com>, Lee Jones <lee.jones@linaro.org>,
Alexander Schremmer <alex@alexanderweb.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: New sysfs interface for privacy screens
Date: Sun, 6 Oct 2019 13:04:56 +0200 [thread overview]
Message-ID: <20191006110455.GC24605@amd> (raw)
In-Reply-To: <20191003102254.dmwl6qimdca3dbrv@holly.lan>
[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]
Hi!
> > >> I have been looking into adding Linux support for electronic privacy
> > >> screens which is a feature on some new laptops which is built into the
> > >> display and allows users to turn it on instead of needing to use a
> > >> physical privacy filter. In discussions with my colleagues the idea of
> > >> using either /sys/class/backlight or /sys/class/leds but this new
> > >> feature does not seem to quite fit into either of those classes.
> > >
> > > FWIW, it seems that you're not alone in this; 5.4 got some support for
> > > such screens if I understand things correctly:
> > >
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=110ea1d833ad
> >
> > Oh, I didn't realize it got merged already, I thought this was
> > related...
> >
> > So we've already replicated the backlight sysfs interface problem for
> > privacy screens. :(
>
> I guess... although the Thinkpad code hasn't added any standard
> interfaces (no other laptop should be placing controls for a privacy
> screen in /proc/acpi/ibm/... ). Maybe its not too late.
There's new interface for controlling privacyguard... but perhaps we
need better solution than what went in 5.4. Perhaps it should be
reconsidered?
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-10-06 11:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 16:09 New sysfs interface for privacy screens Mat King
2019-10-01 16:27 ` Greg KH
2019-10-01 16:42 ` Mat King
2019-10-02 9:30 ` Jani Nikula
2019-10-02 10:24 ` Daniel Thompson
2019-10-02 10:46 ` Jani Nikula
2019-10-02 15:25 ` Mat King
2019-10-03 8:59 ` Jani Nikula
2019-10-03 19:57 ` Mat King
2019-10-07 4:56 ` Rajat Jain
2019-10-07 8:59 ` Jani Nikula
2019-10-07 13:08 ` Sean Paul
2019-10-07 16:19 ` Mat King
2019-10-07 19:31 ` Rajat Jain
2019-10-07 19:53 ` Sean Paul
2019-10-08 6:13 ` Jani Nikula
2019-10-23 0:14 ` Rajat Jain
2019-10-23 0:17 ` Rajat Jain
2019-10-23 8:39 ` Daniel Vetter
2019-10-02 15:46 ` Jonathan Corbet
2019-10-02 17:13 ` Mat King
2019-10-03 8:19 ` Jani Nikula
2019-10-03 10:22 ` Daniel Thompson
2019-10-06 11:04 ` Pavel Machek [this message]
2019-10-06 11:04 ` Pavel Machek
2019-10-06 16:48 ` Jingoo Han
2019-10-06 16:48 ` Jingoo Han
2019-10-06 20:34 ` Henrique de Moraes Holschuh
2019-10-06 20:34 ` Henrique de Moraes Holschuh
2019-10-06 11:00 ` Pavel Machek
2019-10-06 10:58 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191006110455.GC24605@amd \
--to=pavel@denx.de \
--cc=alex@alexanderweb.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=corbet@lwn.net \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jani.nikula@linux.intel.com \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathewk@google.com \
--cc=rafael@kernel.org \
--cc=rajatja@google.com \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.