From: Shawn Guo <shawnguo@kernel.org>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
ping.bai@nxp.com, daniel.baluta@nxp.com, s.hauer@pengutronix.de,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
Linux-imx@nxp.com, kernel@pengutronix.de,
leonard.crestez@nxp.com, festevam@gmail.com,
linux-arm-kernel@lists.infradead.org, jun.li@nxp.com
Subject: Re: [PATCH 1/2] arm64: dts: imx8mm-evk: Add i2c3 support
Date: Mon, 7 Oct 2019 20:23:16 +0800 [thread overview]
Message-ID: <20191007122313.GJ7150@dragon> (raw)
In-Reply-To: <1568886408-18168-1-git-send-email-Anson.Huang@nxp.com>
On Thu, Sep 19, 2019 at 05:46:47PM +0800, Anson Huang wrote:
> Enable i2c3 for i.MX8MM EVK board.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> index f7a15f3..7758c1c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> @@ -306,6 +306,13 @@
> };
> };
>
> +&i2c3 {
> + clock-frequency = <400000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_i2c3>;
> + status = "okay";
> +};
> +
> &iomuxc {
The iomuxc node is being put at end of file because of its huge pinctrl
data. I2C devices should be placed in alphabetical sort though. Can
you please have a patch moving i2c1 and i2c2 to correct place first,
and then add i2c3?
Shawn
> pinctrl-names = "default";
>
> @@ -355,6 +362,13 @@
> >;
> };
>
> + pinctrl_i2c3: i2c3grp {
> + fsl,pins = <
> + MX8MM_IOMUXC_I2C3_SCL_I2C3_SCL 0x400001c3
> + MX8MM_IOMUXC_I2C3_SDA_I2C3_SDA 0x400001c3
> + >;
> + };
> +
> pinctrl_pmic: pmicirq {
> fsl,pins = <
> MX8MM_IOMUXC_GPIO1_IO03_GPIO1_IO3 0x41
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com,
leonard.crestez@nxp.com, daniel.baluta@nxp.com, ping.bai@nxp.com,
jun.li@nxp.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Linux-imx@nxp.com
Subject: Re: [PATCH 1/2] arm64: dts: imx8mm-evk: Add i2c3 support
Date: Mon, 7 Oct 2019 20:23:16 +0800 [thread overview]
Message-ID: <20191007122313.GJ7150@dragon> (raw)
In-Reply-To: <1568886408-18168-1-git-send-email-Anson.Huang@nxp.com>
On Thu, Sep 19, 2019 at 05:46:47PM +0800, Anson Huang wrote:
> Enable i2c3 for i.MX8MM EVK board.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> index f7a15f3..7758c1c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> @@ -306,6 +306,13 @@
> };
> };
>
> +&i2c3 {
> + clock-frequency = <400000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_i2c3>;
> + status = "okay";
> +};
> +
> &iomuxc {
The iomuxc node is being put at end of file because of its huge pinctrl
data. I2C devices should be placed in alphabetical sort though. Can
you please have a patch moving i2c1 and i2c2 to correct place first,
and then add i2c3?
Shawn
> pinctrl-names = "default";
>
> @@ -355,6 +362,13 @@
> >;
> };
>
> + pinctrl_i2c3: i2c3grp {
> + fsl,pins = <
> + MX8MM_IOMUXC_I2C3_SCL_I2C3_SCL 0x400001c3
> + MX8MM_IOMUXC_I2C3_SDA_I2C3_SDA 0x400001c3
> + >;
> + };
> +
> pinctrl_pmic: pmicirq {
> fsl,pins = <
> MX8MM_IOMUXC_GPIO1_IO03_GPIO1_IO3 0x41
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-10-07 12:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 9:46 [PATCH 1/2] arm64: dts: imx8mm-evk: Add i2c3 support Anson Huang
2019-09-19 9:46 ` Anson Huang
2019-09-19 9:46 ` [PATCH 2/2] arm64: dts: imx8mm-evk: Enable pca6416 on i2c3 bus Anson Huang
2019-09-19 9:46 ` Anson Huang
2019-10-07 12:23 ` Shawn Guo [this message]
2019-10-07 12:23 ` [PATCH 1/2] arm64: dts: imx8mm-evk: Add i2c3 support Shawn Guo
2019-10-08 1:28 ` Anson Huang
2019-10-08 1:28 ` Anson Huang
2019-10-08 1:28 ` Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007122313.GJ7150@dragon \
--to=shawnguo@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ping.bai@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.