* [PATCH 1/5] drm/panel: lg-lb035q02: Fix SPI alias
2019-10-07 17:07 [PATCH 0/5] Fix SPI module alias for panels used by omapdrm Laurent Pinchart
@ 2019-10-07 17:07 ` Laurent Pinchart
2019-10-07 17:07 ` [PATCH 2/5] drm/panel: nec-nl8048hl11: " Laurent Pinchart
` (5 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Laurent Pinchart @ 2019-10-07 17:07 UTC (permalink / raw)
To: dri-devel
Cc: linux-omap, Tony Lindgren, H. Nikolaus Schaller, Jyri Sarha,
Tomi Valkeinen, thierry.reding, letux-kernel, sam
The panel-lg-lb035q02 driver incorrectly includes the OF vendor prefix
in its SPI alias. Fix it, and move the manual alias to an SPI module
device table.
Fixes: f5b0c6542476 ("drm/panel: Add driver for the LG Philips LB035Q02 panel")
Reported-by: H. Nikolaus Schaller <hns@goldelico.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/gpu/drm/panel/panel-lg-lb035q02.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-lg-lb035q02.c b/drivers/gpu/drm/panel/panel-lg-lb035q02.c
index fc82a525b071..ee4379729a5b 100644
--- a/drivers/gpu/drm/panel/panel-lg-lb035q02.c
+++ b/drivers/gpu/drm/panel/panel-lg-lb035q02.c
@@ -220,9 +220,17 @@ static const struct of_device_id lb035q02_of_match[] = {
MODULE_DEVICE_TABLE(of, lb035q02_of_match);
+static const struct spi_device_id lb035q02_ids[] = {
+ { "lb035q02", 0 },
+ { /* sentinel */ }
+};
+
+MODULE_DEVICE_TABLE(spi, lb035q02_ids);
+
static struct spi_driver lb035q02_driver = {
.probe = lb035q02_probe,
.remove = lb035q02_remove,
+ .id_table = lb035q02_ids,
.driver = {
.name = "panel-lg-lb035q02",
.of_match_table = lb035q02_of_match,
@@ -231,7 +239,6 @@ static struct spi_driver lb035q02_driver = {
module_spi_driver(lb035q02_driver);
-MODULE_ALIAS("spi:lgphilips,lb035q02");
MODULE_AUTHOR("Tomi Valkeinen <tomi.valkeinen@ti.com>");
MODULE_DESCRIPTION("LG.Philips LB035Q02 LCD Panel driver");
MODULE_LICENSE("GPL");
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 2/5] drm/panel: nec-nl8048hl11: Fix SPI alias
2019-10-07 17:07 [PATCH 0/5] Fix SPI module alias for panels used by omapdrm Laurent Pinchart
2019-10-07 17:07 ` [PATCH 1/5] drm/panel: lg-lb035q02: Fix SPI alias Laurent Pinchart
@ 2019-10-07 17:07 ` Laurent Pinchart
2019-10-07 17:07 ` [PATCH 3/5] drm/panel: sony-acx565akm: " Laurent Pinchart
` (4 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Laurent Pinchart @ 2019-10-07 17:07 UTC (permalink / raw)
To: dri-devel
Cc: linux-omap, Tony Lindgren, H. Nikolaus Schaller, Jyri Sarha,
Tomi Valkeinen, thierry.reding, letux-kernel, sam
The panel-nec-nl8048hl11 driver incorrectly includes the OF vendor
prefix in its SPI alias. Fix it, and move the manual alias to an SPI
module device table.
Fixes: df439abe6501 ("drm/panel: Add driver for the NEC NL8048HL11 panel")
Reported-by: H. Nikolaus Schaller <hns@goldelico.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/gpu/drm/panel/panel-nec-nl8048hl11.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-nec-nl8048hl11.c b/drivers/gpu/drm/panel/panel-nec-nl8048hl11.c
index 299b217c83e1..20f17e46e65d 100644
--- a/drivers/gpu/drm/panel/panel-nec-nl8048hl11.c
+++ b/drivers/gpu/drm/panel/panel-nec-nl8048hl11.c
@@ -230,9 +230,17 @@ static const struct of_device_id nl8048_of_match[] = {
MODULE_DEVICE_TABLE(of, nl8048_of_match);
+static const struct spi_device_id nl8048_ids[] = {
+ { "nl8048hl11", 0 },
+ { /* sentinel */ }
+};
+
+MODULE_DEVICE_TABLE(spi, nl8048_ids);
+
static struct spi_driver nl8048_driver = {
.probe = nl8048_probe,
.remove = nl8048_remove,
+ .id_table = nl8048_ids,
.driver = {
.name = "panel-nec-nl8048hl11",
.pm = &nl8048_pm_ops,
@@ -242,7 +250,6 @@ static struct spi_driver nl8048_driver = {
module_spi_driver(nl8048_driver);
-MODULE_ALIAS("spi:nec,nl8048hl11");
MODULE_AUTHOR("Erik Gilling <konkers@android.com>");
MODULE_DESCRIPTION("NEC-NL8048HL11 Driver");
MODULE_LICENSE("GPL");
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 3/5] drm/panel: sony-acx565akm: Fix SPI alias
2019-10-07 17:07 [PATCH 0/5] Fix SPI module alias for panels used by omapdrm Laurent Pinchart
2019-10-07 17:07 ` [PATCH 1/5] drm/panel: lg-lb035q02: Fix SPI alias Laurent Pinchart
2019-10-07 17:07 ` [PATCH 2/5] drm/panel: nec-nl8048hl11: " Laurent Pinchart
@ 2019-10-07 17:07 ` Laurent Pinchart
2019-10-07 17:08 ` [PATCH 4/5] drm/panel: tpo-td028ttec1: " Laurent Pinchart
` (3 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Laurent Pinchart @ 2019-10-07 17:07 UTC (permalink / raw)
To: dri-devel
Cc: linux-omap, Tony Lindgren, H. Nikolaus Schaller, Jyri Sarha,
Tomi Valkeinen, thierry.reding, letux-kernel, sam
The panel-sony-acx565akm driver incorrectly includes the OF vendor
prefix in its SPI alias. Fix it, and move the manual alias to an SPI
module device table.
Fixes: 1c8fc3f0c5d2 ("drm/panel: Add driver for the Sony ACX565AKM panel")
Reported-by: H. Nikolaus Schaller <hns@goldelico.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/gpu/drm/panel/panel-sony-acx565akm.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-sony-acx565akm.c b/drivers/gpu/drm/panel/panel-sony-acx565akm.c
index 305259b58767..3d5b9c4f68d9 100644
--- a/drivers/gpu/drm/panel/panel-sony-acx565akm.c
+++ b/drivers/gpu/drm/panel/panel-sony-acx565akm.c
@@ -684,9 +684,17 @@ static const struct of_device_id acx565akm_of_match[] = {
MODULE_DEVICE_TABLE(of, acx565akm_of_match);
+static const struct spi_device_id acx565akm_ids[] = {
+ { "acx565akm", 0 },
+ { /* sentinel */ }
+};
+
+MODULE_DEVICE_TABLE(spi, acx565akm_ids);
+
static struct spi_driver acx565akm_driver = {
.probe = acx565akm_probe,
.remove = acx565akm_remove,
+ .id_table = acx565akm_ids,
.driver = {
.name = "panel-sony-acx565akm",
.of_match_table = acx565akm_of_match,
@@ -695,7 +703,6 @@ static struct spi_driver acx565akm_driver = {
module_spi_driver(acx565akm_driver);
-MODULE_ALIAS("spi:sony,acx565akm");
MODULE_AUTHOR("Nokia Corporation");
MODULE_DESCRIPTION("Sony ACX565AKM LCD Panel Driver");
MODULE_LICENSE("GPL");
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 4/5] drm/panel: tpo-td028ttec1: Fix SPI alias
2019-10-07 17:07 [PATCH 0/5] Fix SPI module alias for panels used by omapdrm Laurent Pinchart
` (2 preceding siblings ...)
2019-10-07 17:07 ` [PATCH 3/5] drm/panel: sony-acx565akm: " Laurent Pinchart
@ 2019-10-07 17:08 ` Laurent Pinchart
2019-10-07 17:58 ` [Letux-kernel] " Andreas Kemnade
2019-10-07 17:08 ` [PATCH 5/5] drm/panel: tpo-td043mtea1: " Laurent Pinchart
` (2 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: Laurent Pinchart @ 2019-10-07 17:08 UTC (permalink / raw)
To: dri-devel
Cc: linux-omap, Tony Lindgren, H. Nikolaus Schaller, Jyri Sarha,
Tomi Valkeinen, thierry.reding, letux-kernel, sam
The panel-tpo-td028ttec1 driver incorrectly includes the OF vendor
prefix in its SPI alias. Fix it.
Fixes: 415b8dd08711 ("drm/panel: Add driver for the Toppoly TD028TTEC1 panel")
Reported-by: H. Nikolaus Schaller <hns@goldelico.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/gpu/drm/panel/panel-tpo-td028ttec1.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c b/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c
index d7b2e34626ef..f2baff827f50 100644
--- a/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c
+++ b/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c
@@ -375,8 +375,7 @@ static const struct of_device_id td028ttec1_of_match[] = {
MODULE_DEVICE_TABLE(of, td028ttec1_of_match);
static const struct spi_device_id td028ttec1_ids[] = {
- { "tpo,td028ttec1", 0},
- { "toppoly,td028ttec1", 0 },
+ { "td028ttec1", 0 },
{ /* sentinel */ }
};
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [Letux-kernel] [PATCH 4/5] drm/panel: tpo-td028ttec1: Fix SPI alias
2019-10-07 17:08 ` [PATCH 4/5] drm/panel: tpo-td028ttec1: " Laurent Pinchart
@ 2019-10-07 17:58 ` Andreas Kemnade
2019-10-07 19:33 ` H. Nikolaus Schaller
0 siblings, 1 reply; 13+ messages in thread
From: Andreas Kemnade @ 2019-10-07 17:58 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Discussions about the Letux Kernel, Tony Lindgren, Jyri Sarha,
Tomi Valkeinen, thierry.reding, dri-devel, linux-omap, sam
On Mon, 7 Oct 2019 20:08:00 +0300
Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> The panel-tpo-td028ttec1 driver incorrectly includes the OF vendor
> prefix in its SPI alias. Fix it.
>
> Fixes: 415b8dd08711 ("drm/panel: Add driver for the Toppoly TD028TTEC1 panel")
> Reported-by: H. Nikolaus Schaller <hns@goldelico.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Tested-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> drivers/gpu/drm/panel/panel-tpo-td028ttec1.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c b/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c
> index d7b2e34626ef..f2baff827f50 100644
> --- a/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c
> +++ b/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c
> @@ -375,8 +375,7 @@ static const struct of_device_id td028ttec1_of_match[] = {
> MODULE_DEVICE_TABLE(of, td028ttec1_of_match);
>
> static const struct spi_device_id td028ttec1_ids[] = {
> - { "tpo,td028ttec1", 0},
> - { "toppoly,td028ttec1", 0 },
> + { "td028ttec1", 0 },
> { /* sentinel */ }
> };
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [Letux-kernel] [PATCH 4/5] drm/panel: tpo-td028ttec1: Fix SPI alias
2019-10-07 17:58 ` [Letux-kernel] " Andreas Kemnade
@ 2019-10-07 19:33 ` H. Nikolaus Schaller
0 siblings, 0 replies; 13+ messages in thread
From: H. Nikolaus Schaller @ 2019-10-07 19:33 UTC (permalink / raw)
To: Andreas Kemnade
Cc: Discussions about the Letux Kernel, Tony Lindgren, dri-devel,
Jyri Sarha, Tomi Valkeinen, thierry.reding, Laurent Pinchart,
linux-omap, sam
> Am 07.10.2019 um 19:58 schrieb Andreas Kemnade <andreas@kemnade.info>:
>
> On Mon, 7 Oct 2019 20:08:00 +0300
> Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
>
>> The panel-tpo-td028ttec1 driver incorrectly includes the OF vendor
>> prefix in its SPI alias. Fix it.
>>
>> Fixes: 415b8dd08711 ("drm/panel: Add driver for the Toppoly TD028TTEC1 panel")
>> Reported-by: H. Nikolaus Schaller <hns@goldelico.com>
>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Tested-by: Andreas Kemnade <andreas@kemnade.info>
Tested-by: H. Nikolaus Schaller <hns@goldelico.com>
>
>> ---
>> drivers/gpu/drm/panel/panel-tpo-td028ttec1.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c b/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c
>> index d7b2e34626ef..f2baff827f50 100644
>> --- a/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c
>> +++ b/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c
>> @@ -375,8 +375,7 @@ static const struct of_device_id td028ttec1_of_match[] = {
>> MODULE_DEVICE_TABLE(of, td028ttec1_of_match);
>>
>> static const struct spi_device_id td028ttec1_ids[] = {
>> - { "tpo,td028ttec1", 0},
>> - { "toppoly,td028ttec1", 0 },
>> + { "td028ttec1", 0 },
>> { /* sentinel */ }
>> };
>>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 5/5] drm/panel: tpo-td043mtea1: Fix SPI alias
2019-10-07 17:07 [PATCH 0/5] Fix SPI module alias for panels used by omapdrm Laurent Pinchart
` (3 preceding siblings ...)
2019-10-07 17:08 ` [PATCH 4/5] drm/panel: tpo-td028ttec1: " Laurent Pinchart
@ 2019-10-07 17:08 ` Laurent Pinchart
2019-10-07 19:34 ` H. Nikolaus Schaller
2019-10-07 17:22 ` [PATCH 0/5] Fix SPI module alias for panels used by omapdrm Sam Ravnborg
2019-10-07 17:27 ` Sebastian Reichel
6 siblings, 1 reply; 13+ messages in thread
From: Laurent Pinchart @ 2019-10-07 17:08 UTC (permalink / raw)
To: dri-devel
Cc: linux-omap, Tony Lindgren, H. Nikolaus Schaller, Jyri Sarha,
Tomi Valkeinen, thierry.reding, letux-kernel, sam
The panel-tpo-td043mtea1 driver incorrectly includes the OF vendor
prefix in its SPI alias. Fix it, and move the manual alias to an SPI
module device table.
Fixes: dc2e1e5b2799 ("drm/panel: Add driver for the Toppoly TD043MTEA1 panel")
Reported-by: H. Nikolaus Schaller <hns@goldelico.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/gpu/drm/panel/panel-tpo-td043mtea1.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c b/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
index 84370562910f..ba163c779084 100644
--- a/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
+++ b/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
@@ -491,9 +491,17 @@ static const struct of_device_id td043mtea1_of_match[] = {
MODULE_DEVICE_TABLE(of, td043mtea1_of_match);
+static const struct spi_device_id td043mtea1_ids[] = {
+ { "td043mtea1", 0 },
+ { /* sentinel */ }
+};
+
+MODULE_DEVICE_TABLE(spi, td043mtea1_ids);
+
static struct spi_driver td043mtea1_driver = {
.probe = td043mtea1_probe,
.remove = td043mtea1_remove,
+ .id_table = td043mtea1_ids,
.driver = {
.name = "panel-tpo-td043mtea1",
.pm = &td043mtea1_pm_ops,
@@ -503,7 +511,6 @@ static struct spi_driver td043mtea1_driver = {
module_spi_driver(td043mtea1_driver);
-MODULE_ALIAS("spi:tpo,td043mtea1");
MODULE_AUTHOR("Gražvydas Ignotas <notasas@gmail.com>");
MODULE_DESCRIPTION("TPO TD043MTEA1 Panel Driver");
MODULE_LICENSE("GPL");
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 5/5] drm/panel: tpo-td043mtea1: Fix SPI alias
2019-10-07 17:08 ` [PATCH 5/5] drm/panel: tpo-td043mtea1: " Laurent Pinchart
@ 2019-10-07 19:34 ` H. Nikolaus Schaller
0 siblings, 0 replies; 13+ messages in thread
From: H. Nikolaus Schaller @ 2019-10-07 19:34 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-omap, Tony Lindgren, dri-devel, Tomi Valkeinen,
thierry.reding, Jyri Sarha, letux-kernel, sam
> Am 07.10.2019 um 19:08 schrieb Laurent Pinchart <laurent.pinchart@ideasonboard.com>:
>
> The panel-tpo-td043mtea1 driver incorrectly includes the OF vendor
> prefix in its SPI alias. Fix it, and move the manual alias to an SPI
> module device table.
>
> Fixes: dc2e1e5b2799 ("drm/panel: Add driver for the Toppoly TD043MTEA1 panel")
> Reported-by: H. Nikolaus Schaller <hns@goldelico.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Tested-by: H. Nikolaus Schaller <hns@goldelico.com> # OpenPandora
> ---
> drivers/gpu/drm/panel/panel-tpo-td043mtea1.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c b/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
> index 84370562910f..ba163c779084 100644
> --- a/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
> +++ b/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
> @@ -491,9 +491,17 @@ static const struct of_device_id td043mtea1_of_match[] = {
>
> MODULE_DEVICE_TABLE(of, td043mtea1_of_match);
>
> +static const struct spi_device_id td043mtea1_ids[] = {
> + { "td043mtea1", 0 },
> + { /* sentinel */ }
> +};
> +
> +MODULE_DEVICE_TABLE(spi, td043mtea1_ids);
> +
> static struct spi_driver td043mtea1_driver = {
> .probe = td043mtea1_probe,
> .remove = td043mtea1_remove,
> + .id_table = td043mtea1_ids,
> .driver = {
> .name = "panel-tpo-td043mtea1",
> .pm = &td043mtea1_pm_ops,
> @@ -503,7 +511,6 @@ static struct spi_driver td043mtea1_driver = {
>
> module_spi_driver(td043mtea1_driver);
>
> -MODULE_ALIAS("spi:tpo,td043mtea1");
> MODULE_AUTHOR("Gražvydas Ignotas <notasas@gmail.com>");
> MODULE_DESCRIPTION("TPO TD043MTEA1 Panel Driver");
> MODULE_LICENSE("GPL");
> --
> Regards,
>
> Laurent Pinchart
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 0/5] Fix SPI module alias for panels used by omapdrm
2019-10-07 17:07 [PATCH 0/5] Fix SPI module alias for panels used by omapdrm Laurent Pinchart
` (4 preceding siblings ...)
2019-10-07 17:08 ` [PATCH 5/5] drm/panel: tpo-td043mtea1: " Laurent Pinchart
@ 2019-10-07 17:22 ` Sam Ravnborg
2019-10-07 17:44 ` Laurent Pinchart
2019-10-08 5:24 ` Tomi Valkeinen
2019-10-07 17:27 ` Sebastian Reichel
6 siblings, 2 replies; 13+ messages in thread
From: Sam Ravnborg @ 2019-10-07 17:22 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-omap, Tony Lindgren, H. Nikolaus Schaller, dri-devel,
Tomi Valkeinen, thierry.reding, Jyri Sarha, letux-kernel
Hi Laurent.
On Mon, Oct 07, 2019 at 08:07:56PM +0300, Laurent Pinchart wrote:
> Hello,
>
> This patch series fixes a module alias issue with the five recently
> added panel drivers used by omapdrm.
>
> Before those panel drivers, omapdrm had custom drivers for the panels,
> and prefixed the OF compatible strings with an "omapdss," prefix. The
> SPI device IDs are constructed by stripping the OF compatible string
> from the prefix, resulting in the "omapdss," prefix being removed, but
> the subsequence OF vendor prefix being kept. The SPI drivers thus had
> modules aliases that contained the vendor prefix.
>
> Now that the panels are supported by standard drivers and the "omapdss,"
> prefix is removed, the SPI device IDs are stripped from the OF vendor
> prefix. As the new panel drivers copied the module aliases from the
> omapdrm-specific drivers, they contain the vendor prefix in their SPI
> module aliases, and are thus not loaded automatically.
>
> Fix this by removing the vendor prefix from the SPI modules aliases in
> the drivers. For consistency reason, the manual module aliases are also
> moved to use an SPI module table.
Good explanation - thanks.
>
> These patches are based on the drm-misc-fixes branch as they fix v5.4
> regressions.
>
> Laurent Pinchart (5):
> drm/panel: lg-lb035q02: Fix SPI alias
> drm/panel: nec-nl8048hl11: Fix SPI alias
> drm/panel: sony-acx565akm: Fix SPI alias
> drm/panel: tpo-td028ttec1: Fix SPI alias
> drm/panel: tpo-td043mtea1: Fix SPI alias
Full series is:
Acked-by: Sam Ravnborg <sam@ravnborg.org>
I expect someone else to pick them up or that you apply them.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 0/5] Fix SPI module alias for panels used by omapdrm
2019-10-07 17:22 ` [PATCH 0/5] Fix SPI module alias for panels used by omapdrm Sam Ravnborg
@ 2019-10-07 17:44 ` Laurent Pinchart
2019-10-08 5:24 ` Tomi Valkeinen
1 sibling, 0 replies; 13+ messages in thread
From: Laurent Pinchart @ 2019-10-07 17:44 UTC (permalink / raw)
To: Sam Ravnborg
Cc: linux-omap, Tony Lindgren, H. Nikolaus Schaller, dri-devel,
Tomi Valkeinen, thierry.reding, Jyri Sarha, letux-kernel
Hi Sam,
On Mon, Oct 07, 2019 at 07:22:56PM +0200, Sam Ravnborg wrote:
> Hi Laurent.
> On Mon, Oct 07, 2019 at 08:07:56PM +0300, Laurent Pinchart wrote:
> > Hello,
> >
> > This patch series fixes a module alias issue with the five recently
> > added panel drivers used by omapdrm.
> >
> > Before those panel drivers, omapdrm had custom drivers for the panels,
> > and prefixed the OF compatible strings with an "omapdss," prefix. The
> > SPI device IDs are constructed by stripping the OF compatible string
> > from the prefix, resulting in the "omapdss," prefix being removed, but
> > the subsequence OF vendor prefix being kept. The SPI drivers thus had
> > modules aliases that contained the vendor prefix.
> >
> > Now that the panels are supported by standard drivers and the "omapdss,"
> > prefix is removed, the SPI device IDs are stripped from the OF vendor
> > prefix. As the new panel drivers copied the module aliases from the
> > omapdrm-specific drivers, they contain the vendor prefix in their SPI
> > module aliases, and are thus not loaded automatically.
> >
> > Fix this by removing the vendor prefix from the SPI modules aliases in
> > the drivers. For consistency reason, the manual module aliases are also
> > moved to use an SPI module table.
>
> Good explanation - thanks.
>
> > These patches are based on the drm-misc-fixes branch as they fix v5.4
> > regressions.
> >
> > Laurent Pinchart (5):
> > drm/panel: lg-lb035q02: Fix SPI alias
> > drm/panel: nec-nl8048hl11: Fix SPI alias
> > drm/panel: sony-acx565akm: Fix SPI alias
> > drm/panel: tpo-td028ttec1: Fix SPI alias
> > drm/panel: tpo-td043mtea1: Fix SPI alias
>
> Full series is:
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
>
> I expect someone else to pick them up or that you apply them.
I'd like someone to test the patches first if possible :-) Tomi, could
you then pick these up as v5.4 fixes ?
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 0/5] Fix SPI module alias for panels used by omapdrm
2019-10-07 17:22 ` [PATCH 0/5] Fix SPI module alias for panels used by omapdrm Sam Ravnborg
2019-10-07 17:44 ` Laurent Pinchart
@ 2019-10-08 5:24 ` Tomi Valkeinen
1 sibling, 0 replies; 13+ messages in thread
From: Tomi Valkeinen @ 2019-10-08 5:24 UTC (permalink / raw)
To: Sam Ravnborg, Laurent Pinchart
Cc: linux-omap, Tony Lindgren, H. Nikolaus Schaller, Jyri Sarha,
thierry.reding, dri-devel, letux-kernel
On 07/10/2019 20:22, Sam Ravnborg wrote:
> Hi Laurent.
> On Mon, Oct 07, 2019 at 08:07:56PM +0300, Laurent Pinchart wrote:
>> Hello,
>>
>> This patch series fixes a module alias issue with the five recently
>> added panel drivers used by omapdrm.
>>
>> Before those panel drivers, omapdrm had custom drivers for the panels,
>> and prefixed the OF compatible strings with an "omapdss," prefix. The
>> SPI device IDs are constructed by stripping the OF compatible string
>> from the prefix, resulting in the "omapdss," prefix being removed, but
>> the subsequence OF vendor prefix being kept. The SPI drivers thus had
>> modules aliases that contained the vendor prefix.
>>
>> Now that the panels are supported by standard drivers and the "omapdss,"
>> prefix is removed, the SPI device IDs are stripped from the OF vendor
>> prefix. As the new panel drivers copied the module aliases from the
>> omapdrm-specific drivers, they contain the vendor prefix in their SPI
>> module aliases, and are thus not loaded automatically.
>>
>> Fix this by removing the vendor prefix from the SPI modules aliases in
>> the drivers. For consistency reason, the manual module aliases are also
>> moved to use an SPI module table.
>
> Good explanation - thanks.
>
>>
>> These patches are based on the drm-misc-fixes branch as they fix v5.4
>> regressions.
>>
>> Laurent Pinchart (5):
>> drm/panel: lg-lb035q02: Fix SPI alias
>> drm/panel: nec-nl8048hl11: Fix SPI alias
>> drm/panel: sony-acx565akm: Fix SPI alias
>> drm/panel: tpo-td028ttec1: Fix SPI alias
>> drm/panel: tpo-td043mtea1: Fix SPI alias
>
> Full series is:
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
>
> I expect someone else to pick them up or that you apply them.
Thanks! I've pushed these to drm-misc-fixes.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 0/5] Fix SPI module alias for panels used by omapdrm
2019-10-07 17:07 [PATCH 0/5] Fix SPI module alias for panels used by omapdrm Laurent Pinchart
` (5 preceding siblings ...)
2019-10-07 17:22 ` [PATCH 0/5] Fix SPI module alias for panels used by omapdrm Sam Ravnborg
@ 2019-10-07 17:27 ` Sebastian Reichel
6 siblings, 0 replies; 13+ messages in thread
From: Sebastian Reichel @ 2019-10-07 17:27 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-omap, Tony Lindgren, H. Nikolaus Schaller, dri-devel,
Tomi Valkeinen, thierry.reding, Jyri Sarha, letux-kernel, sam
[-- Attachment #1.1: Type: text/plain, Size: 283 bytes --]
Hi,
On Mon, Oct 07, 2019 at 08:07:56PM +0300, Laurent Pinchart wrote:
> This patch series fixes a module alias issue with the five recently
> added panel drivers used by omapdrm.
For the whole series:
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
-- Sebastian
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread