From: Keith Busch <kbusch@kernel.org>
To: Tyler Ramer <tyaramer@gmail.com>
Cc: Jens Axboe <axboe@fb.com>,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH v2] nvme-pci: Shutdown when removing dead controller
Date: Mon, 7 Oct 2019 12:28:12 -0600 [thread overview]
Message-ID: <20191007182812.GB13149@C02WT3WMHTD6> (raw)
In-Reply-To: <20191007175011.6753-1-tyaramer@gmail.com>
On Mon, Oct 07, 2019 at 01:50:11PM -0400, Tyler Ramer wrote:
> Shutdown the controller when nvme_remove_dead_controller is
> reached.
>
> If nvme_remove_dead_controller() is called, the controller won't
> be comming back online, so we should shut it down rather than just
> disabling.
>
> Remove nvme_kill_queues() as nvme_dev_remove() will take care of
> unquiescing queues.
We do still need to kill the queues, though. The shutdown == true just flushes
all pending requests. Killing queues does that too, but it also sets the
request_queue to dying, which will terminate syncing any dirty pages.
> ---
>
> Changes since v1:
> * Clean up commit message
> * Remove nvme_kill_queues()
> ---
> drivers/nvme/host/pci.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index c0808f9eb8ab..68d5fb880d80 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -2509,8 +2509,7 @@ static void nvme_pci_free_ctrl(struct nvme_ctrl *ctrl)
> static void nvme_remove_dead_ctrl(struct nvme_dev *dev)
> {
> nvme_get_ctrl(&dev->ctrl);
> - nvme_dev_disable(dev, false);
> - nvme_kill_queues(&dev->ctrl);
> + nvme_dev_disable(dev, true);
> if (!queue_work(nvme_wq, &dev->remove_work))
> nvme_put_ctrl(&dev->ctrl);
> }
> --
> 2.23.0
>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <kbusch@kernel.org>
To: Tyler Ramer <tyaramer@gmail.com>
Cc: Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] nvme-pci: Shutdown when removing dead controller
Date: Mon, 7 Oct 2019 12:28:12 -0600 [thread overview]
Message-ID: <20191007182812.GB13149@C02WT3WMHTD6> (raw)
In-Reply-To: <20191007175011.6753-1-tyaramer@gmail.com>
On Mon, Oct 07, 2019 at 01:50:11PM -0400, Tyler Ramer wrote:
> Shutdown the controller when nvme_remove_dead_controller is
> reached.
>
> If nvme_remove_dead_controller() is called, the controller won't
> be comming back online, so we should shut it down rather than just
> disabling.
>
> Remove nvme_kill_queues() as nvme_dev_remove() will take care of
> unquiescing queues.
We do still need to kill the queues, though. The shutdown == true just flushes
all pending requests. Killing queues does that too, but it also sets the
request_queue to dying, which will terminate syncing any dirty pages.
> ---
>
> Changes since v1:
> * Clean up commit message
> * Remove nvme_kill_queues()
> ---
> drivers/nvme/host/pci.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index c0808f9eb8ab..68d5fb880d80 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -2509,8 +2509,7 @@ static void nvme_pci_free_ctrl(struct nvme_ctrl *ctrl)
> static void nvme_remove_dead_ctrl(struct nvme_dev *dev)
> {
> nvme_get_ctrl(&dev->ctrl);
> - nvme_dev_disable(dev, false);
> - nvme_kill_queues(&dev->ctrl);
> + nvme_dev_disable(dev, true);
> if (!queue_work(nvme_wq, &dev->remove_work))
> nvme_put_ctrl(&dev->ctrl);
> }
> --
> 2.23.0
>
next prev parent reply other threads:[~2019-10-07 18:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 19:13 [PATCH] nvme-pci: Shutdown when removing dead controller Tyler Ramer
2019-10-03 19:13 ` Tyler Ramer
2019-10-04 15:36 ` Tyler Ramer
2019-10-04 15:36 ` Tyler Ramer
2019-10-05 2:07 ` Singh, Balbir
2019-10-05 2:07 ` Singh, Balbir
2019-10-05 21:58 ` Tyler Ramer
2019-10-05 21:58 ` Tyler Ramer
2019-10-06 19:21 ` Keith Busch
2019-10-06 19:21 ` Keith Busch
2019-10-07 15:13 ` Tyler Ramer
2019-10-07 15:13 ` Tyler Ramer
2019-10-07 15:44 ` Keith Busch
2019-10-07 15:44 ` Keith Busch
2019-10-07 17:50 ` [PATCH v2] " Tyler Ramer
2019-10-07 17:50 ` Tyler Ramer
2019-10-07 18:28 ` Keith Busch [this message]
2019-10-07 18:28 ` Keith Busch
2019-10-07 19:32 ` Tyler Ramer
2019-10-07 19:32 ` Tyler Ramer
2019-10-07 22:11 ` [PATCH] " Singh, Balbir
2019-10-07 22:11 ` Singh, Balbir
2019-10-11 14:28 ` [PATCH v3] Always shutdown the controller when nvme_remove_dead_ctrl is reached Tyler Ramer
2019-10-11 14:28 ` Tyler Ramer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007182812.GB13149@C02WT3WMHTD6 \
--to=kbusch@kernel.org \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=tyaramer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.