From: Andreas Kemnade <andreas@kemnade.info>
To: Sebastian Reichel <sre@kernel.org>
Cc: thierry.reding@gmail.com, sam@ravnborg.org, airlied@linux.ie,
daniel@ffwll.ch, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
omi Valkeinen <tomi.valkeinen@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Discussions about the Letux Kernel <letux-kernel@openphoenux.org>,
Tony Lindgren <tony@atomide.com>, Jyri Sarha <jsarha@ti.com>,
Linux-OMAP <linux-omap@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] drm: panels: fix spi aliases of former omap panels
Date: Mon, 7 Oct 2019 19:14:28 +0200 [thread overview]
Message-ID: <20191007191428.016ddcd4@aktux> (raw)
In-Reply-To: <20191007170446.yotb24s6jhe6nx3r@earth.universe>
On Mon, 7 Oct 2019 19:04:46 +0200
Sebastian Reichel <sre@kernel.org> wrote:
> Hi,
>
> On Mon, Oct 07, 2019 at 06:41:30PM +0200, Andreas Kemnade wrote:
> > When the panels were moved from omap/displays/ to panel/
> > omapdss prefix was stripped, which cause spi modalias
> > to not contain the vendor-prefix anymore.
> >
> > so we had e.g. in former times:
> > compatible=omapdss,tpo,td028ttec1 -> modalias=spi:tpo,td028ttec1
> > now:
> > compatible=tpo,td028ttec1 -> modalias=spi:td028ttec1
> >
> > This is consistent with other drivers. Tested the td028ttec.c
> > only, but the pattern looks the same for the other ones.
> >
> > Fixes: 45f16c82db7e8 ("drm/omap: displays: Remove unused panel drivers")
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > ---
>
> Patch looks good to me, but you have one false positive.
>
> > [...]
> >
> > diff --git a/drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c b/drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c
> > index 46cd9a2501298..838d39a263f53 100644
> > --- a/drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c
> > +++ b/drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c
> > @@ -204,7 +204,7 @@ static int ls037v7dw01_remove(struct platform_device *pdev)
> > }
> >
> > static const struct of_device_id ls037v7dw01_of_match[] = {
> > - { .compatible = "sharp,ls037v7dw01", },
> > + { .compatible = "ls037v7dw01", },
> > { /* sentinel */ },
> > };
> >
>
> The DT compatible should have a vendor prefix.
>
oops, sorry, but I it seems that Laurent already has submitted a fix.
Regards,
Andreas
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Kemnade <andreas@kemnade.info>
To: Sebastian Reichel <sre@kernel.org>
Cc: Linux-OMAP <linux-omap@vger.kernel.org>,
airlied@linux.ie, omi Valkeinen <tomi.valkeinen@ti.com>,
Jyri Sarha <jsarha@ti.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Tony Lindgren <tony@atomide.com>,
thierry.reding@gmail.com,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
daniel@ffwll.ch,
Discussions about the Letux Kernel <letux-kernel@openphoenux.org>,
sam@ravnborg.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] drm: panels: fix spi aliases of former omap panels
Date: Mon, 7 Oct 2019 19:14:28 +0200 [thread overview]
Message-ID: <20191007191428.016ddcd4@aktux> (raw)
In-Reply-To: <20191007170446.yotb24s6jhe6nx3r@earth.universe>
On Mon, 7 Oct 2019 19:04:46 +0200
Sebastian Reichel <sre@kernel.org> wrote:
> Hi,
>
> On Mon, Oct 07, 2019 at 06:41:30PM +0200, Andreas Kemnade wrote:
> > When the panels were moved from omap/displays/ to panel/
> > omapdss prefix was stripped, which cause spi modalias
> > to not contain the vendor-prefix anymore.
> >
> > so we had e.g. in former times:
> > compatible=omapdss,tpo,td028ttec1 -> modalias=spi:tpo,td028ttec1
> > now:
> > compatible=tpo,td028ttec1 -> modalias=spi:td028ttec1
> >
> > This is consistent with other drivers. Tested the td028ttec.c
> > only, but the pattern looks the same for the other ones.
> >
> > Fixes: 45f16c82db7e8 ("drm/omap: displays: Remove unused panel drivers")
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > ---
>
> Patch looks good to me, but you have one false positive.
>
> > [...]
> >
> > diff --git a/drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c b/drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c
> > index 46cd9a2501298..838d39a263f53 100644
> > --- a/drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c
> > +++ b/drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c
> > @@ -204,7 +204,7 @@ static int ls037v7dw01_remove(struct platform_device *pdev)
> > }
> >
> > static const struct of_device_id ls037v7dw01_of_match[] = {
> > - { .compatible = "sharp,ls037v7dw01", },
> > + { .compatible = "ls037v7dw01", },
> > { /* sentinel */ },
> > };
> >
>
> The DT compatible should have a vendor prefix.
>
oops, sorry, but I it seems that Laurent already has submitted a fix.
Regards,
Andreas
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-07 17:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 16:41 [PATCH] drm: panels: fix spi aliases of former omap panels Andreas Kemnade
2019-10-07 16:41 ` Andreas Kemnade
2019-10-07 17:04 ` Sebastian Reichel
2019-10-07 17:04 ` Sebastian Reichel
2019-10-07 17:14 ` Andreas Kemnade [this message]
2019-10-07 17:14 ` Andreas Kemnade
2019-10-07 17:16 ` Laurent Pinchart
2019-10-07 17:16 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007191428.016ddcd4@aktux \
--to=andreas@kemnade.info \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=sre@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.