All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
	Markus Armbruster <armbru@redhat.com>,
	Damien Hedde <damien.hedde@greensocs.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	qemu-ppc@nongnu.org, John Snow <jsnow@redhat.com>,
	qemu-block@nongnu.org,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Aleksandar Markovic <amarkovic@wavecomp.com>,
	Igor Mammedov <imammedo@redhat.com>,
	BALATON Zoltan <balaton@eik.bme.hu>,
	Andrzej Zaborowski <balrogg@gmail.com>,
	Aleksandar Rikalo <arikalo@wavecomp.com>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [PATCH 00/11] hw: Convert various reset() handler to DeviceReset
Date: Mon, 7 Oct 2019 18:24:06 -0300	[thread overview]
Message-ID: <20191007212406.GU4084@habkost.net> (raw)
In-Reply-To: <9a20b4a9-b255-95e9-1e27-94e294e21042@redhat.com>

On Mon, Oct 07, 2019 at 12:01:54PM +0200, Philippe Mathieu-Daudé wrote:
> Hi Michael,
> 
> On 10/5/19 11:46 PM, Michael S. Tsirkin wrote:
> > On Thu, Sep 26, 2019 at 05:17:22PM +0200, Philippe Mathieu-Daudé wrote:
> > > Hi.
> > > 
> > > Following the thread discussion between Peter/Markus/Damien about
> > > reset handlers:
> > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg617103.html
> > > I started to remove qemu_register_reset() calls from few qdevified
> > > devices (the trivial ones).
> > > 
> > > Regards,
> > > 
> > > Phil.
> > 
> > How do you want these patches merged? Trivial tree?
> 
> I was hoping Eduardo would take them but he is busy and I even forgot to Cc
> him. They might go via Trivial or else via Paolo's Misc...

I can merge them if somebody reviews the series.  How exactly are
we making sure device_reset() is really being called for all
devices touched by this series?  Are all buses guaranteed to be
children of main-system-bus?

> 
> > > Philippe Mathieu-Daudé (11):
> > >    hw/acpi/piix4: Convert reset handler to DeviceReset
> > >    hw/ide/piix: Convert reset handler to DeviceReset
> > >    hw/isa/piix4: Convert reset handler to DeviceReset
> > >    hw/pci-host/piix: Convert reset handler to DeviceReset
> > >    hw/ide/sii3112: Convert reset handler to DeviceReset
> > >    hw/ide/via82c: Convert reset handler to DeviceReset
> > >    hw/isa/vt82c686: Convert reset handler to DeviceReset
> > >    hw/input/lm832x: Convert reset handler to DeviceReset
> > >    hw/pci-host/bonito: Convert reset handler to DeviceReset
> > >    hw/timer/etraxfs: Convert reset handler to DeviceReset
> > >    hw/misc/vmcoreinfo: Convert reset handler to DeviceReset

-- 
Eduardo


WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Habkost <ehabkost@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Damien Hedde <damien.hedde@greensocs.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Aleksandar Markovic <amarkovic@wavecomp.com>,
	qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
	qemu-trivial@nongnu.org, Markus Armbruster <armbru@redhat.com>,
	qemu-devel@nongnu.org, Aleksandar Rikalo <arikalo@wavecomp.com>,
	qemu-ppc@nongnu.org,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	Igor Mammedov <imammedo@redhat.com>, John Snow <jsnow@redhat.com>
Subject: Re: [PATCH 00/11] hw: Convert various reset() handler to DeviceReset
Date: Mon, 7 Oct 2019 18:24:06 -0300	[thread overview]
Message-ID: <20191007212406.GU4084@habkost.net> (raw)
In-Reply-To: <9a20b4a9-b255-95e9-1e27-94e294e21042@redhat.com>

On Mon, Oct 07, 2019 at 12:01:54PM +0200, Philippe Mathieu-Daudé wrote:
> Hi Michael,
> 
> On 10/5/19 11:46 PM, Michael S. Tsirkin wrote:
> > On Thu, Sep 26, 2019 at 05:17:22PM +0200, Philippe Mathieu-Daudé wrote:
> > > Hi.
> > > 
> > > Following the thread discussion between Peter/Markus/Damien about
> > > reset handlers:
> > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg617103.html
> > > I started to remove qemu_register_reset() calls from few qdevified
> > > devices (the trivial ones).
> > > 
> > > Regards,
> > > 
> > > Phil.
> > 
> > How do you want these patches merged? Trivial tree?
> 
> I was hoping Eduardo would take them but he is busy and I even forgot to Cc
> him. They might go via Trivial or else via Paolo's Misc...

I can merge them if somebody reviews the series.  How exactly are
we making sure device_reset() is really being called for all
devices touched by this series?  Are all buses guaranteed to be
children of main-system-bus?

> 
> > > Philippe Mathieu-Daudé (11):
> > >    hw/acpi/piix4: Convert reset handler to DeviceReset
> > >    hw/ide/piix: Convert reset handler to DeviceReset
> > >    hw/isa/piix4: Convert reset handler to DeviceReset
> > >    hw/pci-host/piix: Convert reset handler to DeviceReset
> > >    hw/ide/sii3112: Convert reset handler to DeviceReset
> > >    hw/ide/via82c: Convert reset handler to DeviceReset
> > >    hw/isa/vt82c686: Convert reset handler to DeviceReset
> > >    hw/input/lm832x: Convert reset handler to DeviceReset
> > >    hw/pci-host/bonito: Convert reset handler to DeviceReset
> > >    hw/timer/etraxfs: Convert reset handler to DeviceReset
> > >    hw/misc/vmcoreinfo: Convert reset handler to DeviceReset

-- 
Eduardo


  reply	other threads:[~2019-10-07 21:24 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-26 15:17 [PATCH 00/11] hw: Convert various reset() handler to DeviceReset Philippe Mathieu-Daudé
2019-09-26 15:17 ` Philippe Mathieu-Daudé
2019-09-26 15:17 ` Philippe Mathieu-Daudé
2019-09-26 15:17 ` [PATCH 01/11] hw/acpi/piix4: Convert reset " Philippe Mathieu-Daudé
2019-09-26 15:17   ` Philippe Mathieu-Daudé
2019-10-04 11:32   ` Igor Mammedov
2019-10-04 11:32     ` Igor Mammedov
2019-09-26 15:17 ` [PATCH 02/11] hw/ide/piix: " Philippe Mathieu-Daudé
2019-09-26 15:17   ` Philippe Mathieu-Daudé
2019-09-26 15:17 ` [PATCH 03/11] hw/isa/piix4: " Philippe Mathieu-Daudé
2019-09-26 15:17   ` Philippe Mathieu-Daudé
2019-09-26 15:17 ` [PATCH 04/11] hw/pci-host/piix: " Philippe Mathieu-Daudé
2019-09-26 15:17   ` Philippe Mathieu-Daudé
2019-09-26 15:17 ` [PATCH 05/11] hw/ide/sii3112: " Philippe Mathieu-Daudé
2019-09-26 15:17   ` Philippe Mathieu-Daudé
2019-09-26 15:17 ` [PATCH 06/11] hw/ide/via82c: " Philippe Mathieu-Daudé
2019-09-26 15:17   ` Philippe Mathieu-Daudé
2019-09-26 15:17 ` [PATCH 07/11] hw/isa/vt82c686: " Philippe Mathieu-Daudé
2019-09-26 15:17   ` Philippe Mathieu-Daudé
2019-09-26 15:17 ` [PATCH 08/11] hw/input/lm832x: " Philippe Mathieu-Daudé
2019-09-26 15:17   ` Philippe Mathieu-Daudé
2019-09-26 15:17   ` Philippe Mathieu-Daudé
2019-09-26 15:17 ` [PATCH 09/11] hw/pci-host/bonito: " Philippe Mathieu-Daudé
2019-09-26 15:17   ` Philippe Mathieu-Daudé
2019-09-26 15:17 ` [PATCH 10/11] hw/timer/etraxfs: " Philippe Mathieu-Daudé
2019-09-26 15:17   ` Philippe Mathieu-Daudé
2019-09-26 15:17 ` [PATCH 11/11] hw/misc/vmcoreinfo: " Philippe Mathieu-Daudé
2019-09-26 15:17   ` Philippe Mathieu-Daudé
2019-09-26 16:02   ` Philippe Mathieu-Daudé
2019-09-26 16:02     ` Philippe Mathieu-Daudé
2019-10-08 13:32     ` Eduardo Habkost
2019-10-08 13:32       ` Eduardo Habkost
2019-10-09  9:04       ` Damien Hedde
2019-10-09  9:04         ` Damien Hedde
2019-10-09 13:51     ` Peter Maydell
2019-10-09 13:51       ` Peter Maydell
2019-09-27  8:47 ` [PATCH 00/11] hw: Convert various reset() " no-reply
2019-09-27  8:47   ` no-reply
2019-09-27  8:47   ` no-reply
2019-10-05 21:46 ` Michael S. Tsirkin
2019-10-05 21:46   ` Michael S. Tsirkin
2019-10-05 21:46   ` Michael S. Tsirkin
2019-10-07 10:01   ` Philippe Mathieu-Daudé
2019-10-07 10:01     ` Philippe Mathieu-Daudé
2019-10-07 21:24     ` Eduardo Habkost [this message]
2019-10-07 21:24       ` Eduardo Habkost
2019-10-08  9:47       ` Peter Maydell
2019-10-08  9:47         ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191007212406.GU4084@habkost.net \
    --to=ehabkost@redhat.com \
    --cc=amarkovic@wavecomp.com \
    --cc=arikalo@wavecomp.com \
    --cc=armbru@redhat.com \
    --cc=balaton@eik.bme.hu \
    --cc=balrogg@gmail.com \
    --cc=damien.hedde@greensocs.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=imammedo@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.