* Re: [PATCH] staging: media: sunxi: make use of devm_platform_ioremap_resource [not found] <1570517975-32648-1-git-send-email-hariprasad.kelam@gmail.com> @ 2019-10-08 7:11 ` Paul Kocialkowski 2019-10-08 12:38 ` Greg Kroah-Hartman 1 sibling, 0 replies; 4+ messages in thread From: Paul Kocialkowski @ 2019-10-08 7:11 UTC (permalink / raw) To: hariprasadKelamhariprasad.kelam Cc: devel, Hariprasad Kelam, Greg Kroah-Hartman, linux-kernel, Maxime Ripard, Chen-Yu Tsai, Mauro Carvalho Chehab, linux-arm-kernel, linux-media [-- Attachment #1.1: Type: text/plain, Size: 1578 bytes --] Hi, On Tue 08 Oct 19, 12:29, hariprasadKelamhariprasad.kelam@gmail.com wrote: > From: Hariprasad Kelam <hariprasad.kelam@gmail.com> > > fix below issue reported by coccicheck > drivers/staging//media/sunxi/cedrus/cedrus_hw.c:229:1-10: WARNING: Use > devm_platform_ioremap_resource for dev -> base Looks good, thanks! Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> Cheers, Paul > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> > --- > drivers/staging/media/sunxi/cedrus/cedrus_hw.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c b/drivers/staging/media/sunxi/cedrus/cedrus_hw.c > index a942cd9..f19b87c 100644 > --- a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_hw.c > @@ -146,7 +146,6 @@ static irqreturn_t cedrus_irq(int irq, void *data) > int cedrus_hw_probe(struct cedrus_dev *dev) > { > const struct cedrus_variant *variant; > - struct resource *res; > int irq_dec; > int ret; > > @@ -225,8 +224,7 @@ int cedrus_hw_probe(struct cedrus_dev *dev) > goto err_sram; > } > > - res = platform_get_resource(dev->pdev, IORESOURCE_MEM, 0); > - dev->base = devm_ioremap_resource(dev->dev, res); > + dev->base = devm_platform_ioremap_resource(dev->pdev, 0); > if (IS_ERR(dev->base)) { > dev_err(dev->dev, "Failed to map registers\n"); > > -- > 2.7.4 > -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: media: sunxi: make use of devm_platform_ioremap_resource @ 2019-10-08 7:11 ` Paul Kocialkowski 0 siblings, 0 replies; 4+ messages in thread From: Paul Kocialkowski @ 2019-10-08 7:11 UTC (permalink / raw) To: hariprasadKelamhariprasad.kelam Cc: Hariprasad Kelam, Maxime Ripard, Mauro Carvalho Chehab, Greg Kroah-Hartman, Chen-Yu Tsai, linux-media, devel, linux-arm-kernel, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1578 bytes --] Hi, On Tue 08 Oct 19, 12:29, hariprasadKelamhariprasad.kelam@gmail.com wrote: > From: Hariprasad Kelam <hariprasad.kelam@gmail.com> > > fix below issue reported by coccicheck > drivers/staging//media/sunxi/cedrus/cedrus_hw.c:229:1-10: WARNING: Use > devm_platform_ioremap_resource for dev -> base Looks good, thanks! Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> Cheers, Paul > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> > --- > drivers/staging/media/sunxi/cedrus/cedrus_hw.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c b/drivers/staging/media/sunxi/cedrus/cedrus_hw.c > index a942cd9..f19b87c 100644 > --- a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_hw.c > @@ -146,7 +146,6 @@ static irqreturn_t cedrus_irq(int irq, void *data) > int cedrus_hw_probe(struct cedrus_dev *dev) > { > const struct cedrus_variant *variant; > - struct resource *res; > int irq_dec; > int ret; > > @@ -225,8 +224,7 @@ int cedrus_hw_probe(struct cedrus_dev *dev) > goto err_sram; > } > > - res = platform_get_resource(dev->pdev, IORESOURCE_MEM, 0); > - dev->base = devm_ioremap_resource(dev->dev, res); > + dev->base = devm_platform_ioremap_resource(dev->pdev, 0); > if (IS_ERR(dev->base)) { > dev_err(dev->dev, "Failed to map registers\n"); > > -- > 2.7.4 > -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: media: sunxi: make use of devm_platform_ioremap_resource [not found] <1570517975-32648-1-git-send-email-hariprasad.kelam@gmail.com> @ 2019-10-08 12:38 ` Greg Kroah-Hartman 2019-10-08 12:38 ` Greg Kroah-Hartman 1 sibling, 0 replies; 4+ messages in thread From: Greg Kroah-Hartman @ 2019-10-08 12:38 UTC (permalink / raw) To: hariprasad, Kelam, hariprasad.kelam Cc: devel, linux-kernel, Maxime Ripard, Paul Kocialkowski, Chen-Yu Tsai, Mauro Carvalho Chehab, linux-arm-kernel, linux-media On Tue, Oct 08, 2019 at 12:29:34PM +0530, hariprasad@osuosl.org wrote: > From: Hariprasad Kelam <hariprasad.kelam@gmail.com> > > fix below issue reported by coccicheck > drivers/staging//media/sunxi/cedrus/cedrus_hw.c:229:1-10: WARNING: Use > devm_platform_ioremap_resource for dev -> base > > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> > --- > drivers/staging/media/sunxi/cedrus/cedrus_hw.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) I've dropped all of your patches, please fix up your tool and resend this as a patch series so we know what order to apply them in. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: media: sunxi: make use of devm_platform_ioremap_resource @ 2019-10-08 12:38 ` Greg Kroah-Hartman 0 siblings, 0 replies; 4+ messages in thread From: Greg Kroah-Hartman @ 2019-10-08 12:38 UTC (permalink / raw) To: hariprasad, Kelam, hariprasad.kelam Cc: devel, linux-kernel, Maxime Ripard, Paul Kocialkowski, Chen-Yu Tsai, Mauro Carvalho Chehab, linux-arm-kernel, linux-media On Tue, Oct 08, 2019 at 12:29:34PM +0530, hariprasad@osuosl.org wrote: > From: Hariprasad Kelam <hariprasad.kelam@gmail.com> > > fix below issue reported by coccicheck > drivers/staging//media/sunxi/cedrus/cedrus_hw.c:229:1-10: WARNING: Use > devm_platform_ioremap_resource for dev -> base > > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> > --- > drivers/staging/media/sunxi/cedrus/cedrus_hw.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) I've dropped all of your patches, please fix up your tool and resend this as a patch series so we know what order to apply them in. thanks, greg k-h ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-08 12:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1570517975-32648-1-git-send-email-hariprasad.kelam@gmail.com>
2019-10-08 7:11 ` [PATCH] staging: media: sunxi: make use of devm_platform_ioremap_resource Paul Kocialkowski
2019-10-08 7:11 ` Paul Kocialkowski
2019-10-08 12:38 ` Greg Kroah-Hartman
2019-10-08 12:38 ` Greg Kroah-Hartman
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.