All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Cheng-Yi Chiang <cychiang@chromium.org>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	alsa-devel@alsa-project.org, tzungbi@chromium.org,
	linux-kernel@vger.kernel.org, Stephen Boyd <swboyd@chromium.org>,
	Hung-Te Lin <hungte@chromium.org>,
	sathya.prakash.m.r@intel.com, Mark Brown <broonie@kernel.org>,
	Sean Paul <seanpaul@chromium.org>,
	Shuming Fan <shumingf@realtek.com>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	dgreid@chromium.org, Guenter Roeck <linux@roeck-us.net>
Subject: Re: [alsa-devel] [PATCH v2] firmware: vpd: Add an interface to read VPD value
Date: Tue, 8 Oct 2019 14:06:49 +0200	[thread overview]
Message-ID: <20191008120649.GC2761030@kroah.com> (raw)
In-Reply-To: <20191008101144.39342-1-cychiang@chromium.org>

On Tue, Oct 08, 2019 at 06:11:44PM +0800, Cheng-Yi Chiang wrote:
> Add an interface for other driver to query VPD value.
> This will be used for ASoC machine driver to query calibration
> data stored in VPD for smart amplifier speaker resistor
> calibration.
> 
> The example usage in ASoC machine driver is like:
> 
> #define DSM_CALIB_KEY "dsm_calib"
> static int load_calibration_data(struct cml_card_private *ctx) {
>     char *data = NULL;
>     int ret;
>     u32 value_len;
> 
>     /* Read calibration data from VPD. */
>     ret = vpd_attribute_read(1, DSM_CALIB_KEY,
>                             (u8 **)&data, &value_len);
> 
>     /* Parsing of this string...*/
> }
> 
> 
> Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
> ---

I can't take this patch without a real user of this function in the
kernel tree at the same time.  Please submit it as part of a patch
series with that change as well.

thanks,

greg k-h
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Cheng-Yi Chiang <cychiang@chromium.org>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	Guenter Roeck <linux@roeck-us.net>,
	Hung-Te Lin <hungte@chromium.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Sean Paul <seanpaul@chromium.org>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Mark Brown <broonie@kernel.org>,
	Shuming Fan <shumingf@realtek.com>,
	sathya.prakash.m.r@intel.com,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	dgreid@chromium.org, tzungbi@chromium.org
Subject: Re: [PATCH v2] firmware: vpd: Add an interface to read VPD value
Date: Tue, 8 Oct 2019 14:06:49 +0200	[thread overview]
Message-ID: <20191008120649.GC2761030@kroah.com> (raw)
In-Reply-To: <20191008101144.39342-1-cychiang@chromium.org>

On Tue, Oct 08, 2019 at 06:11:44PM +0800, Cheng-Yi Chiang wrote:
> Add an interface for other driver to query VPD value.
> This will be used for ASoC machine driver to query calibration
> data stored in VPD for smart amplifier speaker resistor
> calibration.
> 
> The example usage in ASoC machine driver is like:
> 
> #define DSM_CALIB_KEY "dsm_calib"
> static int load_calibration_data(struct cml_card_private *ctx) {
>     char *data = NULL;
>     int ret;
>     u32 value_len;
> 
>     /* Read calibration data from VPD. */
>     ret = vpd_attribute_read(1, DSM_CALIB_KEY,
>                             (u8 **)&data, &value_len);
> 
>     /* Parsing of this string...*/
> }
> 
> 
> Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
> ---

I can't take this patch without a real user of this function in the
kernel tree at the same time.  Please submit it as part of a patch
series with that change as well.

thanks,

greg k-h

  reply	other threads:[~2019-10-08 12:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-08 10:11 [alsa-devel] [PATCH v2] firmware: vpd: Add an interface to read VPD value Cheng-Yi Chiang
2019-10-08 10:11 ` Cheng-Yi Chiang
2019-10-08 12:06 ` Greg Kroah-Hartman [this message]
2019-10-08 12:06   ` Greg Kroah-Hartman
2019-10-08 12:10   ` [alsa-devel] " Cheng-yi Chiang
2019-10-08 12:10     ` Cheng-yi Chiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191008120649.GC2761030@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=cychiang@chromium.org \
    --cc=dgreid@chromium.org \
    --cc=hungte@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=sathya.prakash.m.r@intel.com \
    --cc=seanpaul@chromium.org \
    --cc=shumingf@realtek.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=swboyd@chromium.org \
    --cc=tzungbi@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.