From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Maciej Falkowski <m.falkowski@samsung.com>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
David Airlie <airlied@linux.ie>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Kukjin Kim <kgene@kernel.org>, Lee Jones <lee.jones@linaro.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 1/3] dt-bindings: arm: samsung: Force clkoutN names to be unique in PMU
Date: Tue, 8 Oct 2019 14:50:38 +0200 [thread overview]
Message-ID: <20191008125038.GA2550@pi3> (raw)
In-Reply-To: <CAL_JsqJDTcHu5oXG6zszGHCBhTE6EW94AANUjyMV78SkKcn5yA@mail.gmail.com>
On Tue, Oct 08, 2019 at 07:38:14AM -0500, Rob Herring wrote:
> On Fri, Oct 4, 2019 at 10:14 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > The clkoutN names of clocks must be unique because they represent
> > unique inputs of clock multiplexer.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > Documentation/devicetree/bindings/arm/samsung/pmu.yaml | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml
> > index 73b56fc5bf58..d8e03716f5d2 100644
> > --- a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml
> > +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml
> > @@ -53,8 +53,10 @@ properties:
> > List of clock names for particular CLKOUT mux inputs
> > minItems: 1
> > maxItems: 32
> > - items:
> > - pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$'
> > + allOf:
> > + - items:
> > + pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$'
> > + - uniqueItems: true
>
> You shouldn't need the 'allOf', just add uniqueItems at the same level as items.
If you mean something like:
56 uniqueItems: true
57 items:
58 pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$'
Then the dt_binding_check fails:
dev/linux/Documentation/devicetree/bindings/arm/samsung/pmu.yaml: properties:clock-names:
'uniqueItems' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'type', 'typeSize', 'unevaluatedProperties']
Best regards,
Krzysztof
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Kukjin Kim <kgene@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Lee Jones <lee.jones@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Maciej Falkowski <m.falkowski@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: arm: samsung: Force clkoutN names to be unique in PMU
Date: Tue, 8 Oct 2019 14:50:38 +0200 [thread overview]
Message-ID: <20191008125038.GA2550@pi3> (raw)
Message-ID: <20191008125038.VyaGBG_6z_fidCtQpvAOlM4mZD0wDaFIvAw-QEfvUdI@z> (raw)
In-Reply-To: <CAL_JsqJDTcHu5oXG6zszGHCBhTE6EW94AANUjyMV78SkKcn5yA@mail.gmail.com>
On Tue, Oct 08, 2019 at 07:38:14AM -0500, Rob Herring wrote:
> On Fri, Oct 4, 2019 at 10:14 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > The clkoutN names of clocks must be unique because they represent
> > unique inputs of clock multiplexer.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > Documentation/devicetree/bindings/arm/samsung/pmu.yaml | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml
> > index 73b56fc5bf58..d8e03716f5d2 100644
> > --- a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml
> > +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml
> > @@ -53,8 +53,10 @@ properties:
> > List of clock names for particular CLKOUT mux inputs
> > minItems: 1
> > maxItems: 32
> > - items:
> > - pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$'
> > + allOf:
> > + - items:
> > + pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$'
> > + - uniqueItems: true
>
> You shouldn't need the 'allOf', just add uniqueItems at the same level as items.
If you mean something like:
56 uniqueItems: true
57 items:
58 pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$'
Then the dt_binding_check fails:
dev/linux/Documentation/devicetree/bindings/arm/samsung/pmu.yaml: properties:clock-names:
'uniqueItems' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'type', 'typeSize', 'unevaluatedProperties']
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Maciej Falkowski <m.falkowski@samsung.com>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
David Airlie <airlied@linux.ie>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Kukjin Kim <kgene@kernel.org>, Daniel Vetter <daniel@ffwll.ch>,
Lee Jones <lee.jones@linaro.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 1/3] dt-bindings: arm: samsung: Force clkoutN names to be unique in PMU
Date: Tue, 8 Oct 2019 14:50:38 +0200 [thread overview]
Message-ID: <20191008125038.GA2550@pi3> (raw)
In-Reply-To: <CAL_JsqJDTcHu5oXG6zszGHCBhTE6EW94AANUjyMV78SkKcn5yA@mail.gmail.com>
On Tue, Oct 08, 2019 at 07:38:14AM -0500, Rob Herring wrote:
> On Fri, Oct 4, 2019 at 10:14 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > The clkoutN names of clocks must be unique because they represent
> > unique inputs of clock multiplexer.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > Documentation/devicetree/bindings/arm/samsung/pmu.yaml | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml
> > index 73b56fc5bf58..d8e03716f5d2 100644
> > --- a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml
> > +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml
> > @@ -53,8 +53,10 @@ properties:
> > List of clock names for particular CLKOUT mux inputs
> > minItems: 1
> > maxItems: 32
> > - items:
> > - pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$'
> > + allOf:
> > + - items:
> > + pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$'
> > + - uniqueItems: true
>
> You shouldn't need the 'allOf', just add uniqueItems at the same level as items.
If you mean something like:
56 uniqueItems: true
57 items:
58 pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$'
Then the dt_binding_check fails:
dev/linux/Documentation/devicetree/bindings/arm/samsung/pmu.yaml: properties:clock-names:
'uniqueItems' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'type', 'typeSize', 'unevaluatedProperties']
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-08 12:50 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 15:14 [PATCH 1/3] dt-bindings: arm: samsung: Force clkoutN names to be unique in PMU Krzysztof Kozlowski
2019-10-04 15:14 ` Krzysztof Kozlowski
2019-10-04 15:14 ` [PATCH 2/3] dt-bindings: gpu: samsung-rotator: Fix indentation Krzysztof Kozlowski
2019-10-04 15:14 ` Krzysztof Kozlowski
2019-10-15 19:26 ` Rob Herring
2019-10-15 19:26 ` Rob Herring
2019-10-15 19:26 ` Rob Herring
2019-10-04 15:14 ` [PATCH 3/3] dt-bindings: serial: Convert Samsung UART bindings to json-schema Krzysztof Kozlowski
2019-10-04 15:14 ` Krzysztof Kozlowski
2019-10-04 15:14 ` Krzysztof Kozlowski
2019-10-15 19:40 ` Rob Herring
2019-10-15 19:40 ` Rob Herring
2019-11-03 15:56 ` Krzysztof Kozlowski
2019-11-03 15:56 ` Krzysztof Kozlowski
2019-11-03 15:56 ` Krzysztof Kozlowski
2019-10-08 12:38 ` [PATCH 1/3] dt-bindings: arm: samsung: Force clkoutN names to be unique in PMU Rob Herring
2019-10-08 12:38 ` Rob Herring
2019-10-08 12:50 ` Krzysztof Kozlowski [this message]
2019-10-08 12:50 ` Krzysztof Kozlowski
2019-10-08 12:50 ` Krzysztof Kozlowski
2019-10-08 14:05 ` Rob Herring
2019-10-08 14:05 ` Rob Herring
2019-10-08 14:17 ` Rob Herring
2019-10-08 14:17 ` Rob Herring
2019-10-08 14:17 ` Rob Herring
2019-10-08 14:29 ` Krzysztof Kozlowski
2019-10-08 14:29 ` Krzysztof Kozlowski
2019-10-08 14:29 ` Krzysztof Kozlowski
2019-10-08 14:38 ` Rob Herring
2019-10-08 14:38 ` Rob Herring
2019-10-08 15:04 ` Krzysztof Kozlowski
2019-10-08 15:04 ` Krzysztof Kozlowski
2019-10-08 15:10 ` Krzysztof Kozlowski
2019-10-08 15:10 ` Krzysztof Kozlowski
2019-10-08 15:10 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008125038.GA2550@pi3 \
--to=krzk@kernel.org \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=kgene@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=m.falkowski@samsung.com \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.