From: Florian Westphal <fw at strlen.de>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: Yet another rebase/squash/cleanup proposal
Date: Tue, 08 Oct 2019 17:27:42 +0200 [thread overview]
Message-ID: <20191008152742.GF25052@breakpoint.cc> (raw)
In-Reply-To: d95768b5-b8e4-5bae-70c5-2534bca6119a@tessares.net
[-- Attachment #1: Type: text/plain, Size: 1454 bytes --]
Matthieu Baerts <matthieu.baerts(a)tessares.net> wrote:
> On 08/10/2019 16:48, Florian Westphal wrote:
> > Here is yet another rebase proposal, I've pushed it here:
> > https://git.breakpoint.cc/cgit/fw/mptcp-next.git/log/?h=export_sendmsg_rebase_13
> >
> > Its also accessible via
> > git fetch git://git.breakpoint.cc/fw/mptcp-next.git export_sendmsg_rebase_13
> >
> > In short:
> > - folds two commits
> > - fixes the kbuild warnings we got with rfcv2
> > - gets rid of refcounting in mptcp_subflow_get_ref
>
> Wow, thanks for the work!
>
> Can I re-create the TopGit tree with that? I guess Paolo has already
> reviewed the changes, right?
No, Paolo hasn't reviewed them. He suggested the refcount change
and to check if it helps to squash sendmsg refactor patches,
but he did not review this yet.
> [...]
>
> > Full diff of current export (ab35f6c5d8e3ed7a3c9603028d3b67c931af51b0)
> > and this branch:
>
> I guess you mean 0c6f4f183e22dcd15d76ae5779f42e1737c26ddd (tag:
> export/20191008T114531). The one you mention (tag:
> export/20191008T010618) is the version from last night, before my rebase
> I did today.
Oh, indeed, its 0c6f4f183e22dcd15d76ae5779f42e1737c26ddd.
> I just checked and I don't see "tcp: Expose tcp struct and routine for
> MPTCP" and your version of "tcp: Export TCP functions and ops struct"
> seems OK! All good then :)
Yes, I forgot to update the sha1 in my email template.
next reply other threads:[~2019-10-08 15:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 15:27 Florian Westphal [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-10-09 7:43 [MPTCP] Re: Yet another rebase/squash/cleanup proposal Matthieu Baerts
2019-10-09 7:42 Paolo Abeni
2019-10-08 23:33 Mat Martineau
2019-10-08 15:30 Matthieu Baerts
2019-10-08 15:28 Paolo Abeni
2019-10-08 15:20 Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008152742.GF25052@breakpoint.cc \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.