[MPTCP] Re: Yet another rebase/squash/cleanup proposal

[MPTCP] Re: Yet another rebase/squash/cleanup proposal

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 1282 bytes --]

Hi Florian,

On 08/10/2019 16:48, Florian Westphal wrote:
> Hi.
> 
> Here is yet another rebase proposal, I've pushed it here:
> https://git.breakpoint.cc/cgit/fw/mptcp-next.git/log/?h=export_sendmsg_rebase_13
> 
> Its also accessible via
> git fetch git://git.breakpoint.cc/fw/mptcp-next.git export_sendmsg_rebase_13
> 
> In short:
> - folds two commits
> - fixes the kbuild warnings we got with rfcv2
> - gets rid of refcounting in mptcp_subflow_get_ref

Wow, thanks for the work!

Can I re-create the TopGit tree with that? I guess Paolo has already
reviewed the changes, right?

[...]

> Full diff of current export (ab35f6c5d8e3ed7a3c9603028d3b67c931af51b0)
> and this branch:

I guess you mean 0c6f4f183e22dcd15d76ae5779f42e1737c26ddd (tag:
export/20191008T114531). The one you mention (tag:
export/20191008T010618) is the version from last night, before my rebase
I did today.

I just checked and I don't see "tcp: Expose tcp struct and routine for
MPTCP" and your version of "tcp: Export TCP functions and ops struct"
seems OK! All good then :)

Cheers,
Matt
-- 
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium

[MPTCP] Re: Yet another rebase/squash/cleanup proposal

[Florian Westphal]

[-- Attachment #1: Type: text/plain, Size: 1454 bytes --]

Matthieu Baerts <matthieu.baerts(a)tessares.net> wrote:
> On 08/10/2019 16:48, Florian Westphal wrote:
> > Here is yet another rebase proposal, I've pushed it here:
> > https://git.breakpoint.cc/cgit/fw/mptcp-next.git/log/?h=export_sendmsg_rebase_13
> > 
> > Its also accessible via
> > git fetch git://git.breakpoint.cc/fw/mptcp-next.git export_sendmsg_rebase_13
> > 
> > In short:
> > - folds two commits
> > - fixes the kbuild warnings we got with rfcv2
> > - gets rid of refcounting in mptcp_subflow_get_ref
> 
> Wow, thanks for the work!
> 
> Can I re-create the TopGit tree with that? I guess Paolo has already
> reviewed the changes, right?

No, Paolo hasn't reviewed them. He suggested the refcount change
and to check if it helps to squash sendmsg refactor patches,
but he did not review this yet.

> [...]
> 
> > Full diff of current export (ab35f6c5d8e3ed7a3c9603028d3b67c931af51b0)
> > and this branch:
> 
> I guess you mean 0c6f4f183e22dcd15d76ae5779f42e1737c26ddd (tag:
> export/20191008T114531). The one you mention (tag:
> export/20191008T010618) is the version from last night, before my rebase
> I did today.

Oh, indeed, its 0c6f4f183e22dcd15d76ae5779f42e1737c26ddd.

> I just checked and I don't see "tcp: Expose tcp struct and routine for
> MPTCP" and your version of "tcp: Export TCP functions and ops struct"
> seems OK! All good then :)

Yes, I forgot to update the sha1 in my email template.

[MPTCP] Re: Yet another rebase/squash/cleanup proposal

[Paolo Abeni]

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

On Tue, 2019-10-08 at 17:20 +0200, Matthieu Baerts wrote:
> Hi Florian,
> 
> On 08/10/2019 16:48, Florian Westphal wrote:
> > Hi.
> > 
> > Here is yet another rebase proposal, I've pushed it here:
> > https://git.breakpoint.cc/cgit/fw/mptcp-next.git/log/?h=export_sendmsg_rebase_13
> > 
> > Its also accessible via
> > git fetch git://git.breakpoint.cc/fw/mptcp-next.git export_sendmsg_rebase_13
> > 
> > In short:
> > - folds two commits
> > - fixes the kbuild warnings we got with rfcv2
> > - gets rid of refcounting in mptcp_subflow_get_ref
> 
> Wow, thanks for the work!
> 
> Can I re-create the TopGit tree with that? I guess Paolo has already
> reviewed the changes, right?

I'm still reviewing it. So far so good. I will add an explicit ack here
when completed.

Cheers,

Paolo

[MPTCP] Re: Yet another rebase/squash/cleanup proposal

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 1876 bytes --]

Hi Florian, Paolo,

On 08/10/2019 17:27, Florian Westphal wrote:
> Matthieu Baerts <matthieu.baerts(a)tessares.net> wrote:
>> On 08/10/2019 16:48, Florian Westphal wrote:
>>> Here is yet another rebase proposal, I've pushed it here:
>>> https://git.breakpoint.cc/cgit/fw/mptcp-next.git/log/?h=export_sendmsg_rebase_13
>>>
>>> Its also accessible via
>>> git fetch git://git.breakpoint.cc/fw/mptcp-next.git export_sendmsg_rebase_13
>>>
>>> In short:
>>> - folds two commits
>>> - fixes the kbuild warnings we got with rfcv2
>>> - gets rid of refcounting in mptcp_subflow_get_ref
>>
>> Wow, thanks for the work!
>>
>> Can I re-create the TopGit tree with that? I guess Paolo has already
>> reviewed the changes, right?
> 
> No, Paolo hasn't reviewed them. He suggested the refcount change
> and to check if it helps to squash sendmsg refactor patches,
> but he did not review this yet.

OK thank you for the clarification.
I will recreate the tree after Paolo's ACK.

>> [...]
>>
>>> Full diff of current export (ab35f6c5d8e3ed7a3c9603028d3b67c931af51b0)
>>> and this branch:
>>
>> I guess you mean 0c6f4f183e22dcd15d76ae5779f42e1737c26ddd (tag:
>> export/20191008T114531). The one you mention (tag:
>> export/20191008T010618) is the version from last night, before my rebase
>> I did today.
> 
> Oh, indeed, its 0c6f4f183e22dcd15d76ae5779f42e1737c26ddd.
> 
>> I just checked and I don't see "tcp: Expose tcp struct and routine for
>> MPTCP" and your version of "tcp: Export TCP functions and ops struct"
>> seems OK! All good then :)
> 
> Yes, I forgot to update the sha1 in my email template.

All good, thank you for having checked!

Cheers,
Matt
-- 
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium

[MPTCP] Re: Yet another rebase/squash/cleanup proposal

[Mat Martineau]

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]


On Tue, 8 Oct 2019, Florian Westphal wrote:

> Hi.
>
> Here is yet another rebase proposal, I've pushed it here:
> https://git.breakpoint.cc/cgit/fw/mptcp-next.git/log/?h=export_sendmsg_rebase_13
>
> Its also accessible via
> git fetch git://git.breakpoint.cc/fw/mptcp-next.git export_sendmsg_rebase_13
>
> In short:
> - folds two commits
> - fixes the kbuild warnings we got with rfcv2
> - gets rid of refcounting in mptcp_subflow_get_ref
>
> A full diff between export and this new branch is below.
>

Florian -

Thanks for updating the patch series. The refcounting change makes sense 
to me, and I don't see any code issues.

I pushed the branch to my repo to trigger an automated kbuild, and will 
share the results if any errors are generated.

--
Mat Martineau
Intel

[MPTCP] Re: Yet another rebase/squash/cleanup proposal

[Paolo Abeni]

[-- Attachment #1: Type: text/plain, Size: 964 bytes --]

On Tue, 2019-10-08 at 17:28 +0200, Paolo Abeni wrote:
> On Tue, 2019-10-08 at 17:20 +0200, Matthieu Baerts wrote:
> > Hi Florian,
> > 
> > On 08/10/2019 16:48, Florian Westphal wrote:
> > > Hi.
> > > 
> > > Here is yet another rebase proposal, I've pushed it here:
> > > https://git.breakpoint.cc/cgit/fw/mptcp-next.git/log/?h=export_sendmsg_rebase_13
> > > 
> > > Its also accessible via
> > > git fetch git://git.breakpoint.cc/fw/mptcp-next.git export_sendmsg_rebase_13
> > > 
> > > In short:
> > > - folds two commits
> > > - fixes the kbuild warnings we got with rfcv2
> > > - gets rid of refcounting in mptcp_subflow_get_ref
> > 
> > Wow, thanks for the work!
> > 
> > Can I re-create the TopGit tree with that? I guess Paolo has already
> > reviewed the changes, right?
> 
> I'm still reviewing it. So far so good. I will add an explicit ack here
> when completed.

The squash LGTM,

refcount changes look good and correct

/P

[MPTCP] Re: Yet another rebase/squash/cleanup proposal

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]

Hi Paolo,

On 09/10/2019 09:42, Paolo Abeni wrote:
> On Tue, 2019-10-08 at 17:28 +0200, Paolo Abeni wrote:
>> On Tue, 2019-10-08 at 17:20 +0200, Matthieu Baerts wrote:
>>> Hi Florian,
>>>
>>> On 08/10/2019 16:48, Florian Westphal wrote:
>>>> Hi.
>>>>
>>>> Here is yet another rebase proposal, I've pushed it here:
>>>> https://git.breakpoint.cc/cgit/fw/mptcp-next.git/log/?h=export_sendmsg_rebase_13
>>>>
>>>> Its also accessible via
>>>> git fetch git://git.breakpoint.cc/fw/mptcp-next.git export_sendmsg_rebase_13
>>>>
>>>> In short:
>>>> - folds two commits
>>>> - fixes the kbuild warnings we got with rfcv2
>>>> - gets rid of refcounting in mptcp_subflow_get_ref
>>>
>>> Wow, thanks for the work!
>>>
>>> Can I re-create the TopGit tree with that? I guess Paolo has already
>>> reviewed the changes, right?
>>
>> I'm still reviewing it. So far so good. I will add an explicit ack here
>> when completed.
> 
> The squash LGTM,
> 
> refcount changes look good and correct

Thank you for your review!

Cheers,
Matt
-- 
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium