From: Jason Gunthorpe <jgg@ziepe.ca>
To: Adit Ranadive <aditr@vmware.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Bryan Tan <bryantan@vmware.com>,
Pv-drivers <Pv-drivers@vmware.com>
Subject: Re: [PATCH for-next v1] RDMA/vmw_pvrdma: Use resource ids from physical device if available
Date: Tue, 8 Oct 2019 15:15:44 -0300 [thread overview]
Message-ID: <20191008181544.GA2880@ziepe.ca> (raw)
In-Reply-To: <1568924678-16356-1-git-send-email-aditr@vmware.com>
On Thu, Sep 19, 2019 at 08:24:56PM +0000, Adit Ranadive wrote:
>
> + if (!qp->is_kernel) {
> + if (ucmd.flags == PVRDMA_USER_QP_CREATE_USE_RESP) {
Why does this flag exist? Don't old userspaces pass in a 0 length?
Just use the length to signal new userspace?
> + qp_resp.qpn = qp->ibqp.qp_num;
> + qp_resp.qp_handle = qp->qp_handle;
> + qp_resp.qpn_valid = PVRDMA_USER_QP_CREATE_USE_RESP;
> +
> + if (ib_copy_to_udata(udata, &qp_resp,
> + sizeof(qp_resp))) {
This should limit the copy size to the length of the user buffer
Jason
next prev parent reply other threads:[~2019-10-08 18:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 20:24 [PATCH for-next v1] RDMA/vmw_pvrdma: Use resource ids from physical device if available Adit Ranadive
2019-10-08 18:15 ` Jason Gunthorpe [this message]
2019-10-12 7:03 ` Adit Ranadive
2019-10-15 17:06 ` Jason Gunthorpe
2019-10-15 17:16 ` Adit Ranadive
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008181544.GA2880@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=Pv-drivers@vmware.com \
--cc=aditr@vmware.com \
--cc=bryantan@vmware.com \
--cc=dledford@redhat.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.