Re: [PATCH for-next v1] RDMA/vmw_pvrdma: Use resource ids from physical device if available

[Jason Gunthorpe <jgg@ziepe.ca>]

On Sat, Oct 12, 2019 at 07:03:55AM +0000, Adit Ranadive wrote:
> On 10/8/19, 11:15 AM, "Jason Gunthorpe" <jgg@ziepe.ca> wrote:
> > 
> > On Thu, Sep 19, 2019 at 08:24:56PM +0000, Adit Ranadive wrote:
> > 
> > >  
> > > +	if (!qp->is_kernel) {
> > > +		if (ucmd.flags == PVRDMA_USER_QP_CREATE_USE_RESP) {
> > 
> > Why does this flag exist? Don't old userspaces pass in a 0 length?
> > Just use the length to signal new userspace?
> 
> I did have that in an earlier version but we decided it to make it more
> explicit. It would be easier to add another flag later on if required
> than to check the length (which might be same).

You should add a flag if either the length or detecting value == 0 is
not sufficient to detect the new support. No reason to add things
until this situation comes up

Jason