From: Brendan Higgins <brendanhiggins@google.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH 3/5] i2c: aspeed: fix master pending state handling
Date: Tue, 8 Oct 2019 13:31:57 -0700 [thread overview]
Message-ID: <20191008203157.GA184092@google.com> (raw)
In-Reply-To: <20191007231313.4700-4-jae.hyun.yoo@linux.intel.com>
On Mon, Oct 07, 2019 at 04:13:11PM -0700, Jae Hyun Yoo wrote:
> In case of master pending state, it should not trigger the master
> command because this H/W is sharing the same data buffer for slave
> and master operations, so this commit fixes the issue with making
> the master command triggering happen when the state goes to active
> state.
nit: Makes sense, but can you explain what might happen without your
change?
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Brendan Higgins <brendanhiggins@google.com>
To: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
Andrew Jeffery <andrew@aj.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
openbmc@lists.ozlabs.org, Rob Herring <robh+dt@kernel.org>,
Joel Stanley <joel@jms.id.au>, Tao Ren <taoren@fb.com>,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH 3/5] i2c: aspeed: fix master pending state handling
Date: Tue, 8 Oct 2019 13:31:57 -0700 [thread overview]
Message-ID: <20191008203157.GA184092@google.com> (raw)
In-Reply-To: <20191007231313.4700-4-jae.hyun.yoo@linux.intel.com>
On Mon, Oct 07, 2019 at 04:13:11PM -0700, Jae Hyun Yoo wrote:
> In case of master pending state, it should not trigger the master
> command because this H/W is sharing the same data buffer for slave
> and master operations, so this commit fixes the issue with making
> the master command triggering happen when the state goes to active
> state.
nit: Makes sense, but can you explain what might happen without your
change?
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Brendan Higgins <brendanhiggins@google.com>
To: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Joel Stanley <joel@jms.id.au>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Andrew Jeffery <andrew@aj.id.au>, Tao Ren <taoren@fb.com>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org
Subject: Re: [PATCH 3/5] i2c: aspeed: fix master pending state handling
Date: Tue, 8 Oct 2019 13:31:57 -0700 [thread overview]
Message-ID: <20191008203157.GA184092@google.com> (raw)
In-Reply-To: <20191007231313.4700-4-jae.hyun.yoo@linux.intel.com>
On Mon, Oct 07, 2019 at 04:13:11PM -0700, Jae Hyun Yoo wrote:
> In case of master pending state, it should not trigger the master
> command because this H/W is sharing the same data buffer for slave
> and master operations, so this commit fixes the issue with making
> the master command triggering happen when the state goes to active
> state.
nit: Makes sense, but can you explain what might happen without your
change?
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Brendan Higgins <brendanhiggins@google.com>
To: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
Andrew Jeffery <andrew@aj.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
openbmc@lists.ozlabs.org, Rob Herring <robh+dt@kernel.org>,
Joel Stanley <joel@jms.id.au>, Tao Ren <taoren@fb.com>,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH 3/5] i2c: aspeed: fix master pending state handling
Date: Tue, 8 Oct 2019 13:31:57 -0700 [thread overview]
Message-ID: <20191008203157.GA184092@google.com> (raw)
In-Reply-To: <20191007231313.4700-4-jae.hyun.yoo@linux.intel.com>
On Mon, Oct 07, 2019 at 04:13:11PM -0700, Jae Hyun Yoo wrote:
> In case of master pending state, it should not trigger the master
> command because this H/W is sharing the same data buffer for slave
> and master operations, so this commit fixes the issue with making
> the master command triggering happen when the state goes to active
> state.
nit: Makes sense, but can you explain what might happen without your
change?
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-08 20:31 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 23:13 [PATCH 0/5] i2c: aspeed: Add buffer and DMA modes support Jae Hyun Yoo
2019-10-07 23:13 ` Jae Hyun Yoo
2019-10-07 23:13 ` Jae Hyun Yoo
2019-10-07 23:13 ` Jae Hyun Yoo
2019-10-07 23:13 ` [PATCH 1/5] dt-bindings: i2c: aspeed: add buffer and DMA mode transfer support Jae Hyun Yoo
2019-10-07 23:13 ` Jae Hyun Yoo
2019-10-07 23:13 ` Jae Hyun Yoo
2019-10-07 23:13 ` Jae Hyun Yoo
2019-10-08 18:12 ` Brendan Higgins
2019-10-08 18:12 ` Brendan Higgins
2019-10-08 18:12 ` Brendan Higgins
2019-10-08 18:12 ` Brendan Higgins
2019-10-08 18:47 ` Jae Hyun Yoo
2019-10-08 18:47 ` Jae Hyun Yoo
2019-10-08 18:47 ` Jae Hyun Yoo
2019-10-08 18:47 ` Jae Hyun Yoo
2019-10-07 23:13 ` [PATCH 2/5] ARM: dts: aspeed: add I2C buffer mode support Jae Hyun Yoo
2019-10-07 23:13 ` Jae Hyun Yoo
2019-10-07 23:13 ` Jae Hyun Yoo
2019-10-07 23:13 ` Jae Hyun Yoo
2019-10-09 13:32 ` Cédric Le Goater
2019-10-09 13:32 ` Cédric Le Goater
2019-10-09 13:32 ` Cédric Le Goater
2019-10-07 23:13 ` [PATCH 3/5] i2c: aspeed: fix master pending state handling Jae Hyun Yoo
2019-10-07 23:13 ` Jae Hyun Yoo
2019-10-07 23:13 ` Jae Hyun Yoo
2019-10-07 23:13 ` Jae Hyun Yoo
2019-10-08 20:31 ` Brendan Higgins [this message]
2019-10-08 20:31 ` Brendan Higgins
2019-10-08 20:31 ` Brendan Higgins
2019-10-08 20:31 ` Brendan Higgins
2019-10-08 21:13 ` Jae Hyun Yoo
2019-10-08 21:13 ` Jae Hyun Yoo
2019-10-08 21:13 ` Jae Hyun Yoo
2019-10-08 21:13 ` Jae Hyun Yoo
2019-10-08 21:54 ` Brendan Higgins
2019-10-08 21:54 ` Brendan Higgins
2019-10-08 21:54 ` Brendan Higgins
2019-10-08 21:54 ` Brendan Higgins
2019-10-08 22:55 ` Jae Hyun Yoo
2019-10-08 22:55 ` Jae Hyun Yoo
2019-10-08 22:55 ` Jae Hyun Yoo
2019-10-08 22:55 ` Jae Hyun Yoo
2019-10-10 5:28 ` Joel Stanley
2019-10-10 5:28 ` Joel Stanley
2019-10-10 5:28 ` Joel Stanley
2019-10-10 5:28 ` Joel Stanley
2019-10-08 22:00 ` Tao Ren
2019-10-08 22:00 ` Tao Ren
2019-10-08 22:00 ` Tao Ren
2019-10-08 22:00 ` Tao Ren
2019-10-08 22:45 ` Jae Hyun Yoo
2019-10-08 22:45 ` Jae Hyun Yoo
2019-10-08 22:45 ` Jae Hyun Yoo
2019-10-08 22:45 ` Jae Hyun Yoo
2019-10-08 23:15 ` Tao Ren
2019-10-08 23:15 ` Tao Ren
2019-10-08 23:15 ` Tao Ren
2019-10-08 23:28 ` Jae Hyun Yoo
2019-10-08 23:28 ` Jae Hyun Yoo
2019-10-08 23:28 ` Jae Hyun Yoo
2019-10-07 23:13 ` [PATCH 4/5] i2c: aspeed: add buffer mode transfer support Jae Hyun Yoo
2019-10-07 23:13 ` Jae Hyun Yoo
2019-10-07 23:13 ` Jae Hyun Yoo
2019-10-07 23:13 ` Jae Hyun Yoo
2019-10-08 20:12 ` Brendan Higgins
2019-10-08 20:12 ` Brendan Higgins
2019-10-08 20:12 ` Brendan Higgins
2019-10-08 20:12 ` Brendan Higgins
2019-10-08 21:10 ` Jae Hyun Yoo
2019-10-08 21:10 ` Jae Hyun Yoo
2019-10-08 21:10 ` Jae Hyun Yoo
2019-10-08 21:10 ` Jae Hyun Yoo
2019-10-08 23:15 ` Brendan Higgins
2019-10-08 23:15 ` Brendan Higgins
2019-10-08 23:15 ` Brendan Higgins
2019-10-08 23:15 ` Brendan Higgins
2019-10-09 0:08 ` Jae Hyun Yoo
2019-10-09 0:08 ` Jae Hyun Yoo
2019-10-09 0:08 ` Jae Hyun Yoo
2019-10-09 0:08 ` Jae Hyun Yoo
2019-10-07 23:13 ` [PATCH 5/5] i2c: aspeed: add DMA " Jae Hyun Yoo
2019-10-07 23:13 ` Jae Hyun Yoo
2019-10-07 23:13 ` Jae Hyun Yoo
2019-10-07 23:13 ` Jae Hyun Yoo
2019-10-10 8:20 ` [PATCH 0/5] i2c: aspeed: Add buffer and DMA modes support Cédric Le Goater
2019-10-10 18:14 ` Jae Hyun Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008203157.GA184092@google.com \
--to=brendanhiggins@google.com \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.