From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: Re: [RFC PATCH V3 2/2] scsi: core: don't limit per-LUN queue depth for SSD
Date: Wed, 09 Oct 2019 11:29:06 +0300 [thread overview]
Message-ID: <20191009082321.GA13048@kadam> (raw)
In-Reply-To: <20191008100945.24951-3-ming.lei@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 3497 bytes --]
Hi Ming,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on scsi/for-next]
[cannot apply to v5.4-rc2 next-20191009]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Ming-Lei/scsi-core-avoid-host-wide-host_busy-counter-for-scsi_mq/20191009-015827
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/scsi/scsi_lib.c:1293 scsi_dev_queue_ready() error: uninitialized symbol 'busy'.
# https://github.com/0day-ci/linux/commit/74eb6c22dc70e395b333c9ca579855cd88db8845
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 74eb6c22dc70e395b333c9ca579855cd88db8845
vim +/busy +1293 drivers/scsi/scsi_lib.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 1284 static inline int scsi_dev_queue_ready(struct request_queue *q,
^1da177e4c3f41 Linus Torvalds 2005-04-16 1285 struct scsi_device *sdev)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1286 {
71e75c97f97a96 Christoph Hellwig 2014-04-11 1287 unsigned int busy;
Needs to be busy = 0;
74eb6c22dc70e3 Ming Lei 2019-10-08 1288 bool bypass = blk_queue_nonrot(sdev->request_queue);
71e75c97f97a96 Christoph Hellwig 2014-04-11 1289
74eb6c22dc70e3 Ming Lei 2019-10-08 1290 if (!bypass)
71e75c97f97a96 Christoph Hellwig 2014-04-11 1291 busy = atomic_inc_return(&sdev->device_busy) - 1;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
cd9070c9c512ff Christoph Hellwig 2014-01-23 1292 if (atomic_read(&sdev->device_blocked)) {
71e75c97f97a96 Christoph Hellwig 2014-04-11 @1293 if (busy)
^^^^
71e75c97f97a96 Christoph Hellwig 2014-04-11 1294 goto out_dec;
71e75c97f97a96 Christoph Hellwig 2014-04-11 1295
^1da177e4c3f41 Linus Torvalds 2005-04-16 1296 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 1297 * unblock after device_blocked iterates to zero
^1da177e4c3f41 Linus Torvalds 2005-04-16 1298 */
f664a3cc17b7d0 Jens Axboe 2018-11-01 1299 if (atomic_dec_return(&sdev->device_blocked) > 0)
71e75c97f97a96 Christoph Hellwig 2014-04-11 1300 goto out_dec;
71e75c97f97a96 Christoph Hellwig 2014-04-11 1301 SCSI_LOG_MLQUEUE(3, sdev_printk(KERN_INFO, sdev,
71e75c97f97a96 Christoph Hellwig 2014-04-11 1302 "unblocking device at zero depth\n"));
^1da177e4c3f41 Linus Torvalds 2005-04-16 1303 }
71e75c97f97a96 Christoph Hellwig 2014-04-11 1304
74eb6c22dc70e3 Ming Lei 2019-10-08 1305 if (bypass)
74eb6c22dc70e3 Ming Lei 2019-10-08 1306 return 1;
74eb6c22dc70e3 Ming Lei 2019-10-08 1307
71e75c97f97a96 Christoph Hellwig 2014-04-11 1308 if (busy >= sdev->queue_depth)
71e75c97f97a96 Christoph Hellwig 2014-04-11 1309 goto out_dec;
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH V3 2/2] scsi: core: don't limit per-LUN queue depth for SSD
Date: Wed, 09 Oct 2019 11:29:06 +0300 [thread overview]
Message-ID: <20191009082321.GA13048@kadam> (raw)
In-Reply-To: <20191008100945.24951-3-ming.lei@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 3497 bytes --]
Hi Ming,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on scsi/for-next]
[cannot apply to v5.4-rc2 next-20191009]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Ming-Lei/scsi-core-avoid-host-wide-host_busy-counter-for-scsi_mq/20191009-015827
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/scsi/scsi_lib.c:1293 scsi_dev_queue_ready() error: uninitialized symbol 'busy'.
# https://github.com/0day-ci/linux/commit/74eb6c22dc70e395b333c9ca579855cd88db8845
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 74eb6c22dc70e395b333c9ca579855cd88db8845
vim +/busy +1293 drivers/scsi/scsi_lib.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 1284 static inline int scsi_dev_queue_ready(struct request_queue *q,
^1da177e4c3f41 Linus Torvalds 2005-04-16 1285 struct scsi_device *sdev)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1286 {
71e75c97f97a96 Christoph Hellwig 2014-04-11 1287 unsigned int busy;
Needs to be busy = 0;
74eb6c22dc70e3 Ming Lei 2019-10-08 1288 bool bypass = blk_queue_nonrot(sdev->request_queue);
71e75c97f97a96 Christoph Hellwig 2014-04-11 1289
74eb6c22dc70e3 Ming Lei 2019-10-08 1290 if (!bypass)
71e75c97f97a96 Christoph Hellwig 2014-04-11 1291 busy = atomic_inc_return(&sdev->device_busy) - 1;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
cd9070c9c512ff Christoph Hellwig 2014-01-23 1292 if (atomic_read(&sdev->device_blocked)) {
71e75c97f97a96 Christoph Hellwig 2014-04-11 @1293 if (busy)
^^^^
71e75c97f97a96 Christoph Hellwig 2014-04-11 1294 goto out_dec;
71e75c97f97a96 Christoph Hellwig 2014-04-11 1295
^1da177e4c3f41 Linus Torvalds 2005-04-16 1296 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 1297 * unblock after device_blocked iterates to zero
^1da177e4c3f41 Linus Torvalds 2005-04-16 1298 */
f664a3cc17b7d0 Jens Axboe 2018-11-01 1299 if (atomic_dec_return(&sdev->device_blocked) > 0)
71e75c97f97a96 Christoph Hellwig 2014-04-11 1300 goto out_dec;
71e75c97f97a96 Christoph Hellwig 2014-04-11 1301 SCSI_LOG_MLQUEUE(3, sdev_printk(KERN_INFO, sdev,
71e75c97f97a96 Christoph Hellwig 2014-04-11 1302 "unblocking device at zero depth\n"));
^1da177e4c3f41 Linus Torvalds 2005-04-16 1303 }
71e75c97f97a96 Christoph Hellwig 2014-04-11 1304
74eb6c22dc70e3 Ming Lei 2019-10-08 1305 if (bypass)
74eb6c22dc70e3 Ming Lei 2019-10-08 1306 return 1;
74eb6c22dc70e3 Ming Lei 2019-10-08 1307
71e75c97f97a96 Christoph Hellwig 2014-04-11 1308 if (busy >= sdev->queue_depth)
71e75c97f97a96 Christoph Hellwig 2014-04-11 1309 goto out_dec;
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
next prev parent reply other threads:[~2019-10-09 8:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 10:09 [PATCH V3 0/2] scsi: avoid atomic operations in IO path Ming Lei
2019-10-08 10:09 ` [PATCH V3 1/2] scsi: core: avoid host-wide host_busy counter for scsi_mq Ming Lei
2019-10-08 10:09 ` [RFC PATCH V3 2/2] scsi: core: don't limit per-LUN queue depth for SSD Ming Lei
2019-10-08 19:33 ` kbuild test robot
2019-10-09 8:29 ` Dan Carpenter [this message]
2019-10-09 8:29 ` Dan Carpenter
2019-11-04 8:50 ` [scsi] 74eb6c22dc: suspend_stress.fail kernel test robot
2019-11-04 8:50 ` kernel test robot
2019-11-05 3:52 ` Bart Van Assche
2019-11-05 3:52 ` Bart Van Assche
2019-11-05 6:11 ` Ming Lei
2019-11-05 6:11 ` Ming Lei
2019-11-13 17:00 ` Bart Van Assche
2019-11-13 17:00 ` Bart Van Assche
2019-11-14 1:25 ` Ming Lei
2019-11-14 1:25 ` Ming Lei
2019-11-16 8:54 ` Ming Lei
2019-11-16 8:54 ` Ming Lei
2019-11-21 6:50 ` Oliver Sang
2019-11-21 6:50 ` Oliver Sang
2019-11-21 7:36 ` Ming Lei
2019-11-21 7:36 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009082321.GA13048@kadam \
--to=dan.carpenter@oracle.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.