From: Kalle Valo <kvalo@codeaurora.org>
To: Colin King <colin.king@canonical.com>
Cc: Jes Sorensen <Jes.Sorensen@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtl8xxxu: make arrays static, makes object smaller
Date: Wed, 09 Oct 2019 08:29:00 +0000 [thread overview]
Message-ID: <20191009082900.9AF8D61A2A@smtp.codeaurora.org> (raw)
In-Reply-To: <20191007135313.8443-1-colin.king@canonical.com>
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate const arrays on the stack but instead make them
> static. Makes the object code smaller by 60 bytes.
>
> Before:
> text data bss dec hex filename
> 15133 8768 0 23901 5d5d realtek/rtl8xxxu/rtl8xxxu_8192e.o
> 15209 6392 0 21601 5461 realtek/rtl8xxxu/rtl8xxxu_8723b.o
> 103254 31202 576 135032 20f78 realtek/rtl8xxxu/rtl8xxxu_core.o
>
> After:
> text data bss dec hex filename
> 14861 9024 0 23885 5d4d realtek/rtl8xxxu/rtl8xxxu_8192e.o
> 14953 6616 0 21569 5441 realtek/rtl8xxxu/rtl8xxxu_8723b.o
> 102986 31458 576 135020 20f6c realtek/rtl8xxxu/rtl8xxxu_core.o
>
> (gcc version 9.2.1, amd64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Reviewed-by: Chris Chiu <chiu@endlessm.com>
Patch applied to wireless-drivers-next.git, thanks.
314bf64d1266 rtl8xxxu: make arrays static, makes object smaller
--
https://patchwork.kernel.org/patch/11177577/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Colin King <colin.king@canonical.com>
Cc: Jes Sorensen <Jes.Sorensen@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtl8xxxu: make arrays static, makes object smaller
Date: Wed, 9 Oct 2019 08:29:00 +0000 (UTC) [thread overview]
Message-ID: <20191009082900.9AF8D61A2A@smtp.codeaurora.org> (raw)
In-Reply-To: <20191007135313.8443-1-colin.king@canonical.com>
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate const arrays on the stack but instead make them
> static. Makes the object code smaller by 60 bytes.
>
> Before:
> text data bss dec hex filename
> 15133 8768 0 23901 5d5d realtek/rtl8xxxu/rtl8xxxu_8192e.o
> 15209 6392 0 21601 5461 realtek/rtl8xxxu/rtl8xxxu_8723b.o
> 103254 31202 576 135032 20f78 realtek/rtl8xxxu/rtl8xxxu_core.o
>
> After:
> text data bss dec hex filename
> 14861 9024 0 23885 5d4d realtek/rtl8xxxu/rtl8xxxu_8192e.o
> 14953 6616 0 21569 5441 realtek/rtl8xxxu/rtl8xxxu_8723b.o
> 102986 31458 576 135020 20f6c realtek/rtl8xxxu/rtl8xxxu_core.o
>
> (gcc version 9.2.1, amd64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Reviewed-by: Chris Chiu <chiu@endlessm.com>
Patch applied to wireless-drivers-next.git, thanks.
314bf64d1266 rtl8xxxu: make arrays static, makes object smaller
--
https://patchwork.kernel.org/patch/11177577/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-10-09 8:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 13:53 [PATCH] rtl8xxxu: make arrays static, makes object smaller Colin King
2019-10-07 13:53 ` Colin King
2019-10-08 5:36 ` Chris Chiu
2019-10-08 5:36 ` Chris Chiu
2019-10-08 16:26 ` Jes Sorensen
2019-10-08 16:26 ` Jes Sorensen
2019-10-09 8:29 ` Kalle Valo [this message]
2019-10-09 8:29 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009082900.9AF8D61A2A@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Jes.Sorensen@gmail.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.