From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Drew Fustini <drew@pdp7.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [RFC] gpio: expose pull-up/pull-down line flags to userspace
Date: Thu, 10 Oct 2019 00:19:29 +0800 [thread overview]
Message-ID: <20191009161929.GA1976@sol> (raw)
In-Reply-To: <CAMRc=MetgRSK6+4eFkEiVuL4-D+++LZ_trr9yUqQ-H_e1POiFw@mail.gmail.com>
On Wed, Oct 09, 2019 at 05:50:00PM +0200, Bartosz Golaszewski wrote:
> śr., 9 paź 2019 o 16:11 Kent Gibson <warthog618@gmail.com> napisał(a):
> >
> > On Wed, Oct 09, 2019 at 03:30:37PM +0200, Drew Fustini wrote:
> > > On Wed, Oct 09, 2019 at 02:55:24PM +0800, Kent Gibson wrote:
> > > > Safe to assume your code is in your topic/gpio-uapi-config branch?
> > > > I hope so, cos I've forked from that into github.com/warthog618/linux
> > > > and have started working on it.
> > >
> > > Do you also have a fork of libgpiod that you are working in?
> > >
> > Actually not yet - I'm using my Go equivalent of libgpiod to drive the
> > kernel for my tests. That is also on github - it is in the uapi
> > directory of the feature/pud branch of my gpiod repo.
> >
> > > In case it is of any use, I just posted the libgpiod patch for pull-up/down
> > > flags that I had been using to test with.
> > >
> > > I help maintain Adafruit_Blinka [1] so I would like try testing pull-up/down.
> > > I already have a Raspberry Pi 3 booting a cross-compiled kernel with my (now
> > > outdated) patch applied and a patched libgpiod.
> > >
> > Go nuts. I hope to be testing on one of Pis, but I don't think I have a
> > recent kernel build handy, so I'll be a while.
> >
> > Cheers,
> > Kent.
>
> Hey guys, just one thing: don't send patches as replies - just send a
> new version as a separate series. Also: please aggregate all the
> patches (pull-up/down, set config, gpio-mockup changes if any) into a
> single series.
>
I think the only patch I've sent you was direct to you for feedback,
not to the list, and so not intended to be applied. And that was only
cos I thought you might prefer that to looking at the diffs on github.
Would it be ok to create two patch series - one for pull up/down and the
other for set config, if one still needs a lot more work?
And is it ok to base them on your lineevent_create gotos tidy up
(f6cfbbe2950b2)?
Cheers,
Kent.
next prev parent reply other threads:[~2019-10-09 16:19 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-21 10:25 [RFC] gpio: expose pull-up/pull-down line flags to userspace Drew Fustini
2019-09-23 8:38 ` Bartosz Golaszewski
2019-10-02 11:10 ` Drew Fustini
2019-10-03 12:47 ` Linus Walleij
2019-10-04 7:22 ` Bartosz Golaszewski
2019-10-04 12:46 ` Bartosz Golaszewski
2019-10-05 17:02 ` Linus Walleij
2019-10-06 3:12 ` Kent Gibson
2019-10-06 21:06 ` Linus Walleij
2019-10-07 4:37 ` Kent Gibson
2019-10-08 6:15 ` Kent Gibson
2019-10-08 20:56 ` Bartosz Golaszewski
2019-10-08 23:21 ` Kent Gibson
2019-10-08 23:30 ` Bartosz Golaszewski
2019-10-08 23:56 ` Kent Gibson
2019-10-09 0:03 ` Bartosz Golaszewski
2019-10-09 0:22 ` Kent Gibson
2019-10-09 6:55 ` Kent Gibson
2019-10-09 12:57 ` Drew Fustini
2019-10-09 13:23 ` Kent Gibson
2019-10-09 13:30 ` Drew Fustini
2019-10-09 14:11 ` Kent Gibson
2019-10-09 15:50 ` Bartosz Golaszewski
2019-10-09 16:19 ` Kent Gibson [this message]
2019-10-09 23:59 ` Kent Gibson
2019-10-10 7:47 ` Drew Fustini
2019-10-10 10:14 ` Kent Gibson
2019-10-10 11:17 ` Kent Gibson
2019-10-11 13:04 ` Drew Fustini
2019-10-11 13:06 ` Drew Fustini
2019-10-11 13:49 ` Kent Gibson
2019-10-09 11:32 ` Drew Fustini
2019-10-09 13:57 ` Drew Fustini
2019-10-09 14:01 ` Kent Gibson
2019-10-09 11:46 ` Drew Fustini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009161929.GA1976@sol \
--to=warthog618@gmail.com \
--cc=brgl@bgdev.pl \
--cc=drew@pdp7.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.