From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Iurii Zaikin <yzaikin@google.com>
Cc: "open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
linux-ext4@vger.kernel.org, skhan@linuxfoundation.org,
adilger.kernel@dilger.ca, kunit-dev@googlegroups.com,
Brendan Higgins <brendanhiggins@google.com>
Subject: Re: [PATCH v1] fs/ext4/inode-test: KUnit test for ext4 inode.
Date: Wed, 9 Oct 2019 12:53:52 -0400 [thread overview]
Message-ID: <20191009165352.GA13279@mit.edu> (raw)
In-Reply-To: <CAAXuY3rcz78vxvXbvg+wjFBFonmOx9dfweo3od6U6TaT8JVHsQ@mail.gmail.com>
On Tue, Oct 08, 2019 at 07:42:05PM -0700, Iurii Zaikin wrote:
> Note: this patch is intended to be applied against kselftest/test branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=test
>
> KUnit tests for decoding extended 64 bit timestamps.
I'd suggest using "ext4: add kunit test for decoding extended
timestamps" as the one-line summary, and we probably don't need
anything else.
> Signed-off-by: Iurii Zaikin <yzaikin@google.com>
> ---
> fs/ext4/Kconfig | 12 +++
> fs/ext4/Makefile | 1 +
> fs/ext4/inode-test.c | 217 +++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 230 insertions(+)
> create mode 100644 fs/ext4/inode-test.c
>
> diff --git a/fs/ext4/Kconfig b/fs/ext4/Kconfig
> index cbb5ca830e57..72c26abbce4c 100644
> --- a/fs/ext4/Kconfig
> +++ b/fs/ext4/Kconfig
> @@ -106,3 +106,15 @@ config EXT4_DEBUG
> If you select Y here, then you will be able to turn on debugging
> with a command such as:
> echo 1 > /sys/module/ext4/parameters/mballoc_debug
> +
> +config EXT4_INODE_KUNIT_TEST
> + bool "KUnit test for ext4 inode"
> + depends on EXT4_FS
> + depends on KUNIT
> + help
> + This builds the ext4 inode sysctl unit test, which runs on boot.
> + Tests the encoding correctness of ext4 inode.
> + For more information on KUnit and unit tests in general please refer
> + to the KUnit documentation in Documentation/dev-tools/kunit/.
Should we perhaps just call the cofnig "EXT4_KUNIT_TESTS"? Right now
the only thing we test is timestamp encoding/decoding, but later on
we'll be adding other other ext4 uninit tests --- and more ext4
encoding tests is not neceesarily where I would start, since the rest
are actually quite straightforward.
(The next set of uninit tests I'm interested in is the ext4's
extent_status tree, since that requires minimal amounts of test
mocks.)
So we might as well make the config name more general to begin with.
- Ted
prev parent reply other threads:[~2019-10-09 16:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 2:42 [PATCH v1] fs/ext4/inode-test: KUnit test for ext4 inode Iurii Zaikin
2019-10-09 13:48 ` Shuah Khan
2019-10-10 2:40 ` Iurii Zaikin
2019-10-09 16:48 ` Randy Dunlap
2019-10-09 16:53 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009165352.GA13279@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=brendanhiggins@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.