All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: Keith Busch <kbusch@kernel.org>
Cc: Hannes Reinecke <hare@suse.com>, Sagi Grimberg <sagi@grimberg.me>,
	stable@vger.kernel.org, linux-nvme@lists.infradead.org,
	Logan Gunthorpe <logang@deltatee.com>,
	Christoph Hellwig <hch@lst.de>, Minwoo Im <minwoo.im@samsung.com>
Subject: Re: [PATCH 4.19] nvme: Assign subsys instance from first ctrl
Date: Wed, 9 Oct 2019 17:55:04 -0400	[thread overview]
Message-ID: <20191009215504.GW1396@sasha-vm> (raw)
In-Reply-To: <20191009162910.1801-1-kbusch@kernel.org>

On Thu, Oct 10, 2019 at 01:29:10AM +0900, Keith Busch wrote:
>commit 733e4b69d508d03c20adfdcf4bd27abc60fae9cc upstream
>
>The namespace disk names must be unique for the lifetime of the
>subsystem. This was accomplished by using their parent subsystems'
>instances which were allocated independently from the controllers
>connected to that subsystem. This allowed name prefixes assigned to
>namespaces to match a controller from an unrelated subsystem, and has
>created confusion among users examining device nodes.
>
>Ensure a namespace's subsystem instance never clashes with a controller
>instance of another subsystem by transferring the instance ownership
>to the parent subsystem from the first controller discovered in that
>subsystem.
>
>Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
>Reviewed-by: Christoph Hellwig <hch@lst.de>
>Reviewed-by: Minwoo Im <minwoo.im@samsung.com>
>Reviewed-by: Hannes Reinecke <hare@suse.com>
>Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
>Signed-off-by: Keith Busch <kbusch@kernel.org>
>Signed-off-by: Sagi Grimberg <sagi@grimberg.me>

What are your thoughts about taking the following for 4.19 instead?

733e4b69d508d nvme: Assign subsys instance from first ctrl
e654dfd38c1ec nvme: fix memory leak caused by incorrect subsystem free
32fd90c407680 nvme: change locking for the per-subsystem controller list
092ff0520070f nvme: fix kernel paging oops
cb5b7262b011c nvme: provide fallback for discard alloc failure

--
Thanks,
Sasha

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

WARNING: multiple messages have this Message-ID (diff)
From: Sasha Levin <sashal@kernel.org>
To: Keith Busch <kbusch@kernel.org>
Cc: linux-nvme@lists.infradead.org, stable@vger.kernel.org,
	Logan Gunthorpe <logang@deltatee.com>,
	Christoph Hellwig <hch@lst.de>, Minwoo Im <minwoo.im@samsung.com>,
	Hannes Reinecke <hare@suse.com>, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH 4.19] nvme: Assign subsys instance from first ctrl
Date: Wed, 9 Oct 2019 17:55:04 -0400	[thread overview]
Message-ID: <20191009215504.GW1396@sasha-vm> (raw)
In-Reply-To: <20191009162910.1801-1-kbusch@kernel.org>

On Thu, Oct 10, 2019 at 01:29:10AM +0900, Keith Busch wrote:
>commit 733e4b69d508d03c20adfdcf4bd27abc60fae9cc upstream
>
>The namespace disk names must be unique for the lifetime of the
>subsystem. This was accomplished by using their parent subsystems'
>instances which were allocated independently from the controllers
>connected to that subsystem. This allowed name prefixes assigned to
>namespaces to match a controller from an unrelated subsystem, and has
>created confusion among users examining device nodes.
>
>Ensure a namespace's subsystem instance never clashes with a controller
>instance of another subsystem by transferring the instance ownership
>to the parent subsystem from the first controller discovered in that
>subsystem.
>
>Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
>Reviewed-by: Christoph Hellwig <hch@lst.de>
>Reviewed-by: Minwoo Im <minwoo.im@samsung.com>
>Reviewed-by: Hannes Reinecke <hare@suse.com>
>Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
>Signed-off-by: Keith Busch <kbusch@kernel.org>
>Signed-off-by: Sagi Grimberg <sagi@grimberg.me>

What are your thoughts about taking the following for 4.19 instead?

733e4b69d508d nvme: Assign subsys instance from first ctrl
e654dfd38c1ec nvme: fix memory leak caused by incorrect subsystem free
32fd90c407680 nvme: change locking for the per-subsystem controller list
092ff0520070f nvme: fix kernel paging oops
cb5b7262b011c nvme: provide fallback for discard alloc failure

--
Thanks,
Sasha

  reply	other threads:[~2019-10-09 21:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-09 16:29 [PATCH 4.19] nvme: Assign subsys instance from first ctrl Keith Busch
2019-10-09 16:29 ` Keith Busch
2019-10-09 21:55 ` Sasha Levin [this message]
2019-10-09 21:55   ` Sasha Levin
2019-10-09 22:10   ` Keith Busch
2019-10-09 22:10     ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191009215504.GW1396@sasha-vm \
    --to=sashal@kernel.org \
    --cc=hare@suse.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=logang@deltatee.com \
    --cc=minwoo.im@samsung.com \
    --cc=sagi@grimberg.me \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.