All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brendan Higgins <brendanhiggins@google.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH] i2c: aspeed: fix master pending state handling
Date: Wed, 9 Oct 2019 17:32:34 -0700	[thread overview]
Message-ID: <20191010003234.GA12710@google.com> (raw)
In-Reply-To: <20191009212034.20325-1-jae.hyun.yoo@linux.intel.com>

On Wed, Oct 09, 2019 at 02:20:34PM -0700, Jae Hyun Yoo wrote:
> In case of master pending state, it should not trigger a master
> command, otherwise data could be corrupted because this H/W shares
> the same data buffer for slave and master operations. It also means
> that H/W command queue handling is unreliable because of the buffer
> sharing issue. To fix this issue, it clears command queue if a
> master command is queued in pending state to use S/W solution
> instead of H/W command queue handling. Also, it refines restarting
> mechanism of the pending master command.
> 
> Fixes: 2e57b7cebb98 ("i2c: aspeed: Add multi-master use case support")
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

Reviewed-by: Brendan Higgins <brendanhiggins@google.com>

We don't have any multi-master setups, can we get a Tested-by?

Wolfram, since this is a bugfix, can we get this in 5.4?

Thanks!

WARNING: multiple messages have this Message-ID (diff)
From: Brendan Higgins <brendanhiggins@google.com>
To: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
	Wolfram Sang <wsa@the-dreams.de>,
	Andrew Jeffery <andrew@aj.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
	Tao Ren <taoren@fb.com>,
	linux-arm-kernel@lists.infradead.org,
	Cedric Le Goater <clg@kaod.org>
Subject: Re: [PATCH] i2c: aspeed: fix master pending state handling
Date: Wed, 9 Oct 2019 17:32:34 -0700	[thread overview]
Message-ID: <20191010003234.GA12710@google.com> (raw)
In-Reply-To: <20191009212034.20325-1-jae.hyun.yoo@linux.intel.com>

On Wed, Oct 09, 2019 at 02:20:34PM -0700, Jae Hyun Yoo wrote:
> In case of master pending state, it should not trigger a master
> command, otherwise data could be corrupted because this H/W shares
> the same data buffer for slave and master operations. It also means
> that H/W command queue handling is unreliable because of the buffer
> sharing issue. To fix this issue, it clears command queue if a
> master command is queued in pending state to use S/W solution
> instead of H/W command queue handling. Also, it refines restarting
> mechanism of the pending master command.
> 
> Fixes: 2e57b7cebb98 ("i2c: aspeed: Add multi-master use case support")
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

Reviewed-by: Brendan Higgins <brendanhiggins@google.com>

We don't have any multi-master setups, can we get a Tested-by?

Wolfram, since this is a bugfix, can we get this in 5.4?

Thanks!

WARNING: multiple messages have this Message-ID (diff)
From: Brendan Higgins <brendanhiggins@google.com>
To: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Joel Stanley <joel@jms.id.au>, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Andrew Jeffery <andrew@aj.id.au>, Tao Ren <taoren@fb.com>,
	Cedric Le Goater <clg@kaod.org>,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org
Subject: Re: [PATCH] i2c: aspeed: fix master pending state handling
Date: Wed, 9 Oct 2019 17:32:34 -0700	[thread overview]
Message-ID: <20191010003234.GA12710@google.com> (raw)
In-Reply-To: <20191009212034.20325-1-jae.hyun.yoo@linux.intel.com>

On Wed, Oct 09, 2019 at 02:20:34PM -0700, Jae Hyun Yoo wrote:
> In case of master pending state, it should not trigger a master
> command, otherwise data could be corrupted because this H/W shares
> the same data buffer for slave and master operations. It also means
> that H/W command queue handling is unreliable because of the buffer
> sharing issue. To fix this issue, it clears command queue if a
> master command is queued in pending state to use S/W solution
> instead of H/W command queue handling. Also, it refines restarting
> mechanism of the pending master command.
> 
> Fixes: 2e57b7cebb98 ("i2c: aspeed: Add multi-master use case support")
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

Reviewed-by: Brendan Higgins <brendanhiggins@google.com>

We don't have any multi-master setups, can we get a Tested-by?

Wolfram, since this is a bugfix, can we get this in 5.4?

Thanks!

WARNING: multiple messages have this Message-ID (diff)
From: Brendan Higgins <brendanhiggins@google.com>
To: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
	Wolfram Sang <wsa@the-dreams.de>,
	Andrew Jeffery <andrew@aj.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
	Tao Ren <taoren@fb.com>,
	linux-arm-kernel@lists.infradead.org,
	Cedric Le Goater <clg@kaod.org>
Subject: Re: [PATCH] i2c: aspeed: fix master pending state handling
Date: Wed, 9 Oct 2019 17:32:34 -0700	[thread overview]
Message-ID: <20191010003234.GA12710@google.com> (raw)
In-Reply-To: <20191009212034.20325-1-jae.hyun.yoo@linux.intel.com>

On Wed, Oct 09, 2019 at 02:20:34PM -0700, Jae Hyun Yoo wrote:
> In case of master pending state, it should not trigger a master
> command, otherwise data could be corrupted because this H/W shares
> the same data buffer for slave and master operations. It also means
> that H/W command queue handling is unreliable because of the buffer
> sharing issue. To fix this issue, it clears command queue if a
> master command is queued in pending state to use S/W solution
> instead of H/W command queue handling. Also, it refines restarting
> mechanism of the pending master command.
> 
> Fixes: 2e57b7cebb98 ("i2c: aspeed: Add multi-master use case support")
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

Reviewed-by: Brendan Higgins <brendanhiggins@google.com>

We don't have any multi-master setups, can we get a Tested-by?

Wolfram, since this is a bugfix, can we get this in 5.4?

Thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-10-10  0:32 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-09 21:20 [PATCH] i2c: aspeed: fix master pending state handling Jae Hyun Yoo
2019-10-09 21:20 ` Jae Hyun Yoo
2019-10-09 21:20 ` Jae Hyun Yoo
2019-10-09 21:20 ` Jae Hyun Yoo
2019-10-10  0:32 ` Brendan Higgins [this message]
2019-10-10  0:32   ` Brendan Higgins
2019-10-10  0:32   ` Brendan Higgins
2019-10-10  0:32   ` Brendan Higgins
2019-10-10  1:26   ` Tao Ren
2019-10-10  1:26     ` Tao Ren
2019-10-10  1:26     ` Tao Ren
2019-10-10  1:26     ` Tao Ren
2019-10-10  6:37   ` Wolfram Sang
2019-10-10  6:37     ` Wolfram Sang
2019-10-10  6:37     ` Wolfram Sang
2019-10-10  6:48 ` Joel Stanley
2019-10-10  6:48   ` Joel Stanley
2019-10-10  6:48   ` Joel Stanley
2019-10-10  6:48   ` Joel Stanley
2019-10-10 18:22   ` Jae Hyun Yoo
2019-10-10 18:22     ` Jae Hyun Yoo
2019-10-10 18:22     ` Jae Hyun Yoo
2019-10-10 18:22     ` Jae Hyun Yoo
2019-10-10 21:20 ` Tao Ren
2019-10-10 21:20   ` Tao Ren
2019-10-10 21:20   ` Tao Ren
2019-10-10 21:20   ` Tao Ren
2019-10-10 22:04   ` Jae Hyun Yoo
2019-10-10 22:04     ` Jae Hyun Yoo
2019-10-10 22:04     ` Jae Hyun Yoo
2019-10-10 22:04     ` Jae Hyun Yoo
2019-10-10 23:11     ` Tao Ren
2019-10-10 23:11       ` Tao Ren
2019-10-10 23:11       ` Tao Ren
2019-10-10 23:16       ` Jae Hyun Yoo
2019-10-10 23:16         ` Jae Hyun Yoo
2019-10-10 23:16         ` Jae Hyun Yoo
2019-10-10 23:24         ` Tao Ren
2019-10-10 23:24           ` Tao Ren
2019-10-10 23:24           ` Tao Ren
2019-10-10 23:29 ` Tao Ren
2019-10-10 23:29   ` Tao Ren
2019-10-10 23:29   ` Tao Ren
2019-10-10 23:29   ` Tao Ren
2019-10-10 23:52   ` Jae Hyun Yoo
2019-10-10 23:52     ` Jae Hyun Yoo
2019-10-10 23:52     ` Jae Hyun Yoo
2019-10-10 23:52     ` Jae Hyun Yoo
2019-10-16 19:20     ` Brendan Higgins
2019-10-16 19:20       ` Brendan Higgins
2019-10-16 19:20       ` Brendan Higgins
2019-10-16 19:20       ` Brendan Higgins
2019-10-21 12:09 ` Wolfram Sang
2019-10-21 12:09   ` Wolfram Sang
2019-10-21 12:09   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191010003234.GA12710@google.com \
    --to=brendanhiggins@google.com \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.