From: Dan Carpenter <dan.carpenter@oracle.com>
To: Yizhuo <yzhai003@ucr.edu>
Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
Teddy Wang <teddy.wang@siliconmotion.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: Re: [PATCH] staging: sm750fb: Potential uninitialized field in "pll"
Date: Thu, 10 Oct 2019 09:53:35 +0000 [thread overview]
Message-ID: <20191010091834.GG20470@kadam> (raw)
In-Reply-To: <20191010043809.27594-1-yzhai003@ucr.edu>
On Wed, Oct 09, 2019 at 09:38:08PM -0700, Yizhuo wrote:
> Inside function set_chip_clock(), struct pll is supposed to be
> initialized in sm750_calc_pll_value(), if condition
> "diff < mini_diff" in sm750_calc_pll_value() cannot be fulfilled,
> then some field of pll will not be initialized but used in
> function sm750_format_pll_reg(), which is potentially unsafe.
>
> Signed-off-by: Yizhuo <yzhai003@ucr.edu>
The patch is correct, but it doesn't apply to linux-next any more. Can
you re-write it on top of the most recent staging-next and resend?
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Yizhuo <yzhai003@ucr.edu>
Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
Teddy Wang <teddy.wang@siliconmotion.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: Re: [PATCH] staging: sm750fb: Potential uninitialized field in "pll"
Date: Thu, 10 Oct 2019 12:53:35 +0300 [thread overview]
Message-ID: <20191010091834.GG20470@kadam> (raw)
In-Reply-To: <20191010043809.27594-1-yzhai003@ucr.edu>
On Wed, Oct 09, 2019 at 09:38:08PM -0700, Yizhuo wrote:
> Inside function set_chip_clock(), struct pll is supposed to be
> initialized in sm750_calc_pll_value(), if condition
> "diff < mini_diff" in sm750_calc_pll_value() cannot be fulfilled,
> then some field of pll will not be initialized but used in
> function sm750_format_pll_reg(), which is potentially unsafe.
>
> Signed-off-by: Yizhuo <yzhai003@ucr.edu>
The patch is correct, but it doesn't apply to linux-next any more. Can
you re-write it on top of the most recent staging-next and resend?
regards,
dan carpenter
next prev parent reply other threads:[~2019-10-10 9:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 4:38 [PATCH] staging: sm750fb: Potential uninitialized field in "pll" Yizhuo
2019-10-10 4:38 ` Yizhuo
2019-10-10 9:04 ` Greg Kroah-Hartman
2019-10-10 9:04 ` Greg Kroah-Hartman
2019-10-10 9:53 ` Dan Carpenter [this message]
2019-10-10 9:53 ` Dan Carpenter
2019-10-11 0:37 ` Yizhuo Zhai
2019-10-11 0:37 ` Yizhuo Zhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010091834.GG20470@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
--cc=yzhai003@ucr.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.