From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] scanpypi: write every license file once
Date: Thu, 10 Oct 2019 09:29:22 +0200 [thread overview]
Message-ID: <20191010092922.1b124a28@windsurf> (raw)
In-Reply-To: <CAGm1_kvXJGA0VYoC86zGLxRk405K3LDmwJ=9B=UDxvm+25+Dxw@mail.gmail.com>
Hello Yegor,
On Wed, 9 Oct 2019 19:36:23 +0200
Yegor Yefremov <yegorslists@googlemail.com> wrote:
> > There are two checks to see if the manual gpio is configured, but
> > these the check is seeing if the structure is NULL instead it
> > should check to see if there are CTS and/or RTS pins defined.
> >
> > This patch uses checks for those individual pins instead of
> > checking for the structure itself to restore auto RTS/CTS.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
Is that a bad copy/paste ? It seems like you were working on some
serial port kernel commits at the same time, isn't it ? :-)
> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
Anyway, thanks for the review! :-)
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-10-10 7:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 9:04 [Buildroot] [PATCH 1/1] package/python-aioredis: bump to version 1.3.0 Asaf Kahlon
2019-10-08 9:04 ` [Buildroot] [PATCH 1/1] scanpypi: write every license file once Asaf Kahlon
2019-10-08 21:22 ` Thomas Petazzoni
2019-10-09 17:36 ` Yegor Yefremov
2019-10-10 7:29 ` Thomas Petazzoni [this message]
2019-10-10 8:38 ` Yegor Yefremov
2019-10-11 21:12 ` Arnout Vandecappelle
2019-10-08 20:45 ` [Buildroot] [PATCH 1/1] package/python-aioredis: bump to version 1.3.0 Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010092922.1b124a28@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.