[Buildroot] [PATCH 1/1] package/python-aioredis: bump to version 1.3.0

[Buildroot] [PATCH 1/1] package/python-aioredis: bump to version 1.3.0

[Asaf Kahlon]

Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
---
 package/python-aioredis/python-aioredis.hash | 4 ++--
 package/python-aioredis/python-aioredis.mk   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/package/python-aioredis/python-aioredis.hash b/package/python-aioredis/python-aioredis.hash
index 19f147fdcc..9000072420 100644
--- a/package/python-aioredis/python-aioredis.hash
+++ b/package/python-aioredis/python-aioredis.hash
@@ -1,5 +1,5 @@
 # md5, sha256 from https://pypi.org/pypi/aioredis/json
-md5	fd6c66e4d8efce553c369c0855c6fb49  aioredis-1.2.0.tar.gz
-sha256	84d62be729beb87118cf126c20b0e3f52d7a42bb7373dc5bcdd874f26f1f251a  aioredis-1.2.0.tar.gz
+md5	7577e902854a66649c34866e1d3197c0  aioredis-1.3.0.tar.gz
+sha256	86da2748fb0652625a8346f413167f078ec72bdc76e217db7e605a059cd56e86  aioredis-1.3.0.tar.gz
 # Locally computed sha256 checksums
 sha256	a288b4f41b5531ff7e9e2df9cd3f17a1844badebc52d7a9205b131f8b8a50744  LICENSE
diff --git a/package/python-aioredis/python-aioredis.mk b/package/python-aioredis/python-aioredis.mk
index 02641ec7ac..0781ee55d5 100644
--- a/package/python-aioredis/python-aioredis.mk
+++ b/package/python-aioredis/python-aioredis.mk
@@ -4,9 +4,9 @@
 #
 ################################################################################
 
-PYTHON_AIOREDIS_VERSION = 1.2.0
+PYTHON_AIOREDIS_VERSION = 1.3.0
 PYTHON_AIOREDIS_SOURCE = aioredis-$(PYTHON_AIOREDIS_VERSION).tar.gz
-PYTHON_AIOREDIS_SITE = https://files.pythonhosted.org/packages/2e/a3/cd122b68d8071d332972027d225f548e0206001da1aa0685ea08db803b06
+PYTHON_AIOREDIS_SITE = https://files.pythonhosted.org/packages/48/28/0bf4d0d218f521b95b0497b72135a4ff5ef55e62c72bb73babb0345a4627
 PYTHON_AIOREDIS_SETUP_TYPE = setuptools
 PYTHON_AIOREDIS_LICENSE = MIT
 PYTHON_AIOREDIS_LICENSE_FILES = LICENSE
-- 
2.20.1

[Buildroot] [PATCH 1/1] scanpypi: write every license file once

[Asaf Kahlon]

On some cases, when the package contains multiple license files
and some of them from the same type, the scanpypi script will write
the same license type more than once under _LICENSE.
Hence, before creating the _LICENSE variable, we'll remove every
possible duplication.

Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
---
 utils/scanpypi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/utils/scanpypi b/utils/scanpypi
index 55b3d1e61c..b48eda49aa 100755
--- a/utils/scanpypi
+++ b/utils/scanpypi
@@ -461,6 +461,7 @@ class BuildrootPackage():
                       ' likely wrong, please change it if need be'.format(
                           license=', '.join(licenses)))
                 licenses = [self.metadata['info']['license']]
+            licenses = set(licenses)
             license_line = '{name}_LICENSE = {license}\n'.format(
                 name=self.mk_name,
                 license=', '.join(licenses))
@@ -473,6 +474,7 @@ class BuildrootPackage():
                     license_names.append(match.license.id)
                 else:
                     license_names.append("FIXME: license id couldn't be detected")
+            license_names = set(license_names)
 
             if len(license_names) > 0:
                 license_line = ('{name}_LICENSE ='
-- 
2.20.1

[Buildroot] [PATCH 1/1] scanpypi: write every license file once

[Thomas Petazzoni]

Hello,

+Yegor in Cc.

On Tue,  8 Oct 2019 12:04:04 +0300
Asaf Kahlon <asafka7@gmail.com> wrote:

> On some cases, when the package contains multiple license files
> and some of them from the same type, the scanpypi script will write
> the same license type more than once under _LICENSE.
> Hence, before creating the _LICENSE variable, we'll remove every
> possible duplication.
> 
> Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
> ---
>  utils/scanpypi | 2 ++
>  1 file changed, 2 insertions(+)

Yegor, it would be nice to have your review on this patch. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] scanpypi: write every license file once

[Yegor Yefremov]

On Tue, Oct 8, 2019 at 11:22 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello,
>
> +Yegor in Cc.
>
> On Tue,  8 Oct 2019 12:04:04 +0300
> Asaf Kahlon <asafka7@gmail.com> wrote:
>
> > On some cases, when the package contains multiple license files
> > and some of them from the same type, the scanpypi script will write
> > the same license type more than once under _LICENSE.
> > Hence, before creating the _LICENSE variable, we'll remove every
> > possible duplication.
> >
> > Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
> > ---
> >  utils/scanpypi | 2 ++
> >  1 file changed, 2 insertions(+)
>
> Yegor, it would be nice to have your review on this patch. Thanks!

On Sun, Oct 6, 2019 at 6:33 PM Adam Ford <aford173@gmail.com> wrote:
>
> There are two checks to see if the manual gpio is configured, but
> these the check is seeing if the structure is NULL instead it
> should check to see if there are CTS and/or RTS pins defined.
>
> This patch uses checks for those individual pins instead of
> checking for the structure itself to restore auto RTS/CTS.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>

Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>

[Buildroot] [PATCH 1/1] scanpypi: write every license file once

[Thomas Petazzoni]

Hello Yegor,

On Wed, 9 Oct 2019 19:36:23 +0200
Yegor Yefremov <yegorslists@googlemail.com> wrote:

> > There are two checks to see if the manual gpio is configured, but
> > these the check is seeing if the structure is NULL instead it
> > should check to see if there are CTS and/or RTS pins defined.
> >
> > This patch uses checks for those individual pins instead of
> > checking for the structure itself to restore auto RTS/CTS.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>  

Is that a bad copy/paste ? It seems like you were working on some
serial port kernel commits at the same time, isn't it ? :-)

> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>

Anyway, thanks for the review! :-)

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] scanpypi: write every license file once

[Yegor Yefremov]

Hello Thomas,

On Thu, Oct 10, 2019 at 9:29 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello Yegor,
>
> On Wed, 9 Oct 2019 19:36:23 +0200
> Yegor Yefremov <yegorslists@googlemail.com> wrote:
>
> > > There are two checks to see if the manual gpio is configured, but
> > > these the check is seeing if the structure is NULL instead it
> > > should check to see if there are CTS and/or RTS pins defined.
> > >
> > > This patch uses checks for those individual pins instead of
> > > checking for the structure itself to restore auto RTS/CTS.
> > >
> > > Signed-off-by: Adam Ford <aford173@gmail.com>
>
> Is that a bad copy/paste ? It seems like you were working on some
> serial port kernel commits at the same time, isn't it ? :-)

Every time I try to copy/paste something on a laptop I get similar
results. Sorry for that.

Yegor

> > Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
>
> Anyway, thanks for the review! :-)
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

[Buildroot] [PATCH 1/1] scanpypi: write every license file once

[Arnout Vandecappelle]

On 08/10/2019 11:04, Asaf Kahlon wrote:
> On some cases, when the package contains multiple license files
> and some of them from the same type, the scanpypi script will write
> the same license type more than once under _LICENSE.
> Hence, before creating the _LICENSE variable, we'll remove every
> possible duplication.
> 
> Signed-off-by: Asaf Kahlon <asafka7@gmail.com>

 Applied to master, thanks.


> ---
>  utils/scanpypi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/utils/scanpypi b/utils/scanpypi
> index 55b3d1e61c..b48eda49aa 100755
> --- a/utils/scanpypi
> +++ b/utils/scanpypi
> @@ -461,6 +461,7 @@ class BuildrootPackage():
>                        ' likely wrong, please change it if need be'.format(
>                            license=', '.join(licenses)))

 I notice now that there's something wrong here: this is under a condition that
licenses is empty, so this statement makes no sense...

>                  licenses = [self.metadata['info']['license']]
> +            licenses = set(licenses)
>              license_line = '{name}_LICENSE = {license}\n'.format(
>                  name=self.mk_name,
>                  license=', '.join(licenses))
> @@ -473,6 +474,7 @@ class BuildrootPackage():
>                      license_names.append(match.license.id)
>                  else:
>                      license_names.append("FIXME: license id couldn't be detected")
> +            license_names = set(license_names)
>  
>              if len(license_names) > 0:
>                  license_line = ('{name}_LICENSE ='

 We have exactly the same code here (including the line you added) in both
branches of the condition, so I smell a refactoring opportunity!

 Regards,
 Arnout

[Buildroot] [PATCH 1/1] package/python-aioredis: bump to version 1.3.0

[Thomas Petazzoni]

On Tue,  8 Oct 2019 12:04:03 +0300
Asaf Kahlon <asafka7@gmail.com> wrote:

> Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
> ---
>  package/python-aioredis/python-aioredis.hash | 4 ++--
>  package/python-aioredis/python-aioredis.mk   | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com