Re: [PATCH 6/6] Add device ejected to mount options

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3275 bytes --]

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]
[cannot apply to v5.4-rc2 next-20191009]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/philipp-ammann-posteo-de/Various-exfat-fixes/20191010-101029
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/staging/exfat/exfat_super.c: In function 'exfat_show_options':
>> drivers/staging/exfat/exfat_super.c:3544:2: error: unknown type name 'FS_INFO_T'; did you mean 'FW_INFO'?
     FS_INFO_T *p_fs = &(sbi->fs_info);
     ^~~~~~~~~
     FW_INFO
>> drivers/staging/exfat/exfat_super.c:3544:20: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
     FS_INFO_T *p_fs = &(sbi->fs_info);
                       ^
>> drivers/staging/exfat/exfat_super.c:3569:10: error: request for member 'dev_ejected' in something not a structure or union
     if (p_fs->dev_ejected)
             ^~
   cc1: some warnings being treated as errors

vim +3544 drivers/staging/exfat/exfat_super.c

  3539	
  3540	static int exfat_show_options(struct seq_file *m, struct dentry *root)
  3541	{
  3542		struct exfat_sb_info *sbi = EXFAT_SB(root->d_sb);
  3543		struct exfat_mount_options *opts = &sbi->options;
> 3544		FS_INFO_T *p_fs = &(sbi->fs_info);
  3545	
  3546		if (__kuid_val(opts->fs_uid))
  3547			seq_printf(m, ",uid=%u", __kuid_val(opts->fs_uid));
  3548		if (__kgid_val(opts->fs_gid))
  3549			seq_printf(m, ",gid=%u", __kgid_val(opts->fs_gid));
  3550		seq_printf(m, ",fmask=%04o", opts->fs_fmask);
  3551		seq_printf(m, ",dmask=%04o", opts->fs_dmask);
  3552		if (opts->allow_utime)
  3553			seq_printf(m, ",allow_utime=%04o", opts->allow_utime);
  3554		if (sbi->nls_disk)
  3555			seq_printf(m, ",codepage=%s", sbi->nls_disk->charset);
  3556		if (sbi->nls_io)
  3557			seq_printf(m, ",iocharset=%s", sbi->nls_io->charset);
  3558		seq_printf(m, ",namecase=%u", opts->casesensitive);
  3559		if (opts->errors == EXFAT_ERRORS_CONT)
  3560			seq_puts(m, ",errors=continue");
  3561		else if (opts->errors == EXFAT_ERRORS_PANIC)
  3562			seq_puts(m, ",errors=panic");
  3563		else
  3564			seq_puts(m, ",errors=remount-ro");
  3565	#ifdef CONFIG_EXFAT_DISCARD
  3566		if (opts->discard)
  3567			seq_puts(m, ",discard");
  3568	#endif
> 3569		if (p_fs->dev_ejected)
  3570			seq_puts(m, ",ejected");
  3571		return 0;
  3572	}
  3573	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 52238 bytes --]