* [PATCH] drm/plane: Clarify our expectations for src/dst rectangles
@ 2019-10-10 11:29 Maarten Lankhorst
2019-10-10 12:36 ` Ville Syrjälä
0 siblings, 1 reply; 5+ messages in thread
From: Maarten Lankhorst @ 2019-10-10 11:29 UTC (permalink / raw)
To: dri-devel; +Cc: Maxime Ripard, David Airlie, Sean Paul
The rectangles are usually clipped, but it can be useful to have
them unclipped, for example for cursor planes.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
include/drm/drm_plane.h | 22 ++++++++++++++++++++--
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h
index cd5903ad33f7..94bbbf215100 100644
--- a/include/drm/drm_plane.h
+++ b/include/drm/drm_plane.h
@@ -183,8 +183,26 @@ struct drm_plane_state {
*/
struct drm_property_blob *fb_damage_clips;
- /** @src: clipped source coordinates of the plane (in 16.16) */
- /** @dst: clipped destination coordinates of the plane */
+ /**
+ * @src:
+ *
+ * source coordinates of the plane (in 16.16).
+ *
+ * When using drm_atomic_helper_check_plane_state(),
+ * the coordinates are clipped, but the driver may choose
+ * to use unclipped coordinates instead.
+ *
+ * This can be useful when using a hardcoded size in a cursor plane.
+ */
+ /**
+ * @dst:
+ *
+ * When using drm_atomic_helper_check_plane_state(),
+ * the coordinates are clipped, but the driver may choose
+ * to use unclipped coordinates instead.
+ *
+ * This can be useful when using a hardcoded size in a cursor plane.
+ */
struct drm_rect src, dst;
/**
--
2.23.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drm/plane: Clarify our expectations for src/dst rectangles
2019-10-10 11:29 [PATCH] drm/plane: Clarify our expectations for src/dst rectangles Maarten Lankhorst
@ 2019-10-10 12:36 ` Ville Syrjälä
2019-10-10 12:46 ` Maarten Lankhorst
0 siblings, 1 reply; 5+ messages in thread
From: Ville Syrjälä @ 2019-10-10 12:36 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: Maxime Ripard, David Airlie, Sean Paul, dri-devel
On Thu, Oct 10, 2019 at 01:29:17PM +0200, Maarten Lankhorst wrote:
> The rectangles are usually clipped, but it can be useful to have
> them unclipped, for example for cursor planes.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
> include/drm/drm_plane.h | 22 ++++++++++++++++++++--
> 1 file changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h
> index cd5903ad33f7..94bbbf215100 100644
> --- a/include/drm/drm_plane.h
> +++ b/include/drm/drm_plane.h
> @@ -183,8 +183,26 @@ struct drm_plane_state {
> */
> struct drm_property_blob *fb_damage_clips;
>
> - /** @src: clipped source coordinates of the plane (in 16.16) */
> - /** @dst: clipped destination coordinates of the plane */
> + /**
> + * @src:
> + *
> + * source coordinates of the plane (in 16.16).
> + *
> + * When using drm_atomic_helper_check_plane_state(),
> + * the coordinates are clipped, but the driver may choose
> + * to use unclipped coordinates instead.
> + *
> + * This can be useful when using a hardcoded size in a cursor plane.
I would instead say something like "when the hardware performs
the clipping automagically".
> + */
> + /**
> + * @dst:
> + *
> + * When using drm_atomic_helper_check_plane_state(),
> + * the coordinates are clipped, but the driver may choose
> + * to use unclipped coordinates instead.
> + *
> + * This can be useful when using a hardcoded size in a cursor plane.
> + */
> struct drm_rect src, dst;
>
> /**
> --
> 2.23.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/plane: Clarify our expectations for src/dst rectangles
2019-10-10 12:36 ` Ville Syrjälä
@ 2019-10-10 12:46 ` Maarten Lankhorst
2019-10-10 13:07 ` Ville Syrjälä
0 siblings, 1 reply; 5+ messages in thread
From: Maarten Lankhorst @ 2019-10-10 12:46 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Maxime Ripard, David Airlie, Sean Paul, dri-devel
Op 10-10-2019 om 14:36 schreef Ville Syrjälä:
> On Thu, Oct 10, 2019 at 01:29:17PM +0200, Maarten Lankhorst wrote:
>> The rectangles are usually clipped, but it can be useful to have
>> them unclipped, for example for cursor planes.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> ---
>> include/drm/drm_plane.h | 22 ++++++++++++++++++++--
>> 1 file changed, 20 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h
>> index cd5903ad33f7..94bbbf215100 100644
>> --- a/include/drm/drm_plane.h
>> +++ b/include/drm/drm_plane.h
>> @@ -183,8 +183,26 @@ struct drm_plane_state {
>> */
>> struct drm_property_blob *fb_damage_clips;
>>
>> - /** @src: clipped source coordinates of the plane (in 16.16) */
>> - /** @dst: clipped destination coordinates of the plane */
>> + /**
>> + * @src:
>> + *
>> + * source coordinates of the plane (in 16.16).
>> + *
>> + * When using drm_atomic_helper_check_plane_state(),
>> + * the coordinates are clipped, but the driver may choose
>> + * to use unclipped coordinates instead.
>> + *
>> + * This can be useful when using a hardcoded size in a cursor plane.
> I would instead say something like "when the hardware performs
> the clipping automagically".
With that fixed, r-b?
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/plane: Clarify our expectations for src/dst rectangles
2019-10-10 12:46 ` Maarten Lankhorst
@ 2019-10-10 13:07 ` Ville Syrjälä
2019-10-10 13:49 ` Maarten Lankhorst
0 siblings, 1 reply; 5+ messages in thread
From: Ville Syrjälä @ 2019-10-10 13:07 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: Maxime Ripard, David Airlie, Sean Paul, dri-devel
On Thu, Oct 10, 2019 at 02:46:26PM +0200, Maarten Lankhorst wrote:
> Op 10-10-2019 om 14:36 schreef Ville Syrjälä:
> > On Thu, Oct 10, 2019 at 01:29:17PM +0200, Maarten Lankhorst wrote:
> >> The rectangles are usually clipped, but it can be useful to have
> >> them unclipped, for example for cursor planes.
> >>
> >> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> >> ---
> >> include/drm/drm_plane.h | 22 ++++++++++++++++++++--
> >> 1 file changed, 20 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h
> >> index cd5903ad33f7..94bbbf215100 100644
> >> --- a/include/drm/drm_plane.h
> >> +++ b/include/drm/drm_plane.h
> >> @@ -183,8 +183,26 @@ struct drm_plane_state {
> >> */
> >> struct drm_property_blob *fb_damage_clips;
> >>
> >> - /** @src: clipped source coordinates of the plane (in 16.16) */
> >> - /** @dst: clipped destination coordinates of the plane */
> >> + /**
> >> + * @src:
> >> + *
> >> + * source coordinates of the plane (in 16.16).
> >> + *
> >> + * When using drm_atomic_helper_check_plane_state(),
> >> + * the coordinates are clipped, but the driver may choose
> >> + * to use unclipped coordinates instead.
> >> + *
> >> + * This can be useful when using a hardcoded size in a cursor plane.
> > I would instead say something like "when the hardware performs
> > the clipping automagically".
>
>
> With that fixed, r-b?
Aye
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/plane: Clarify our expectations for src/dst rectangles
2019-10-10 13:07 ` Ville Syrjälä
@ 2019-10-10 13:49 ` Maarten Lankhorst
0 siblings, 0 replies; 5+ messages in thread
From: Maarten Lankhorst @ 2019-10-10 13:49 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Maxime Ripard, David Airlie, Sean Paul, dri-devel
Op 10-10-2019 om 15:07 schreef Ville Syrjälä:
> On Thu, Oct 10, 2019 at 02:46:26PM +0200, Maarten Lankhorst wrote:
>> Op 10-10-2019 om 14:36 schreef Ville Syrjälä:
>>> On Thu, Oct 10, 2019 at 01:29:17PM +0200, Maarten Lankhorst wrote:
>>>> The rectangles are usually clipped, but it can be useful to have
>>>> them unclipped, for example for cursor planes.
>>>>
>>>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>>>> ---
>>>> include/drm/drm_plane.h | 22 ++++++++++++++++++++--
>>>> 1 file changed, 20 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h
>>>> index cd5903ad33f7..94bbbf215100 100644
>>>> --- a/include/drm/drm_plane.h
>>>> +++ b/include/drm/drm_plane.h
>>>> @@ -183,8 +183,26 @@ struct drm_plane_state {
>>>> */
>>>> struct drm_property_blob *fb_damage_clips;
>>>>
>>>> - /** @src: clipped source coordinates of the plane (in 16.16) */
>>>> - /** @dst: clipped destination coordinates of the plane */
>>>> + /**
>>>> + * @src:
>>>> + *
>>>> + * source coordinates of the plane (in 16.16).
>>>> + *
>>>> + * When using drm_atomic_helper_check_plane_state(),
>>>> + * the coordinates are clipped, but the driver may choose
>>>> + * to use unclipped coordinates instead.
>>>> + *
>>>> + * This can be useful when using a hardcoded size in a cursor plane.
>>> I would instead say something like "when the hardware performs
>>> the clipping automagically".
>>
>> With that fixed, r-b?
> Aye
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
Noticed I dropped the explanation for dst when checking docbook output, fixed and pushed. :)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-10-10 13:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-10 11:29 [PATCH] drm/plane: Clarify our expectations for src/dst rectangles Maarten Lankhorst
2019-10-10 12:36 ` Ville Syrjälä
2019-10-10 12:46 ` Maarten Lankhorst
2019-10-10 13:07 ` Ville Syrjälä
2019-10-10 13:49 ` Maarten Lankhorst
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.