From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: dhowells@redhat.com, peterhuewe@gmx.de, keyrings@vger.kernel.org,
linux-integrity@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-security-module@vger.kernel.org,
herbert@gondor.apana.org.au, davem@davemloft.net, jgg@ziepe.ca,
arnd@arndb.de, gregkh@linuxfoundation.org, jejb@linux.ibm.com,
zohar@linux.ibm.com, jmorris@namei.org, serge@hallyn.com,
jsnitsel@redhat.com, linux-kernel@vger.kernel.org,
daniel.thompson@linaro.org
Subject: Re: [Patch v7 1/4] tpm: Move tpm_buf code to include/linux/
Date: Fri, 11 Oct 2019 11:41:05 +0000 [thread overview]
Message-ID: <20191011114105.GA3129@linux.intel.com> (raw)
In-Reply-To: <1570425935-7435-2-git-send-email-sumit.garg@linaro.org>
On Mon, Oct 07, 2019 at 10:55:32AM +0530, Sumit Garg wrote:
> Move tpm_buf code to common include/linux/tpm.h header so that it can
> be reused via other subsystems like trusted keys etc.
>
> Also rename trusted keys and asymmetric keys usage of TPM 1.x buffer
> implementation to tpm1_buf to avoid any compilation errors.
>
> Suggested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
> ---
> crypto/asymmetric_keys/asym_tpm.c | 12 +--
> drivers/char/tpm/tpm.h | 215 --------------------------------------
> include/keys/trusted.h | 12 +--
> include/linux/tpm.h | 215 ++++++++++++++++++++++++++++++++++++++
> security/keys/trusted.c | 12 +--
> 5 files changed, 233 insertions(+), 233 deletions(-)
Looks clean.
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: dhowells@redhat.com, peterhuewe@gmx.de, keyrings@vger.kernel.org,
linux-integrity@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-security-module@vger.kernel.org,
herbert@gondor.apana.org.au, davem@davemloft.net, jgg@ziepe.ca,
arnd@arndb.de, gregkh@linuxfoundation.org, jejb@linux.ibm.com,
zohar@linux.ibm.com, jmorris@namei.org, serge@hallyn.com,
jsnitsel@redhat.com, linux-kernel@vger.kernel.org,
daniel.thompson@linaro.org
Subject: Re: [Patch v7 1/4] tpm: Move tpm_buf code to include/linux/
Date: Fri, 11 Oct 2019 14:41:05 +0300 [thread overview]
Message-ID: <20191011114105.GA3129@linux.intel.com> (raw)
In-Reply-To: <1570425935-7435-2-git-send-email-sumit.garg@linaro.org>
On Mon, Oct 07, 2019 at 10:55:32AM +0530, Sumit Garg wrote:
> Move tpm_buf code to common include/linux/tpm.h header so that it can
> be reused via other subsystems like trusted keys etc.
>
> Also rename trusted keys and asymmetric keys usage of TPM 1.x buffer
> implementation to tpm1_buf to avoid any compilation errors.
>
> Suggested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
> ---
> crypto/asymmetric_keys/asym_tpm.c | 12 +--
> drivers/char/tpm/tpm.h | 215 --------------------------------------
> include/keys/trusted.h | 12 +--
> include/linux/tpm.h | 215 ++++++++++++++++++++++++++++++++++++++
> security/keys/trusted.c | 12 +--
> 5 files changed, 233 insertions(+), 233 deletions(-)
Looks clean.
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
next prev parent reply other threads:[~2019-10-11 11:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 5:25 [Patch v7 0/4] Create and consolidate trusted keys subsystem Sumit Garg
2019-10-07 5:37 ` Sumit Garg
2019-10-07 5:25 ` [Patch v7 1/4] tpm: Move tpm_buf code to include/linux/ Sumit Garg
2019-10-07 5:37 ` Sumit Garg
2019-10-11 11:41 ` Jarkko Sakkinen [this message]
2019-10-11 11:41 ` Jarkko Sakkinen
2019-10-11 22:33 ` Jerry Snitselaar
2019-10-11 22:33 ` Jerry Snitselaar
2019-10-07 5:25 ` [Patch v7 2/4] KEYS: Use common tpm_buf for trusted and asymmetric keys Sumit Garg
2019-10-07 5:37 ` Sumit Garg
2019-10-11 11:47 ` Jarkko Sakkinen
2019-10-11 11:47 ` Jarkko Sakkinen
2019-10-11 22:34 ` Jerry Snitselaar
2019-10-11 22:34 ` Jerry Snitselaar
2019-10-07 5:25 ` [Patch v7 3/4] KEYS: trusted: Create trusted keys subsystem Sumit Garg
2019-10-07 5:37 ` Sumit Garg
2019-10-07 5:25 ` [Patch v7 4/4] KEYS: trusted: Move TPM2 trusted keys code Sumit Garg
2019-10-07 5:37 ` Sumit Garg
2019-10-11 12:25 ` Jarkko Sakkinen
2019-10-11 12:25 ` Jarkko Sakkinen
2019-10-11 12:37 ` [Patch v7 0/4] Create and consolidate trusted keys subsystem Jarkko Sakkinen
2019-10-11 12:37 ` Jarkko Sakkinen
2019-10-11 21:05 ` Jerry Snitselaar
2019-10-11 21:05 ` Jerry Snitselaar
2019-10-14 20:16 ` Jarkko Sakkinen
2019-10-14 20:16 ` Jarkko Sakkinen
2019-10-15 8:32 ` Sumit Garg
2019-10-15 8:44 ` Sumit Garg
2019-10-14 19:33 ` Jarkko Sakkinen
2019-10-14 19:33 ` Jarkko Sakkinen
2019-10-15 8:28 ` Sumit Garg
2019-10-15 8:40 ` Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011114105.GA3129@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=arnd@arndb.de \
--cc=daniel.thompson@linaro.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=jejb@linux.ibm.com \
--cc=jgg@ziepe.ca \
--cc=jmorris@namei.org \
--cc=jsnitsel@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=serge@hallyn.com \
--cc=sumit.garg@linaro.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.