From: Jonathan Cameron <jic23@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v4 3/8] iio: adc: max1027: Reset the device at probe time
Date: Sat, 12 Oct 2019 12:28:10 +0100 [thread overview]
Message-ID: <20191012122810.5330fd7f@archlinux> (raw)
In-Reply-To: <20191011144347.19146-4-miquel.raynal@bootlin.com>
On Fri, 11 Oct 2019 16:43:42 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> All the registers are configured by the driver, let's reset the chip
> at probe time, avoiding any conflict with a possible earlier
> configuration.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Applied.
Thanks,
Jonathan
> ---
> drivers/iio/adc/max1027.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/iio/adc/max1027.c b/drivers/iio/adc/max1027.c
> index 823223b77a70..f9b473ee6711 100644
> --- a/drivers/iio/adc/max1027.c
> +++ b/drivers/iio/adc/max1027.c
> @@ -466,6 +466,14 @@ static int max1027_probe(struct spi_device *spi)
> }
> }
>
> + /* Internal reset */
> + st->reg = MAX1027_RST_REG;
> + ret = spi_write(st->spi, &st->reg, 1);
> + if (ret < 0) {
> + dev_err(&indio_dev->dev, "Failed to reset the ADC\n");
> + return ret;
> + }
> +
> /* Disable averaging */
> st->reg = MAX1027_AVG_REG;
> ret = spi_write(st->spi, &st->reg, 1);
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v4 3/8] iio: adc: max1027: Reset the device at probe time
Date: Sat, 12 Oct 2019 12:28:10 +0100 [thread overview]
Message-ID: <20191012122810.5330fd7f@archlinux> (raw)
In-Reply-To: <20191011144347.19146-4-miquel.raynal@bootlin.com>
On Fri, 11 Oct 2019 16:43:42 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> All the registers are configured by the driver, let's reset the chip
> at probe time, avoiding any conflict with a possible earlier
> configuration.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Applied.
Thanks,
Jonathan
> ---
> drivers/iio/adc/max1027.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/iio/adc/max1027.c b/drivers/iio/adc/max1027.c
> index 823223b77a70..f9b473ee6711 100644
> --- a/drivers/iio/adc/max1027.c
> +++ b/drivers/iio/adc/max1027.c
> @@ -466,6 +466,14 @@ static int max1027_probe(struct spi_device *spi)
> }
> }
>
> + /* Internal reset */
> + st->reg = MAX1027_RST_REG;
> + ret = spi_write(st->spi, &st->reg, 1);
> + if (ret < 0) {
> + dev_err(&indio_dev->dev, "Failed to reset the ADC\n");
> + return ret;
> + }
> +
> /* Disable averaging */
> st->reg = MAX1027_AVG_REG;
> ret = spi_write(st->spi, &st->reg, 1);
next prev parent reply other threads:[~2019-10-12 11:34 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 14:43 [PATCH v4 0/8] Introduce max12xx ADC support Miquel Raynal
2019-10-11 14:43 ` Miquel Raynal
2019-10-11 14:43 ` [PATCH v4 1/8] iio: adc: max1027: Add debugfs register read support Miquel Raynal
2019-10-11 14:43 ` Miquel Raynal
2019-10-12 11:25 ` Jonathan Cameron
2019-10-12 11:25 ` Jonathan Cameron
2019-10-11 14:43 ` [PATCH v4 2/8] iio: adc: max1027: Make it optional to use interrupts Miquel Raynal
2019-10-11 14:43 ` Miquel Raynal
2019-10-12 11:34 ` Jonathan Cameron
2019-10-12 11:34 ` Jonathan Cameron
2019-10-11 14:43 ` [PATCH v4 3/8] iio: adc: max1027: Reset the device at probe time Miquel Raynal
2019-10-11 14:43 ` Miquel Raynal
2019-10-12 11:28 ` Jonathan Cameron [this message]
2019-10-12 11:28 ` Jonathan Cameron
2019-10-11 14:43 ` [PATCH v4 4/8] iio: adc: max1027: Prepare the introduction of different resolutions Miquel Raynal
2019-10-11 14:43 ` Miquel Raynal
2019-10-12 11:29 ` Jonathan Cameron
2019-10-12 11:29 ` Jonathan Cameron
2019-10-11 14:43 ` [PATCH v4 5/8] iio: adc: max1027: Introduce 12-bit devices support Miquel Raynal
2019-10-11 14:43 ` Miquel Raynal
2019-10-12 11:30 ` Jonathan Cameron
2019-10-12 11:30 ` Jonathan Cameron
2019-10-11 14:43 ` [PATCH v4 6/8] dt-bindings: iio: adc: max1027: Mark interrupts as optional Miquel Raynal
2019-10-11 14:43 ` Miquel Raynal
2019-10-12 11:31 ` Jonathan Cameron
2019-10-12 11:31 ` Jonathan Cameron
2019-10-11 14:43 ` [PATCH v4 7/8] dt-bindings: Add 1027/1029/1031 SPI ADCs as trivial devices Miquel Raynal
2019-10-11 14:43 ` Miquel Raynal
2019-10-14 15:38 ` Rob Herring
2019-10-14 15:38 ` Rob Herring
2019-10-11 14:43 ` [PATCH v4 8/8] dt-bindings: Add max12xx SPI ADC series " Miquel Raynal
2019-10-11 14:43 ` Miquel Raynal
2019-10-12 11:32 ` Jonathan Cameron
2019-10-12 11:32 ` Jonathan Cameron
2019-10-14 15:38 ` Rob Herring
2019-10-14 15:38 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191012122810.5330fd7f@archlinux \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.