From: Richard Cochran <richardcochran@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [net-next v3 6/7] mlx5: reject unsupported external timestamp flags
Date: Sat, 12 Oct 2019 11:36:32 -0700 [thread overview]
Message-ID: <20191012183632.GG3165@localhost> (raw)
In-Reply-To: <20190926181109.4871-7-jacob.e.keller@intel.com>
On Thu, Sep 26, 2019 at 11:11:08AM -0700, Jacob Keller wrote:
> Fix the mlx5 core PTP support to explicitly reject any future flags that
> get added to the external timestamp request ioctl.
>
> In order to maintain currently functioning code, this patch accepts all
> three current flags. This is because the PTP_RISING_EDGE and
> PTP_FALLING_EDGE flags have unclear semantics and each driver seems to
> have interpreted them slightly differently.
I'm not 100% sure what this driver does, but if I'm not wrong it
follows the dp83640:
flags Meaning
---------------------------------------------------- --------------------------
PTP_ENABLE_FEATURE Time stamp rising edge
PTP_ENABLE_FEATURE|PTP_RISING_EDGE Time stamp rising edge
PTP_ENABLE_FEATURE|PTP_FALLING_EDGE Time stamp falling edge
PTP_ENABLE_FEATURE|PTP_RISING_EDGE|PTP_FALLING_EDGE Time stamp falling edge
> Cc: Feras Daoud <ferasda@mellanox.com>
> Cc: Eugenia Emantayev <eugenia@mellanox.com>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Richard Cochran <richardcochran@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: Richard Cochran <richardcochran@gmail.com>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: netdev@vger.kernel.org,
Intel Wired LAN <intel-wired-lan@lists.osuosl.org>,
Jeffrey Kirsher <jeffrey.t.kirsher@intel.com>,
Feras Daoud <ferasda@mellanox.com>,
Eugenia Emantayev <eugenia@mellanox.com>
Subject: Re: [net-next v3 6/7] mlx5: reject unsupported external timestamp flags
Date: Sat, 12 Oct 2019 11:36:32 -0700 [thread overview]
Message-ID: <20191012183632.GG3165@localhost> (raw)
In-Reply-To: <20190926181109.4871-7-jacob.e.keller@intel.com>
On Thu, Sep 26, 2019 at 11:11:08AM -0700, Jacob Keller wrote:
> Fix the mlx5 core PTP support to explicitly reject any future flags that
> get added to the external timestamp request ioctl.
>
> In order to maintain currently functioning code, this patch accepts all
> three current flags. This is because the PTP_RISING_EDGE and
> PTP_FALLING_EDGE flags have unclear semantics and each driver seems to
> have interpreted them slightly differently.
I'm not 100% sure what this driver does, but if I'm not wrong it
follows the dp83640:
flags Meaning
---------------------------------------------------- --------------------------
PTP_ENABLE_FEATURE Time stamp rising edge
PTP_ENABLE_FEATURE|PTP_RISING_EDGE Time stamp rising edge
PTP_ENABLE_FEATURE|PTP_FALLING_EDGE Time stamp falling edge
PTP_ENABLE_FEATURE|PTP_RISING_EDGE|PTP_FALLING_EDGE Time stamp falling edge
> Cc: Feras Daoud <ferasda@mellanox.com>
> Cc: Eugenia Emantayev <eugenia@mellanox.com>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Richard Cochran <richardcochran@gmail.com>
next prev parent reply other threads:[~2019-10-12 18:36 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 18:11 [Intel-wired-lan] [net-next v3 0/7] new PTP ioctl fixes Jacob Keller
2019-09-26 18:11 ` Jacob Keller
2019-09-26 18:11 ` [Intel-wired-lan] [net-next v3 1/7] ptp: correctly disable flags on old ioctls Jacob Keller
2019-09-26 18:11 ` Jacob Keller
2019-10-11 1:03 ` [Intel-wired-lan] " Brown, Aaron F
2019-10-11 1:03 ` Brown, Aaron F
2019-09-26 18:11 ` [Intel-wired-lan] [net-next v3 2/7] net: reject PTP periodic output requests with unsupported flags Jacob Keller
2019-09-26 18:11 ` Jacob Keller
2019-10-11 1:05 ` [Intel-wired-lan] " Brown, Aaron F
2019-10-11 1:05 ` Brown, Aaron F
2019-10-12 18:08 ` [Intel-wired-lan] " Richard Cochran
2019-10-12 18:08 ` Richard Cochran
2019-09-26 18:11 ` [Intel-wired-lan] [net-next v3 3/7] mv88e6xxx: reject unsupported external timestamp flags Jacob Keller
2019-09-26 18:11 ` Jacob Keller
2019-10-12 18:24 ` [Intel-wired-lan] " Richard Cochran
2019-10-12 18:24 ` Richard Cochran
2019-10-12 19:36 ` [Intel-wired-lan] " Keller, Jacob E
2019-10-12 19:36 ` Keller, Jacob E
2019-10-12 23:27 ` [Intel-wired-lan] " Richard Cochran
2019-10-12 23:27 ` Richard Cochran
2019-10-14 17:20 ` [Intel-wired-lan] " Keller, Jacob E
2019-10-14 17:20 ` Keller, Jacob E
2019-09-26 18:11 ` [Intel-wired-lan] [net-next v3 4/7] dp83640: " Jacob Keller
2019-09-26 18:11 ` Jacob Keller
2019-10-12 18:28 ` [Intel-wired-lan] " Richard Cochran
2019-10-12 18:28 ` Richard Cochran
2019-09-26 18:11 ` [Intel-wired-lan] [net-next v3 5/7] igb: " Jacob Keller
2019-09-26 18:11 ` Jacob Keller
2019-10-11 0:57 ` [Intel-wired-lan] " Brown, Aaron F
2019-10-11 0:57 ` Brown, Aaron F
2019-10-12 18:31 ` Richard Cochran
2019-10-12 18:31 ` Richard Cochran
2019-09-26 18:11 ` [Intel-wired-lan] [net-next v3 6/7] mlx5: " Jacob Keller
2019-09-26 18:11 ` Jacob Keller
2019-10-12 18:36 ` Richard Cochran [this message]
2019-10-12 18:36 ` Richard Cochran
2019-09-26 18:11 ` [Intel-wired-lan] [net-next v3 7/7] renesas: " Jacob Keller
2019-09-26 18:11 ` Jacob Keller
2019-09-27 16:22 ` [Intel-wired-lan] " Sergei Shtylyov
2019-09-27 16:22 ` Sergei Shtylyov
2019-10-12 18:38 ` [Intel-wired-lan] " Richard Cochran
2019-10-12 18:38 ` Richard Cochran
2019-09-27 18:29 ` [Intel-wired-lan] [net-next v3 0/7] new PTP ioctl fixes David Miller
2019-09-27 18:29 ` David Miller
2019-09-27 22:16 ` [Intel-wired-lan] " Keller, Jacob E
2019-09-27 22:16 ` Keller, Jacob E
2019-11-13 1:58 ` [Intel-wired-lan] " Richard Cochran
2019-11-13 1:58 ` Richard Cochran
2019-11-13 17:10 ` [Intel-wired-lan] " Richard Cochran
2019-11-13 17:10 ` Richard Cochran
2019-11-13 19:34 ` [Intel-wired-lan] " Richard Cochran
2019-11-13 19:34 ` Richard Cochran
2019-11-13 19:58 ` [Intel-wired-lan] " Keller, Jacob E
2019-11-13 19:58 ` Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191012183632.GG3165@localhost \
--to=richardcochran@gmail.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.