* [PATCH] tools/virtio: Fix build
@ 2019-10-13 9:03 Jan Kiszka
2019-10-13 11:52 ` Michael S. Tsirkin
2019-10-13 11:52 ` Michael S. Tsirkin
0 siblings, 2 replies; 15+ messages in thread
From: Jan Kiszka @ 2019-10-13 9:03 UTC (permalink / raw)
To: Michael S. Tsirkin, Jason Wang,
virtualization@lists.linux-foundation.org
Cc: Linux Kernel Mailing List
From: Jan Kiszka <jan.kiszka@siemens.com>
Various changes in the recent kernel versions broke the build due to
missing function and header stubs.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
tools/virtio/crypto/hash.h | 0
tools/virtio/linux/dma-mapping.h | 2 ++
tools/virtio/linux/kernel.h | 2 ++
3 files changed, 4 insertions(+)
create mode 100644 tools/virtio/crypto/hash.h
diff --git a/tools/virtio/crypto/hash.h b/tools/virtio/crypto/hash.h
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/tools/virtio/linux/dma-mapping.h b/tools/virtio/linux/dma-mapping.h
index f91aeb5fe571..db96cb4bf877 100644
--- a/tools/virtio/linux/dma-mapping.h
+++ b/tools/virtio/linux/dma-mapping.h
@@ -29,4 +29,6 @@ enum dma_data_direction {
#define dma_unmap_single(...) do { } while (0)
#define dma_unmap_page(...) do { } while (0)
+#define dma_max_mapping_size(d) 0
+
#endif
diff --git a/tools/virtio/linux/kernel.h b/tools/virtio/linux/kernel.h
index 6683b4a70b05..ccf321173210 100644
--- a/tools/virtio/linux/kernel.h
+++ b/tools/virtio/linux/kernel.h
@@ -141,4 +141,6 @@ static inline void free_page(unsigned long addr)
#define list_for_each_entry(a, b, c) while (0)
/* end of stubs */
+#define xen_domain() 0
+
#endif /* KERNEL_H */
--
2.16.4
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH] tools/virtio: Fix build
@ 2019-10-13 9:03 Jan Kiszka
0 siblings, 0 replies; 15+ messages in thread
From: Jan Kiszka @ 2019-10-13 9:03 UTC (permalink / raw)
To: Michael S. Tsirkin, Jason Wang,
virtualization@lists.linux-foundation.org
Cc: Linux Kernel Mailing List
From: Jan Kiszka <jan.kiszka@siemens.com>
Various changes in the recent kernel versions broke the build due to
missing function and header stubs.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
tools/virtio/crypto/hash.h | 0
tools/virtio/linux/dma-mapping.h | 2 ++
tools/virtio/linux/kernel.h | 2 ++
3 files changed, 4 insertions(+)
create mode 100644 tools/virtio/crypto/hash.h
diff --git a/tools/virtio/crypto/hash.h b/tools/virtio/crypto/hash.h
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/tools/virtio/linux/dma-mapping.h b/tools/virtio/linux/dma-mapping.h
index f91aeb5fe571..db96cb4bf877 100644
--- a/tools/virtio/linux/dma-mapping.h
+++ b/tools/virtio/linux/dma-mapping.h
@@ -29,4 +29,6 @@ enum dma_data_direction {
#define dma_unmap_single(...) do { } while (0)
#define dma_unmap_page(...) do { } while (0)
+#define dma_max_mapping_size(d) 0
+
#endif
diff --git a/tools/virtio/linux/kernel.h b/tools/virtio/linux/kernel.h
index 6683b4a70b05..ccf321173210 100644
--- a/tools/virtio/linux/kernel.h
+++ b/tools/virtio/linux/kernel.h
@@ -141,4 +141,6 @@ static inline void free_page(unsigned long addr)
#define list_for_each_entry(a, b, c) while (0)
/* end of stubs */
+#define xen_domain() 0
+
#endif /* KERNEL_H */
--
2.16.4
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH] tools/virtio: Fix build
2019-10-13 9:03 [PATCH] tools/virtio: Fix build Jan Kiszka
@ 2019-10-13 11:52 ` Michael S. Tsirkin
2019-10-13 11:52 ` Michael S. Tsirkin
1 sibling, 0 replies; 15+ messages in thread
From: Michael S. Tsirkin @ 2019-10-13 11:52 UTC (permalink / raw)
To: Jan Kiszka
Cc: Linux Kernel Mailing List,
virtualization@lists.linux-foundation.org
On Sun, Oct 13, 2019 at 11:03:30AM +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Various changes in the recent kernel versions broke the build due to
> missing function and header stubs.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Thanks!
I think it's already fixes in the vhost tree.
That tree also includes a bugfix for the test.
Can you pls give it a spin and report?
Thanks!
> ---
> tools/virtio/crypto/hash.h | 0
> tools/virtio/linux/dma-mapping.h | 2 ++
> tools/virtio/linux/kernel.h | 2 ++
> 3 files changed, 4 insertions(+)
> create mode 100644 tools/virtio/crypto/hash.h
>
> diff --git a/tools/virtio/crypto/hash.h b/tools/virtio/crypto/hash.h
> new file mode 100644
> index 000000000000..e69de29bb2d1
> diff --git a/tools/virtio/linux/dma-mapping.h b/tools/virtio/linux/dma-mapping.h
> index f91aeb5fe571..db96cb4bf877 100644
> --- a/tools/virtio/linux/dma-mapping.h
> +++ b/tools/virtio/linux/dma-mapping.h
> @@ -29,4 +29,6 @@ enum dma_data_direction {
> #define dma_unmap_single(...) do { } while (0)
> #define dma_unmap_page(...) do { } while (0)
>
> +#define dma_max_mapping_size(d) 0
> +
> #endif
> diff --git a/tools/virtio/linux/kernel.h b/tools/virtio/linux/kernel.h
> index 6683b4a70b05..ccf321173210 100644
> --- a/tools/virtio/linux/kernel.h
> +++ b/tools/virtio/linux/kernel.h
> @@ -141,4 +141,6 @@ static inline void free_page(unsigned long addr)
> #define list_for_each_entry(a, b, c) while (0)
> /* end of stubs */
>
> +#define xen_domain() 0
> +
> #endif /* KERNEL_H */
> --
> 2.16.4
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] tools/virtio: Fix build
2019-10-13 9:03 [PATCH] tools/virtio: Fix build Jan Kiszka
2019-10-13 11:52 ` Michael S. Tsirkin
@ 2019-10-13 11:52 ` Michael S. Tsirkin
2019-10-13 12:01 ` Jan Kiszka
2019-10-13 12:01 ` Jan Kiszka
1 sibling, 2 replies; 15+ messages in thread
From: Michael S. Tsirkin @ 2019-10-13 11:52 UTC (permalink / raw)
To: Jan Kiszka
Cc: Jason Wang, virtualization@lists.linux-foundation.org,
Linux Kernel Mailing List
On Sun, Oct 13, 2019 at 11:03:30AM +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Various changes in the recent kernel versions broke the build due to
> missing function and header stubs.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Thanks!
I think it's already fixes in the vhost tree.
That tree also includes a bugfix for the test.
Can you pls give it a spin and report?
Thanks!
> ---
> tools/virtio/crypto/hash.h | 0
> tools/virtio/linux/dma-mapping.h | 2 ++
> tools/virtio/linux/kernel.h | 2 ++
> 3 files changed, 4 insertions(+)
> create mode 100644 tools/virtio/crypto/hash.h
>
> diff --git a/tools/virtio/crypto/hash.h b/tools/virtio/crypto/hash.h
> new file mode 100644
> index 000000000000..e69de29bb2d1
> diff --git a/tools/virtio/linux/dma-mapping.h b/tools/virtio/linux/dma-mapping.h
> index f91aeb5fe571..db96cb4bf877 100644
> --- a/tools/virtio/linux/dma-mapping.h
> +++ b/tools/virtio/linux/dma-mapping.h
> @@ -29,4 +29,6 @@ enum dma_data_direction {
> #define dma_unmap_single(...) do { } while (0)
> #define dma_unmap_page(...) do { } while (0)
>
> +#define dma_max_mapping_size(d) 0
> +
> #endif
> diff --git a/tools/virtio/linux/kernel.h b/tools/virtio/linux/kernel.h
> index 6683b4a70b05..ccf321173210 100644
> --- a/tools/virtio/linux/kernel.h
> +++ b/tools/virtio/linux/kernel.h
> @@ -141,4 +141,6 @@ static inline void free_page(unsigned long addr)
> #define list_for_each_entry(a, b, c) while (0)
> /* end of stubs */
>
> +#define xen_domain() 0
> +
> #endif /* KERNEL_H */
> --
> 2.16.4
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] tools/virtio: Fix build
2019-10-13 11:52 ` Michael S. Tsirkin
@ 2019-10-13 12:01 ` Jan Kiszka
2019-10-13 12:01 ` Jan Kiszka
1 sibling, 0 replies; 15+ messages in thread
From: Jan Kiszka @ 2019-10-13 12:01 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Linux Kernel Mailing List,
virtualization@lists.linux-foundation.org
On 13.10.19 13:52, Michael S. Tsirkin wrote:
> On Sun, Oct 13, 2019 at 11:03:30AM +0200, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Various changes in the recent kernel versions broke the build due to
>> missing function and header stubs.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>
> Thanks!
> I think it's already fixes in the vhost tree.
> That tree also includes a bugfix for the test.
> Can you pls give it a spin and report?
Mostly fixed: the xen_domain stup is missing.
Jan
> Thanks!
>
>> ---
>> tools/virtio/crypto/hash.h | 0
>> tools/virtio/linux/dma-mapping.h | 2 ++
>> tools/virtio/linux/kernel.h | 2 ++
>> 3 files changed, 4 insertions(+)
>> create mode 100644 tools/virtio/crypto/hash.h
>>
>> diff --git a/tools/virtio/crypto/hash.h b/tools/virtio/crypto/hash.h
>> new file mode 100644
>> index 000000000000..e69de29bb2d1
>> diff --git a/tools/virtio/linux/dma-mapping.h b/tools/virtio/linux/dma-mapping.h
>> index f91aeb5fe571..db96cb4bf877 100644
>> --- a/tools/virtio/linux/dma-mapping.h
>> +++ b/tools/virtio/linux/dma-mapping.h
>> @@ -29,4 +29,6 @@ enum dma_data_direction {
>> #define dma_unmap_single(...) do { } while (0)
>> #define dma_unmap_page(...) do { } while (0)
>>
>> +#define dma_max_mapping_size(d) 0
>> +
>> #endif
>> diff --git a/tools/virtio/linux/kernel.h b/tools/virtio/linux/kernel.h
>> index 6683b4a70b05..ccf321173210 100644
>> --- a/tools/virtio/linux/kernel.h
>> +++ b/tools/virtio/linux/kernel.h
>> @@ -141,4 +141,6 @@ static inline void free_page(unsigned long addr)
>> #define list_for_each_entry(a, b, c) while (0)
>> /* end of stubs */
>>
>> +#define xen_domain() 0
>> +
>> #endif /* KERNEL_H */
>> --
>> 2.16.4
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] tools/virtio: Fix build
2019-10-13 11:52 ` Michael S. Tsirkin
2019-10-13 12:01 ` Jan Kiszka
@ 2019-10-13 12:01 ` Jan Kiszka
2019-10-13 12:20 ` Michael S. Tsirkin
2019-10-13 12:20 ` Michael S. Tsirkin
1 sibling, 2 replies; 15+ messages in thread
From: Jan Kiszka @ 2019-10-13 12:01 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Jason Wang, virtualization@lists.linux-foundation.org,
Linux Kernel Mailing List
On 13.10.19 13:52, Michael S. Tsirkin wrote:
> On Sun, Oct 13, 2019 at 11:03:30AM +0200, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Various changes in the recent kernel versions broke the build due to
>> missing function and header stubs.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>
> Thanks!
> I think it's already fixes in the vhost tree.
> That tree also includes a bugfix for the test.
> Can you pls give it a spin and report?
Mostly fixed: the xen_domain stup is missing.
Jan
> Thanks!
>
>> ---
>> tools/virtio/crypto/hash.h | 0
>> tools/virtio/linux/dma-mapping.h | 2 ++
>> tools/virtio/linux/kernel.h | 2 ++
>> 3 files changed, 4 insertions(+)
>> create mode 100644 tools/virtio/crypto/hash.h
>>
>> diff --git a/tools/virtio/crypto/hash.h b/tools/virtio/crypto/hash.h
>> new file mode 100644
>> index 000000000000..e69de29bb2d1
>> diff --git a/tools/virtio/linux/dma-mapping.h b/tools/virtio/linux/dma-mapping.h
>> index f91aeb5fe571..db96cb4bf877 100644
>> --- a/tools/virtio/linux/dma-mapping.h
>> +++ b/tools/virtio/linux/dma-mapping.h
>> @@ -29,4 +29,6 @@ enum dma_data_direction {
>> #define dma_unmap_single(...) do { } while (0)
>> #define dma_unmap_page(...) do { } while (0)
>>
>> +#define dma_max_mapping_size(d) 0
>> +
>> #endif
>> diff --git a/tools/virtio/linux/kernel.h b/tools/virtio/linux/kernel.h
>> index 6683b4a70b05..ccf321173210 100644
>> --- a/tools/virtio/linux/kernel.h
>> +++ b/tools/virtio/linux/kernel.h
>> @@ -141,4 +141,6 @@ static inline void free_page(unsigned long addr)
>> #define list_for_each_entry(a, b, c) while (0)
>> /* end of stubs */
>>
>> +#define xen_domain() 0
>> +
>> #endif /* KERNEL_H */
>> --
>> 2.16.4
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] tools/virtio: Fix build
2019-10-13 12:01 ` Jan Kiszka
@ 2019-10-13 12:20 ` Michael S. Tsirkin
2019-10-13 12:20 ` Michael S. Tsirkin
1 sibling, 0 replies; 15+ messages in thread
From: Michael S. Tsirkin @ 2019-10-13 12:20 UTC (permalink / raw)
To: Jan Kiszka
Cc: Linux Kernel Mailing List,
virtualization@lists.linux-foundation.org
On Sun, Oct 13, 2019 at 02:01:03PM +0200, Jan Kiszka wrote:
> On 13.10.19 13:52, Michael S. Tsirkin wrote:
> > On Sun, Oct 13, 2019 at 11:03:30AM +0200, Jan Kiszka wrote:
> >> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>
> >> Various changes in the recent kernel versions broke the build due to
> >> missing function and header stubs.
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> >
> > Thanks!
> > I think it's already fixes in the vhost tree.
> > That tree also includes a bugfix for the test.
> > Can you pls give it a spin and report?
>
> Mostly fixed: the xen_domain stup is missing.
>
> Jan
That's in xen/xen.h. Do you still see any build errors?
> > Thanks!
> >
> >> ---
> >> tools/virtio/crypto/hash.h | 0
> >> tools/virtio/linux/dma-mapping.h | 2 ++
> >> tools/virtio/linux/kernel.h | 2 ++
> >> 3 files changed, 4 insertions(+)
> >> create mode 100644 tools/virtio/crypto/hash.h
> >>
> >> diff --git a/tools/virtio/crypto/hash.h b/tools/virtio/crypto/hash.h
> >> new file mode 100644
> >> index 000000000000..e69de29bb2d1
> >> diff --git a/tools/virtio/linux/dma-mapping.h b/tools/virtio/linux/dma-mapping.h
> >> index f91aeb5fe571..db96cb4bf877 100644
> >> --- a/tools/virtio/linux/dma-mapping.h
> >> +++ b/tools/virtio/linux/dma-mapping.h
> >> @@ -29,4 +29,6 @@ enum dma_data_direction {
> >> #define dma_unmap_single(...) do { } while (0)
> >> #define dma_unmap_page(...) do { } while (0)
> >>
> >> +#define dma_max_mapping_size(d) 0
> >> +
> >> #endif
> >> diff --git a/tools/virtio/linux/kernel.h b/tools/virtio/linux/kernel.h
> >> index 6683b4a70b05..ccf321173210 100644
> >> --- a/tools/virtio/linux/kernel.h
> >> +++ b/tools/virtio/linux/kernel.h
> >> @@ -141,4 +141,6 @@ static inline void free_page(unsigned long addr)
> >> #define list_for_each_entry(a, b, c) while (0)
> >> /* end of stubs */
> >>
> >> +#define xen_domain() 0
> >> +
> >> #endif /* KERNEL_H */
> >> --
> >> 2.16.4
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] tools/virtio: Fix build
2019-10-13 12:01 ` Jan Kiszka
2019-10-13 12:20 ` Michael S. Tsirkin
@ 2019-10-13 12:20 ` Michael S. Tsirkin
2019-10-13 13:29 ` Jan Kiszka
2019-10-13 13:29 ` Jan Kiszka
1 sibling, 2 replies; 15+ messages in thread
From: Michael S. Tsirkin @ 2019-10-13 12:20 UTC (permalink / raw)
To: Jan Kiszka
Cc: Jason Wang, virtualization@lists.linux-foundation.org,
Linux Kernel Mailing List
On Sun, Oct 13, 2019 at 02:01:03PM +0200, Jan Kiszka wrote:
> On 13.10.19 13:52, Michael S. Tsirkin wrote:
> > On Sun, Oct 13, 2019 at 11:03:30AM +0200, Jan Kiszka wrote:
> >> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>
> >> Various changes in the recent kernel versions broke the build due to
> >> missing function and header stubs.
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> >
> > Thanks!
> > I think it's already fixes in the vhost tree.
> > That tree also includes a bugfix for the test.
> > Can you pls give it a spin and report?
>
> Mostly fixed: the xen_domain stup is missing.
>
> Jan
That's in xen/xen.h. Do you still see any build errors?
> > Thanks!
> >
> >> ---
> >> tools/virtio/crypto/hash.h | 0
> >> tools/virtio/linux/dma-mapping.h | 2 ++
> >> tools/virtio/linux/kernel.h | 2 ++
> >> 3 files changed, 4 insertions(+)
> >> create mode 100644 tools/virtio/crypto/hash.h
> >>
> >> diff --git a/tools/virtio/crypto/hash.h b/tools/virtio/crypto/hash.h
> >> new file mode 100644
> >> index 000000000000..e69de29bb2d1
> >> diff --git a/tools/virtio/linux/dma-mapping.h b/tools/virtio/linux/dma-mapping.h
> >> index f91aeb5fe571..db96cb4bf877 100644
> >> --- a/tools/virtio/linux/dma-mapping.h
> >> +++ b/tools/virtio/linux/dma-mapping.h
> >> @@ -29,4 +29,6 @@ enum dma_data_direction {
> >> #define dma_unmap_single(...) do { } while (0)
> >> #define dma_unmap_page(...) do { } while (0)
> >>
> >> +#define dma_max_mapping_size(d) 0
> >> +
> >> #endif
> >> diff --git a/tools/virtio/linux/kernel.h b/tools/virtio/linux/kernel.h
> >> index 6683b4a70b05..ccf321173210 100644
> >> --- a/tools/virtio/linux/kernel.h
> >> +++ b/tools/virtio/linux/kernel.h
> >> @@ -141,4 +141,6 @@ static inline void free_page(unsigned long addr)
> >> #define list_for_each_entry(a, b, c) while (0)
> >> /* end of stubs */
> >>
> >> +#define xen_domain() 0
> >> +
> >> #endif /* KERNEL_H */
> >> --
> >> 2.16.4
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] tools/virtio: Fix build
2019-10-13 12:20 ` Michael S. Tsirkin
@ 2019-10-13 13:29 ` Jan Kiszka
2019-10-13 13:29 ` Jan Kiszka
1 sibling, 0 replies; 15+ messages in thread
From: Jan Kiszka @ 2019-10-13 13:29 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Linux Kernel Mailing List,
virtualization@lists.linux-foundation.org
On 13.10.19 14:20, Michael S. Tsirkin wrote:
> On Sun, Oct 13, 2019 at 02:01:03PM +0200, Jan Kiszka wrote:
>> On 13.10.19 13:52, Michael S. Tsirkin wrote:
>>> On Sun, Oct 13, 2019 at 11:03:30AM +0200, Jan Kiszka wrote:
>>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>>
>>>> Various changes in the recent kernel versions broke the build due to
>>>> missing function and header stubs.
>>>>
>>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>>
>>> Thanks!
>>> I think it's already fixes in the vhost tree.
>>> That tree also includes a bugfix for the test.
>>> Can you pls give it a spin and report?
>>
>> Mostly fixed: the xen_domain stup is missing.
>>
>> Jan
>
> That's in xen/xen.h. Do you still see any build errors?
ca16cf7b30ca79eeca4d612af121e664ee7d8737 lacks this - forgot to add to
some commit?
Jan
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] tools/virtio: Fix build
2019-10-13 12:20 ` Michael S. Tsirkin
2019-10-13 13:29 ` Jan Kiszka
@ 2019-10-13 13:29 ` Jan Kiszka
2019-10-13 13:39 ` Michael S. Tsirkin
2019-10-13 13:39 ` Michael S. Tsirkin
1 sibling, 2 replies; 15+ messages in thread
From: Jan Kiszka @ 2019-10-13 13:29 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Jason Wang, virtualization@lists.linux-foundation.org,
Linux Kernel Mailing List
On 13.10.19 14:20, Michael S. Tsirkin wrote:
> On Sun, Oct 13, 2019 at 02:01:03PM +0200, Jan Kiszka wrote:
>> On 13.10.19 13:52, Michael S. Tsirkin wrote:
>>> On Sun, Oct 13, 2019 at 11:03:30AM +0200, Jan Kiszka wrote:
>>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>>
>>>> Various changes in the recent kernel versions broke the build due to
>>>> missing function and header stubs.
>>>>
>>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>>
>>> Thanks!
>>> I think it's already fixes in the vhost tree.
>>> That tree also includes a bugfix for the test.
>>> Can you pls give it a spin and report?
>>
>> Mostly fixed: the xen_domain stup is missing.
>>
>> Jan
>
> That's in xen/xen.h. Do you still see any build errors?
ca16cf7b30ca79eeca4d612af121e664ee7d8737 lacks this - forgot to add to
some commit?
Jan
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] tools/virtio: Fix build
2019-10-13 13:29 ` Jan Kiszka
@ 2019-10-13 13:39 ` Michael S. Tsirkin
2019-10-13 13:39 ` Michael S. Tsirkin
1 sibling, 0 replies; 15+ messages in thread
From: Michael S. Tsirkin @ 2019-10-13 13:39 UTC (permalink / raw)
To: Jan Kiszka
Cc: Linux Kernel Mailing List,
virtualization@lists.linux-foundation.org
On Sun, Oct 13, 2019 at 03:29:34PM +0200, Jan Kiszka wrote:
> On 13.10.19 14:20, Michael S. Tsirkin wrote:
> > On Sun, Oct 13, 2019 at 02:01:03PM +0200, Jan Kiszka wrote:
> >> On 13.10.19 13:52, Michael S. Tsirkin wrote:
> >>> On Sun, Oct 13, 2019 at 11:03:30AM +0200, Jan Kiszka wrote:
> >>>> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>>>
> >>>> Various changes in the recent kernel versions broke the build due to
> >>>> missing function and header stubs.
> >>>>
> >>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> >>>
> >>> Thanks!
> >>> I think it's already fixes in the vhost tree.
> >>> That tree also includes a bugfix for the test.
> >>> Can you pls give it a spin and report?
> >>
> >> Mostly fixed: the xen_domain stup is missing.
> >>
> >> Jan
> >
> > That's in xen/xen.h. Do you still see any build errors?
>
> ca16cf7b30ca79eeca4d612af121e664ee7d8737 lacks this - forgot to add to
> some commit?
>
> Jan
Oh, you are right.
Should be fixed now.
Thanks!
--
MST
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] tools/virtio: Fix build
2019-10-13 13:29 ` Jan Kiszka
2019-10-13 13:39 ` Michael S. Tsirkin
@ 2019-10-13 13:39 ` Michael S. Tsirkin
1 sibling, 0 replies; 15+ messages in thread
From: Michael S. Tsirkin @ 2019-10-13 13:39 UTC (permalink / raw)
To: Jan Kiszka
Cc: Jason Wang, virtualization@lists.linux-foundation.org,
Linux Kernel Mailing List
On Sun, Oct 13, 2019 at 03:29:34PM +0200, Jan Kiszka wrote:
> On 13.10.19 14:20, Michael S. Tsirkin wrote:
> > On Sun, Oct 13, 2019 at 02:01:03PM +0200, Jan Kiszka wrote:
> >> On 13.10.19 13:52, Michael S. Tsirkin wrote:
> >>> On Sun, Oct 13, 2019 at 11:03:30AM +0200, Jan Kiszka wrote:
> >>>> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>>>
> >>>> Various changes in the recent kernel versions broke the build due to
> >>>> missing function and header stubs.
> >>>>
> >>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> >>>
> >>> Thanks!
> >>> I think it's already fixes in the vhost tree.
> >>> That tree also includes a bugfix for the test.
> >>> Can you pls give it a spin and report?
> >>
> >> Mostly fixed: the xen_domain stup is missing.
> >>
> >> Jan
> >
> > That's in xen/xen.h. Do you still see any build errors?
>
> ca16cf7b30ca79eeca4d612af121e664ee7d8737 lacks this - forgot to add to
> some commit?
>
> Jan
Oh, you are right.
Should be fixed now.
Thanks!
--
MST
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] tools/virtio: fix build
@ 2022-07-05 7:22 ` Stefano Garzarella
0 siblings, 0 replies; 15+ messages in thread
From: Stefano Garzarella @ 2022-07-05 7:22 UTC (permalink / raw)
To: virtualization; +Cc: linux-kernel, Michael S. Tsirkin
Fix the build caused by the following changes:
- phys_addr_t is now defined in tools/include/linux/types.h
- dev_warn_once() is used in drivers/virtio/virtio_ring.c
- linux/uio.h included by vringh.h use INT_MAX defined in limits.h
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
---
tools/virtio/linux/kernel.h | 2 +-
tools/virtio/linux/vringh.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/virtio/linux/kernel.h b/tools/virtio/linux/kernel.h
index 0b493542e61a..21593bf97755 100644
--- a/tools/virtio/linux/kernel.h
+++ b/tools/virtio/linux/kernel.h
@@ -29,7 +29,6 @@
#define READ 0
#define WRITE 1
-typedef unsigned long long phys_addr_t;
typedef unsigned long long dma_addr_t;
typedef size_t __kernel_size_t;
typedef unsigned int __wsum;
@@ -136,6 +135,7 @@ static inline void *krealloc_array(void *p, size_t new_n, size_t new_size, gfp_t
#endif
#define dev_err(dev, format, ...) fprintf (stderr, format, ## __VA_ARGS__)
#define dev_warn(dev, format, ...) fprintf (stderr, format, ## __VA_ARGS__)
+#define dev_warn_once(dev, format, ...) fprintf (stderr, format, ## __VA_ARGS__)
#define min(x, y) ({ \
typeof(x) _min1 = (x); \
diff --git a/tools/virtio/linux/vringh.h b/tools/virtio/linux/vringh.h
index 9348957be56e..e11c6aece734 100644
--- a/tools/virtio/linux/vringh.h
+++ b/tools/virtio/linux/vringh.h
@@ -1 +1,2 @@
+#include <limits.h>
#include "../../../include/linux/vringh.h"
--
2.36.1
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH] tools/virtio: fix build
@ 2022-07-05 7:22 ` Stefano Garzarella
0 siblings, 0 replies; 15+ messages in thread
From: Stefano Garzarella @ 2022-07-05 7:22 UTC (permalink / raw)
To: virtualization
Cc: Michael S. Tsirkin, linux-kernel, Jason Wang, Stefano Garzarella
Fix the build caused by the following changes:
- phys_addr_t is now defined in tools/include/linux/types.h
- dev_warn_once() is used in drivers/virtio/virtio_ring.c
- linux/uio.h included by vringh.h use INT_MAX defined in limits.h
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
---
tools/virtio/linux/kernel.h | 2 +-
tools/virtio/linux/vringh.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/virtio/linux/kernel.h b/tools/virtio/linux/kernel.h
index 0b493542e61a..21593bf97755 100644
--- a/tools/virtio/linux/kernel.h
+++ b/tools/virtio/linux/kernel.h
@@ -29,7 +29,6 @@
#define READ 0
#define WRITE 1
-typedef unsigned long long phys_addr_t;
typedef unsigned long long dma_addr_t;
typedef size_t __kernel_size_t;
typedef unsigned int __wsum;
@@ -136,6 +135,7 @@ static inline void *krealloc_array(void *p, size_t new_n, size_t new_size, gfp_t
#endif
#define dev_err(dev, format, ...) fprintf (stderr, format, ## __VA_ARGS__)
#define dev_warn(dev, format, ...) fprintf (stderr, format, ## __VA_ARGS__)
+#define dev_warn_once(dev, format, ...) fprintf (stderr, format, ## __VA_ARGS__)
#define min(x, y) ({ \
typeof(x) _min1 = (x); \
diff --git a/tools/virtio/linux/vringh.h b/tools/virtio/linux/vringh.h
index 9348957be56e..e11c6aece734 100644
--- a/tools/virtio/linux/vringh.h
+++ b/tools/virtio/linux/vringh.h
@@ -1 +1,2 @@
+#include <limits.h>
#include "../../../include/linux/vringh.h"
--
2.36.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH] tools/virtio: fix build
2022-07-05 7:22 ` Stefano Garzarella
(?)
@ 2022-07-06 6:39 ` Eugenio Perez Martin
-1 siblings, 0 replies; 15+ messages in thread
From: Eugenio Perez Martin @ 2022-07-06 6:39 UTC (permalink / raw)
To: Stefano Garzarella
Cc: virtualization, Michael S. Tsirkin, linux-kernel, Jason Wang
On Tue, Jul 5, 2022 at 9:32 AM Stefano Garzarella <sgarzare@redhat.com> wrote:
>
> Fix the build caused by the following changes:
> - phys_addr_t is now defined in tools/include/linux/types.h
> - dev_warn_once() is used in drivers/virtio/virtio_ring.c
> - linux/uio.h included by vringh.h use INT_MAX defined in limits.h
>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Acked-by: Eugenio Pérez <eperezma@redhat.com>
> ---
> tools/virtio/linux/kernel.h | 2 +-
> tools/virtio/linux/vringh.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/virtio/linux/kernel.h b/tools/virtio/linux/kernel.h
> index 0b493542e61a..21593bf97755 100644
> --- a/tools/virtio/linux/kernel.h
> +++ b/tools/virtio/linux/kernel.h
> @@ -29,7 +29,6 @@
> #define READ 0
> #define WRITE 1
>
> -typedef unsigned long long phys_addr_t;
> typedef unsigned long long dma_addr_t;
> typedef size_t __kernel_size_t;
> typedef unsigned int __wsum;
> @@ -136,6 +135,7 @@ static inline void *krealloc_array(void *p, size_t new_n, size_t new_size, gfp_t
> #endif
> #define dev_err(dev, format, ...) fprintf (stderr, format, ## __VA_ARGS__)
> #define dev_warn(dev, format, ...) fprintf (stderr, format, ## __VA_ARGS__)
> +#define dev_warn_once(dev, format, ...) fprintf (stderr, format, ## __VA_ARGS__)
>
> #define min(x, y) ({ \
> typeof(x) _min1 = (x); \
> diff --git a/tools/virtio/linux/vringh.h b/tools/virtio/linux/vringh.h
> index 9348957be56e..e11c6aece734 100644
> --- a/tools/virtio/linux/vringh.h
> +++ b/tools/virtio/linux/vringh.h
> @@ -1 +1,2 @@
> +#include <limits.h>
> #include "../../../include/linux/vringh.h"
> --
> 2.36.1
>
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2022-07-06 6:40 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-13 9:03 [PATCH] tools/virtio: Fix build Jan Kiszka
2019-10-13 11:52 ` Michael S. Tsirkin
2019-10-13 11:52 ` Michael S. Tsirkin
2019-10-13 12:01 ` Jan Kiszka
2019-10-13 12:01 ` Jan Kiszka
2019-10-13 12:20 ` Michael S. Tsirkin
2019-10-13 12:20 ` Michael S. Tsirkin
2019-10-13 13:29 ` Jan Kiszka
2019-10-13 13:29 ` Jan Kiszka
2019-10-13 13:39 ` Michael S. Tsirkin
2019-10-13 13:39 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2022-07-05 7:22 [PATCH] tools/virtio: fix build Stefano Garzarella
2022-07-05 7:22 ` Stefano Garzarella
2022-07-06 6:39 ` Eugenio Perez Martin
2019-10-13 9:03 [PATCH] tools/virtio: Fix build Jan Kiszka
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.