All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Revert "drm/radeon: Fix EEH during kexec"
@ 2019-10-09 18:15 Alex Deucher
  2019-10-14  3:54   ` Sasha Levin
       [not found] ` <20191009181503.20381-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
  0 siblings, 2 replies; 4+ messages in thread
From: Alex Deucher @ 2019-10-09 18:15 UTC (permalink / raw)
  To: amd-gfx, kmahlkuc; +Cc: Alex Deucher, stable

This reverts commit 6f7fe9a93e6c09bf988c5059403f5f88e17e21e6.

This breaks some boards.  Maybe just enable this on PPC for
now?

Bug: https://bugzilla.kernel.org/show_bug.cgi?id=205147
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
---
 drivers/gpu/drm/radeon/radeon_drv.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
index 4267cb55bc33..2bc56f829bf7 100644
--- a/drivers/gpu/drm/radeon/radeon_drv.c
+++ b/drivers/gpu/drm/radeon/radeon_drv.c
@@ -378,19 +378,11 @@ radeon_pci_remove(struct pci_dev *pdev)
 static void
 radeon_pci_shutdown(struct pci_dev *pdev)
 {
-	struct drm_device *ddev = pci_get_drvdata(pdev);
-
 	/* if we are running in a VM, make sure the device
 	 * torn down properly on reboot/shutdown
 	 */
 	if (radeon_device_is_virtual())
 		radeon_pci_remove(pdev);
-
-	/* Some adapters need to be suspended before a
-	* shutdown occurs in order to prevent an error
-	* during kexec.
-	*/
-	radeon_suspend_kms(ddev, true, true, false);
 }
 
 static int radeon_pmops_suspend(struct device *dev)
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Revert "drm/radeon: Fix EEH during kexec"
  2019-10-09 18:15 [PATCH] Revert "drm/radeon: Fix EEH during kexec" Alex Deucher
@ 2019-10-14  3:54   ` Sasha Levin
       [not found] ` <20191009181503.20381-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
  1 sibling, 0 replies; 4+ messages in thread
From: Sasha Levin @ 2019-10-14  3:54 UTC (permalink / raw)
  To: Sasha Levin, Alex Deucher, amd-gfx, kmahlkuc; +Cc: Alex Deucher, stable

Hi,

[This is an automated email]

This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all

The bot has tested the following trees: v5.3.5, v5.2.20, v4.19.78, v4.14.148, v4.9.196, v4.4.196.

v5.3.5: Build OK!
v5.2.20: Build OK!
v4.19.78: Build OK!
v4.14.148: Build OK!
v4.9.196: Build OK!
v4.4.196: Failed to apply! Possible dependencies:
    6f7fe9a93e6c0 ("drm/radeon: Fix EEH during kexec")
    a481daa88fd4d ("drm/radeon: always apply pci shutdown callbacks")
    a801abe4773da ("drm/radeon: wire up a pci shutdown callback")
    b9b487e494712 ("Revert "drm/radeon: always apply pci shutdown callbacks"")


NOTE: The patch will not be queued to stable trees until it is upstream.

How should we proceed with this patch?

-- 
Thanks,
Sasha

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Revert "drm/radeon: Fix EEH during kexec"
       [not found] ` <20191009181503.20381-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
@ 2019-10-14  3:54   ` Sasha Levin
  0 siblings, 0 replies; 4+ messages in thread
From: Sasha Levin @ 2019-10-14  3:54 UTC (permalink / raw)
  To: Sasha Levin, Alex Deucher,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
	kmahlkuc-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8
  Cc: Alex Deucher, stable-u79uwXL29TY76Z2rM5mHXA

Hi,

[This is an automated email]

This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all

The bot has tested the following trees: v5.3.5, v5.2.20, v4.19.78, v4.14.148, v4.9.196, v4.4.196.

v5.3.5: Build OK!
v5.2.20: Build OK!
v4.19.78: Build OK!
v4.14.148: Build OK!
v4.9.196: Build OK!
v4.4.196: Failed to apply! Possible dependencies:
    6f7fe9a93e6c0 ("drm/radeon: Fix EEH during kexec")
    a481daa88fd4d ("drm/radeon: always apply pci shutdown callbacks")
    a801abe4773da ("drm/radeon: wire up a pci shutdown callback")
    b9b487e494712 ("Revert "drm/radeon: always apply pci shutdown callbacks"")


NOTE: The patch will not be queued to stable trees until it is upstream.

How should we proceed with this patch?

-- 
Thanks,
Sasha
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Revert "drm/radeon: Fix EEH during kexec"
@ 2019-10-14  3:54   ` Sasha Levin
  0 siblings, 0 replies; 4+ messages in thread
From: Sasha Levin @ 2019-10-14  3:54 UTC (permalink / raw)
  To: Sasha Levin, Alex Deucher, amd-gfx, kmahlkuc
  Cc: Alex Deucher, stable, stable, stable

Hi,

[This is an automated email]

This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all

The bot has tested the following trees: v5.3.5, v5.2.20, v4.19.78, v4.14.148, v4.9.196, v4.4.196.

v5.3.5: Build OK!
v5.2.20: Build OK!
v4.19.78: Build OK!
v4.14.148: Build OK!
v4.9.196: Build OK!
v4.4.196: Failed to apply! Possible dependencies:
    6f7fe9a93e6c0 ("drm/radeon: Fix EEH during kexec")
    a481daa88fd4d ("drm/radeon: always apply pci shutdown callbacks")
    a801abe4773da ("drm/radeon: wire up a pci shutdown callback")
    b9b487e494712 ("Revert "drm/radeon: always apply pci shutdown callbacks"")


NOTE: The patch will not be queued to stable trees until it is upstream.

How should we proceed with this patch?

-- 
Thanks,
Sasha

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-10-14  3:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-09 18:15 [PATCH] Revert "drm/radeon: Fix EEH during kexec" Alex Deucher
2019-10-14  3:54 ` Sasha Levin
2019-10-14  3:54   ` Sasha Levin
     [not found] ` <20191009181503.20381-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2019-10-14  3:54   ` Sasha Levin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.