All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Wen He <wen.he_1@nxp.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Leo Li <leoyang.li@nxp.com>,
	"linux-devel@linux.nxdi.nxp.com" <linux-devel@linux.nxdi.nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [EXT] Re: [v2 2/2] arm64: dts: ls1028a: Update the DT node definition for dpclk
Date: Mon, 14 Oct 2019 14:21:52 +0800	[thread overview]
Message-ID: <20191014062150.GC12262@dragon> (raw)
In-Reply-To: <DB7PR04MB5195760127B83B88B68CC602E29A0@DB7PR04MB5195.eurprd04.prod.outlook.com>

On Tue, Oct 08, 2019 at 04:08:57AM +0000, Wen He wrote:
> 
> 
> > -----Original Message-----
> > From: Shawn Guo <shawnguo@kernel.org>
> > Sent: 2019年10月7日 20:35
> > To: Wen He <wen.he_1@nxp.com>
> > Cc: linux-devel@linux.nxdi.nxp.com; Leo Li <leoyang.li@nxp.com>; Rob Herring
> > <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> > linux-arm-kernel@lists.infradead.org
> > Subject: [EXT] Re: [v2 2/2] arm64: dts: ls1028a: Update the DT node definition
> > for dpclk
> > 
> > 
> > On Fri, Sep 20, 2019 at 04:34:19PM +0800, Wen He wrote:
> > > Update DT node name clock-controller to clock-display,
> > 
> > The node name clock-controller is so good, and I do not understand why you
> > need to change it.
> > 
> 
> The node name clock-controller used for the system clockgen and this clock only used for
> the Display core. 
> To clearly the node, that why I have to use clock-display to instead of the clock-controller

Label is being used to specify things, and node name should just be as
generic as possible.

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Wen He <wen.he_1@nxp.com>
Cc: "linux-devel@linux.nxdi.nxp.com" <linux-devel@linux.nxdi.nxp.com>,
	Leo Li <leoyang.li@nxp.com>, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [EXT] Re: [v2 2/2] arm64: dts: ls1028a: Update the DT node definition for dpclk
Date: Mon, 14 Oct 2019 14:21:52 +0800	[thread overview]
Message-ID: <20191014062150.GC12262@dragon> (raw)
In-Reply-To: <DB7PR04MB5195760127B83B88B68CC602E29A0@DB7PR04MB5195.eurprd04.prod.outlook.com>

On Tue, Oct 08, 2019 at 04:08:57AM +0000, Wen He wrote:
> 
> 
> > -----Original Message-----
> > From: Shawn Guo <shawnguo@kernel.org>
> > Sent: 2019年10月7日 20:35
> > To: Wen He <wen.he_1@nxp.com>
> > Cc: linux-devel@linux.nxdi.nxp.com; Leo Li <leoyang.li@nxp.com>; Rob Herring
> > <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> > linux-arm-kernel@lists.infradead.org
> > Subject: [EXT] Re: [v2 2/2] arm64: dts: ls1028a: Update the DT node definition
> > for dpclk
> > 
> > 
> > On Fri, Sep 20, 2019 at 04:34:19PM +0800, Wen He wrote:
> > > Update DT node name clock-controller to clock-display,
> > 
> > The node name clock-controller is so good, and I do not understand why you
> > need to change it.
> > 
> 
> The node name clock-controller used for the system clockgen and this clock only used for
> the Display core. 
> To clearly the node, that why I have to use clock-display to instead of the clock-controller

Label is being used to specify things, and node name should just be as
generic as possible.

Shawn

  reply	other threads:[~2019-10-14  6:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-20  8:34 [v2 1/2] arm64: dts: ls1028a: Update the clock providers for the Mali DP500 Wen He
2019-09-20  8:34 ` Wen He
2019-09-20  8:34 ` [v2 2/2] arm64: dts: ls1028a: Update the DT node definition for dpclk Wen He
2019-09-20  8:34   ` Wen He
2019-10-07 12:35   ` Shawn Guo
2019-10-07 12:35     ` Shawn Guo
2019-10-08  4:08     ` [EXT] " Wen He
2019-10-08  4:08       ` Wen He
2019-10-14  6:21       ` Shawn Guo [this message]
2019-10-14  6:21         ` Shawn Guo
2019-10-14  6:25         ` Wen He
2019-10-14  6:25           ` Wen He
2019-10-07 12:32 ` [v2 1/2] arm64: dts: ls1028a: Update the clock providers for the Mali DP500 Shawn Guo
2019-10-07 12:32   ` Shawn Guo
2019-10-07 12:32   ` Shawn Guo
2019-10-07 21:29   ` Leo Li
2019-10-07 21:29     ` Leo Li
2019-10-07 21:29     ` Leo Li
2019-10-14  6:19 ` Shawn Guo
2019-10-14  6:19   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191014062150.GC12262@dragon \
    --to=shawnguo@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-devel@linux.nxdi.nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=wen.he_1@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.