From: Shawn Guo <shawnguo@kernel.org>
To: "Sébastien Szymanski" <sebastien.szymanski@armadeus.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>,
Julien Boibessot <julien.boibessot@armadeus.com>,
Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] ARM: dts: imx28: add poweroff support
Date: Mon, 14 Oct 2019 14:38:07 +0800 [thread overview]
Message-ID: <20191014063801.GD12262@dragon> (raw)
In-Reply-To: <20190923091700.22517-1-sebastien.szymanski@armadeus.com>
On Mon, Sep 23, 2019 at 11:17:00AM +0200, Sébastien Szymanski wrote:
> This add poweroff support using the generic syscon-poweroff driver.
>
> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> ---
> arch/arm/boot/dts/imx28.dtsi | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> index e14d8ef0158b..37fa8131a022 100644
> --- a/arch/arm/boot/dts/imx28.dtsi
> +++ b/arch/arm/boot/dts/imx28.dtsi
> @@ -1114,8 +1114,16 @@
> };
>
> power: power@80044000 {
> + compatible = "syscon", "simple-mfd";
> reg = <0x80044000 0x2000>;
> - status = "disabled";
> +
> + mxs_poweroff: mxs-poweroff {
Node name should be generic. So 'poweroff' might be better.
> + compatible = "syscon-poweroff";
> + regmap = <&power>;
> + offset = <0x104>;
> + value = <0x3E770001>;
Use lowercase for hex value.
> + status = "disabled";
Why need to disable it by default?
Shawn
> + };
> };
>
> saif1: saif@80046000 {
> --
> 2.21.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: "Sébastien Szymanski" <sebastien.szymanski@armadeus.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>,
Julien Boibessot <julien.boibessot@armadeus.com>,
Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] ARM: dts: imx28: add poweroff support
Date: Mon, 14 Oct 2019 14:38:07 +0800 [thread overview]
Message-ID: <20191014063801.GD12262@dragon> (raw)
In-Reply-To: <20190923091700.22517-1-sebastien.szymanski@armadeus.com>
On Mon, Sep 23, 2019 at 11:17:00AM +0200, Sébastien Szymanski wrote:
> This add poweroff support using the generic syscon-poweroff driver.
>
> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> ---
> arch/arm/boot/dts/imx28.dtsi | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> index e14d8ef0158b..37fa8131a022 100644
> --- a/arch/arm/boot/dts/imx28.dtsi
> +++ b/arch/arm/boot/dts/imx28.dtsi
> @@ -1114,8 +1114,16 @@
> };
>
> power: power@80044000 {
> + compatible = "syscon", "simple-mfd";
> reg = <0x80044000 0x2000>;
> - status = "disabled";
> +
> + mxs_poweroff: mxs-poweroff {
Node name should be generic. So 'poweroff' might be better.
> + compatible = "syscon-poweroff";
> + regmap = <&power>;
> + offset = <0x104>;
> + value = <0x3E770001>;
Use lowercase for hex value.
> + status = "disabled";
Why need to disable it by default?
Shawn
> + };
> };
>
> saif1: saif@80046000 {
> --
> 2.21.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-14 6:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 9:17 [PATCH 1/1] ARM: dts: imx28: add poweroff support Sébastien Szymanski
2019-10-14 6:38 ` Shawn Guo [this message]
2019-10-14 6:38 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014063801.GD12262@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=julien.boibessot@armadeus.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sebastien.szymanski@armadeus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.