From: Lee Jones <lee.jones@linaro.org>
To: "RAVULAPATI, VISHNU VARDHAN RAO" <Vishnuvardhanrao.Ravulapati@amd.com>
Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
Maruthi Srinivas Bayyavarapu <Maruthi.Bayyavarapu@amd.com>,
open list <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"Mehta, Sanju" <Sanju.Mehta@amd.com>,
Mark Brown <broonie@kernel.org>,
"Mukunda, Vijendar" <Vijendar.Mukunda@amd.com>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
Colin Ian King <colin.king@canonical.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [alsa-devel] [PATCH 2/7] ASoC: amd: Registering device endpoints using MFD framework
Date: Mon, 14 Oct 2019 08:03:18 +0100 [thread overview]
Message-ID: <20191014070318.GC4545@dell> (raw)
In-Reply-To: <DM6PR12MB3868561CDEEF9D21940E8F57E7940@DM6PR12MB3868.namprd12.prod.outlook.com>
On Thu, 10 Oct 2019, RAVULAPATI, VISHNU VARDHAN RAO wrote:
> Hi Lee,
>
> We have two instances BT and I2S.
> We need to create devices with same name added with number of device
> like example:
> acp3x_i2s_playcap.1.auto<http://1.auto>
> acp3x_i2s_playcap.2.auto<http://2.auto>
>
> by using MFD we can make it happen automatically by giving
> "acp3x_i2s_playcap" and other extension will be added by MFD add device API.
The auto extension is handed by the platform_deivce_alloc() API.
platform_device_alloc("acp3x_i2s_playcap", PLATFORM_DEVID_AUTO);
> This helps us by rectifying the renaming issue which we get by using
> Platform_dev_create API`s.If we have to use platform related APIs then
> we need to give different naming conventions while creating the devices
> and cant use it in loop as we have 3 devices we need to call three
> explicitly.This make our code lengthy.
> If we use MFD it would help us a lot.
>
> Please suggest us how can we proceed.
You have 2 choices available to you based on whether your device is an
MFD or not:
If yes, move it (or a part of it) to drivers/mfd.
If no, then use the platform_device_*() API.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: "RAVULAPATI, VISHNU VARDHAN RAO" <Vishnuvardhanrao.Ravulapati@amd.com>
Cc: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
"Mukunda, Vijendar" <Vijendar.Mukunda@amd.com>,
Maruthi Srinivas Bayyavarapu <Maruthi.Bayyavarapu@amd.com>,
"Mehta, Sanju" <Sanju.Mehta@amd.com>,
Colin Ian King <colin.king@canonical.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
"moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/7] ASoC: amd: Registering device endpoints using MFD framework
Date: Mon, 14 Oct 2019 08:03:18 +0100 [thread overview]
Message-ID: <20191014070318.GC4545@dell> (raw)
In-Reply-To: <DM6PR12MB3868561CDEEF9D21940E8F57E7940@DM6PR12MB3868.namprd12.prod.outlook.com>
On Thu, 10 Oct 2019, RAVULAPATI, VISHNU VARDHAN RAO wrote:
> Hi Lee,
>
> We have two instances BT and I2S.
> We need to create devices with same name added with number of device
> like example:
> acp3x_i2s_playcap.1.auto<http://1.auto>
> acp3x_i2s_playcap.2.auto<http://2.auto>
>
> by using MFD we can make it happen automatically by giving
> "acp3x_i2s_playcap" and other extension will be added by MFD add device API.
The auto extension is handed by the platform_deivce_alloc() API.
platform_device_alloc("acp3x_i2s_playcap", PLATFORM_DEVID_AUTO);
> This helps us by rectifying the renaming issue which we get by using
> Platform_dev_create API`s.If we have to use platform related APIs then
> we need to give different naming conventions while creating the devices
> and cant use it in loop as we have 3 devices we need to call three
> explicitly.This make our code lengthy.
> If we use MFD it would help us a lot.
>
> Please suggest us how can we proceed.
You have 2 choices available to you based on whether your device is an
MFD or not:
If yes, move it (or a part of it) to drivers/mfd.
If no, then use the platform_device_*() API.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-10-14 7:04 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 0:58 [alsa-devel] [PATCH 1/7] ASoC: amd: No need PCI-MSI interrupts Ravulapati Vishnu vardhan rao
2019-10-01 0:58 ` Ravulapati Vishnu vardhan rao
2019-10-01 0:58 ` [alsa-devel] [PATCH 2/7] ASoC: amd: Registering device endpoints using MFD framework Ravulapati Vishnu vardhan rao
2019-10-01 0:58 ` Ravulapati Vishnu vardhan rao
2019-10-01 6:45 ` [alsa-devel] " Lee Jones
2019-10-01 10:00 ` vishnu
2019-10-01 10:00 ` vishnu
2019-10-01 12:00 ` [alsa-devel] " Lee Jones
2019-10-01 12:00 ` Lee Jones
2019-10-01 18:53 ` [alsa-devel] " Deucher, Alexander
2019-10-01 18:53 ` Deucher, Alexander
2019-10-02 12:37 ` [alsa-devel] " Lee Jones
2019-10-02 12:37 ` Lee Jones
2019-10-02 13:11 ` [alsa-devel] " Deucher, Alexander
2019-10-02 13:11 ` Deucher, Alexander
2019-10-02 13:35 ` [alsa-devel] " Lee Jones
2019-10-02 13:35 ` Lee Jones
2019-10-10 13:08 ` [alsa-devel] " RAVULAPATI, VISHNU VARDHAN RAO
2019-10-14 7:03 ` Lee Jones [this message]
2019-10-14 7:03 ` Lee Jones
2019-10-17 9:26 ` [alsa-devel] " vishnu
2019-10-17 9:26 ` vishnu
2019-10-01 0:58 ` [alsa-devel] [PATCH 3/7] ASoC: amd: Refactoring of DAI from DMA driver Ravulapati Vishnu vardhan rao
2019-10-01 0:58 ` Ravulapati Vishnu vardhan rao
2019-10-01 0:58 ` [alsa-devel] [PATCH 4/7] ASoC: amd: Enabling I2S instance in DMA and DAI Ravulapati Vishnu vardhan rao
2019-10-01 0:58 ` Ravulapati Vishnu vardhan rao
2019-10-01 0:58 ` [alsa-devel] [PATCH 5/7] ASoC: amd: add ACP3x TDM mode support Ravulapati Vishnu vardhan rao
2019-10-01 0:58 ` Ravulapati Vishnu vardhan rao
2019-10-01 0:58 ` [alsa-devel] [PATCH 6/7] ASoC: AMD: handle ACP3x i2s-sp watermark interrupt Ravulapati Vishnu vardhan rao
2019-10-01 0:58 ` Ravulapati Vishnu vardhan rao
2019-10-01 0:58 ` [alsa-devel] [PATCH 7/7] ASoc: amd: Added ACP3x system resume and runtime pm ops Ravulapati Vishnu vardhan rao
2019-10-01 0:58 ` Ravulapati Vishnu vardhan rao
2019-10-01 17:23 ` [alsa-devel] [PATCH 1/7] ASoC: amd: No need PCI-MSI interrupts Deucher, Alexander
2019-10-01 17:23 ` Deucher, Alexander
2019-10-01 17:29 ` [alsa-devel] " Mark Brown
2019-10-01 17:29 ` Mark Brown
2019-10-10 10:40 ` [alsa-devel] " vishnu
2019-10-10 10:40 ` vishnu
2019-10-17 9:33 ` [alsa-devel] " vishnu
2019-10-17 9:33 ` vishnu
2019-10-17 11:12 ` [alsa-devel] " Mark Brown
2019-10-17 11:12 ` Mark Brown
2019-10-17 13:56 ` [alsa-devel] " Deucher, Alexander
2019-10-17 13:56 ` Deucher, Alexander
2019-10-17 9:31 ` [alsa-devel] " vishnu
2019-10-17 9:31 ` vishnu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014070318.GC4545@dell \
--to=lee.jones@linaro.org \
--cc=Alexander.Deucher@amd.com \
--cc=Maruthi.Bayyavarapu@amd.com \
--cc=Sanju.Mehta@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=Vishnuvardhanrao.Ravulapati@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.